| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
Problem: Modifier keys are not always recognized.
Solution: Handle key codes generated by xterm with modifyOtherKeys set.
Add this to libvterm so we can debug it.
|
| |
|
|
|
|
| |
Problem: Some MB_ macros are more complicated than necessary. (Dominique
Pelle)
Solution: Simplify the macros. Expand inline.
|
| |
|
|
|
| |
Problem: Various memory leaks reported by asan.
Solution: Free the memory. (Ozaki Kiichi, closes #5003)
|
| |
|
|
|
|
| |
Problem: The terminal API is limited and can't be disabled.
Solution: Add term_setapi() to set the function prefix. (Ozaki Kiichi,
closes #2907)
|
| |
|
|
|
|
| |
Problem: Crash when trying to put a terminal buffer in a popup window.
Solution: Check for NULL buffer. Do not allow putting a terminal in a popup
window.
|
| |
|
|
|
| |
Problem: MS-Windows: compiler warnings for unused arguments.
Solution: Add UNUSED. (Yegappan Lakshmanan, closes #4963)
|
| |
|
|
|
| |
Problem: Some global functions can be local to the file.
Solution: Add "static". (Yegappan Lakshmanan, closes #4917)
|
| |
|
|
|
| |
Problem: More functions can be used as methods.
Solution: Make terminal functions usable as a method. Fix term_getattr().
|
| |
|
|
|
|
| |
Problem: 'langmap' is not used for CTRL-W command in terminal.
Solution: Push the command in the typeahead buffer instead of the stuff
buffer. (closes #4814)
|
| |
|
|
|
| |
Problem: Function call functions have too many arguments.
Solution: Pass values in a funcexe_T struct.
|
| |
|
|
|
|
| |
Problem: May start file dialog while exiting.
Solution: Ignore the "browse" modifier when exiting. (Ozaki Kiichi,
closes #4582
|
| |
|
|
|
| |
Problem: Callbacks may be garbage collected.
Solution: Set reference in callbacks. (Ozaki Kiichi, closes #4564)
|
| |
|
|
|
|
|
| |
Problem: Error message when terminal closes while it is not in the current
tab.
Solution: Also set "do_set_w_closing" when using the special autocommand
window. (closes #4552)
|
| |
|
|
|
| |
Problem: Cannot reuse a buffer when loading a screen dump.
Solution: Add the "bufnr" option.
|
| |
|
|
|
|
| |
Problem: Alloc() returning "char_u *" causes a lot of type casts.
Solution: Have it return "void *". (Mike Williams) Define ALLOC_ONE() to
check the simple allocations.
|
| |
|
|
|
| |
Problem: Unnecessary type casts.
Solution: Remove type casts from alloc() and lalloc() calls. (Mike Williams)
|
| |
|
|
|
| |
Problem: No popup window support.
Solution: Add initial code for popup windows. Add the 'wincolor' option.
|
| |
|
|
|
| |
Problem: Unessesary type casts for lalloc().
Solution: Remove type casts. Change lalloc(size, TRUE) to alloc(size).
|
| |
|
|
|
|
|
| |
Problem: Using bold attribute in terminal changes the color. (Jason
Franklin)
Solution: Don't set the "bold-highbright" flag in vterm unless the terminal
supports less than 16 colors.
|
| |
|
|
|
| |
Problem: Computing function length name in many places.
Solution: compute name length in call_func().
|
| |
|
|
|
|
| |
Problem: A lot of code is shared between vim.exe and gvim.exe.
Solution: Optionally put the shared code in vim.dll. (Ken Takata,
closes #4287)
|
| |
|
|
|
| |
Problem: Typos and small problems in source files.
Solution: Small fixes.
|
| |
|
|
|
| |
Problem: Some function prototypes are outdated.
Solution: Update function prototypes. (Ken Takata, closes #4267)
|
| |
|
|
|
|
| |
Problem: Unreachable code.
Solution: Remove condition that will never be true. Add tests for all ANSI
colors.
|
| |
|
|
|
| |
Problem: In MS-Windows console colors in a terminal window are wrong.
Solution: Use the ansi index also for 16 colors. (Ken Takata)
|
| |
|
|
|
| |
Problem: getwinpos() does not work in the MS-Windows console.
Solution: Implement getwinpos().
|
| |
|
|
|
| |
Problem: getwinpos() doesn't work in terminal on MS-Windows console.
Solution: Adjust #ifdefs. Disable test for MS-Windows console.
|
| |
|
|
|
|
| |
Problem: Libvterm does not handle the window position report.
Solution: Let libvterm call the fallback CSI handler when not handling CSI
sequence. Handle the window position report in Vim.
|
| |
|
|
|
|
| |
Problem: Too many curly braces.
Solution: Remove curly braces where they are not needed. (Hirohito Higashi,
closes #3982)
|
| |
|
|
|
| |
Problem: Stray log calls in terminal code. (Christian Brabandt)
Solution: Remove the calls.
|
| |
|
|
|
|
| |
Problem: Window cleared when entering Terminal-Normal twice. (Epheien)
Solution: Don't cleanup scrollback when there is no postponed scrollback.
(Christian Brabandt, closes #4126)
|
| |
|
|
|
| |
Problem: update_cursor() called twice in :shell.
Solution: Remove one of the calls. (Yasuhiro Matsumoto, closes #4039)
|
| |
|
|
|
|
|
| |
Problem: Macros for MS-Windows are inconsistent, using "32", "3264 and
others.
Solution: Use MSWIN for all MS-Windows builds. Use FEAT_GUI_MSWIN for the
GUI build. (Hirohito Higashi, closes #3932)
|
| |
|
|
|
| |
Problem: No error when requesting ConPTY but it's not available.
Solution: Add an error message. (Hirohito Higashi, closes #3967)
|
| |
|
|
|
| |
Problem: Terminal dump diff swap does not update file names.
Solution: Also swap the file name. Add a test.
|
| |
|
|
|
|
| |
Problem: Terminal test sometimes fails; using memory after free.
Solution: Fee memory a bit later. Add test to cover this. Disable flaky
screenshot test. (closes #3956)
|
| |
|
|
|
|
| |
Problem: In Terminal-Normal mode job output messes up the window.
Solution: Postpone scrolling and updating the buffer when in Terminal-Normal
mode.
|
| |
|
|
|
| |
Problem: MS-Windows: warning for signed/unsigned.
Solution: Add type cast. (Nobuhiro Takasaki, closes #3945)
|
| |
|
|
|
|
| |
Problem: MS-Windows: using ConPTY even though it is not stable.
Solution: When ConPTY version is unstable, prefer using winpty. (Ken Takata,
closes #3949)
|
| |
|
|
|
| |
Problem: ConPTY many crash with 32-bit build.
Solution: Fix function declarations. (Ken Takata, closes #3943)
|
| |
|
|
|
|
| |
Problem: MS-Windows: inconsistent selection of winpty/conpty.
Solution: Name option 'termwintype', use ++type argument and "term_pty" for
term_start(). (Hirohito Higashi, closes #3915)
|
| |
|
|
|
| |
Problem: Vim doesn't use the new ConPTY support in Windows 10.
Solution: Use ConPTY support, if available. (Nobuhiro Takasaki, closes #3794)
|
| |
|
|
|
| |
Problem: May use terminal after it was cleaned up.
Solution: Use the job pointer.
|
| |
|
|
|
|
|
| |
Problem: Having job_status() free the job causes problems.
Solution: Do not actually free the job or terminal yet, put it in a list and
free it a bit later. Do not use a terminal after checking the job
status. (closes #3873)
|
| |
|
|
|
|
| |
Problem: SunOS/Solaris has a problem with ttys.
Solution: Add mch_isatty() with extra handling for SunOS. (Ozaki Kiichi,
closes #3865)
|
| |
|
|
|
|
| |
Problem: Depending on the configuration some functions are unused.
Solution: Add more #ifdefs, remove unused functions. (Dominique Pelle,
closes #3822)
|
| |
|
|
|
|
| |
Problem: No proper test for using 'termencoding'.
Solution: Add a screendump test. Fix using double width characters in a
screendump.
|
| |
|
|
|
|
|
|
| |
Problem: Giving error messages is not flexible.
Solution: Add semsg(). Change argument from "char_u *" to "char *", also
for msg() and get rid of most MSG macros. (Ozaki Kiichi, closes
#3302) Also make emsg() accept a "char *" argument. Get rid of
an enormous number of type casts.
|
| |
|
|
|
| |
Problem: get_buf_tv() is named inconsistently.
Solution: Rename it to tv_get_buf(). (Yegappan Lakshmanan, closes #3759)
|
| |
|
|
|
| |
Problem: Coverity warns for possible use of NULL pointer.
Solution: Check return value of vterm_obtain_screen().
|
