| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
Problem: Illegal memory access when displaying a blob.
Solution: Append a NUL at the end. (Yegappan Lakshmanan, closes #9372)
|
| |
|
|
|
| |
Problem: Various comments could be improved.
Solution: Improve the comments.
|
| |
|
|
|
| |
Problem: Error messages are everywhere.
Solution: Move more error messages to errors.h and adjust the names.
|
| |
|
|
|
| |
Problem: Using freed memory with regexp using a mark.
Solution: Get the line again after getting the mark position.
|
| |
|
|
|
| |
Problem: Reading beyond end of line with invalid utf-8 character.
Solution: Check for NUL when advancing.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move a few more error messages to errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move error messages to errors.h and give them a clear name.
|
| |
|
|
|
|
| |
Problem: Variables are set but not used.
Solution: Move the declarations to the block where they are used.
(closes #8527)
|
| |
|
|
|
|
| |
Problem: A pattern that matches the cursor position is bit complicated.
Solution: Use a dot to indicate the cursor line and column. (Christian
Brabandt, closes #8497, closes #8179)
|
| |
|
|
|
| |
Problem: searching for \%'> does not match linewise end of line. (Tim Chase)
Solution: Match end of line if column is MAXCOL. (closes #8238)
|
| |
|
|
|
| |
Problem: Some comments are not correct or clear.
Solution: Adjust the comments. Add test for cursor position.
|
| |
|
|
|
|
| |
Problem: The equivalent class regexp is missing some characters.
Solution: Update the list of equivalent characters. (Dominique Pellé,
closes #8029)
|
| |
|
|
|
|
| |
Problem: Falling back to old regexp engine can some patterns.
Solution: Do not fall back once [[:lower:]] or [[:upper:]] is used.
(Christian Brabandt, closes #7572)
|
| |
|
|
|
| |
Problem: Valgrind warnings for using uninitialized value.
Solution: Do not use "start" or "end" unless there is a match.
|
| |
|
|
|
|
| |
Problem: Pattern "^" does not match if the first character in the line is
combining. (Rene Kita)
Solution: Do accept a match at the start of the line. (closes #6963)
|
| |
|
|
|
| |
Problem: Valgrind warning for using uninitialized value.
Solution: Do not use "startp" or "endp" unless there is a match.
|
| |
|
|
|
| |
Problem: Internal error when using \ze before \zs in a pattern.
Solution: Check the end is never before the start. (closes #7442)
|
| |
|
|
|
| |
Problem: Some error messages are internal but do not use iemsg().
Solution: Use iemsg(). (Dominique Pellé, closes #6894)
|
| |
|
|
|
| |
Problem: Unnecessary type casts for vim_strnsave().
Solution: Remove the type casts.
|
| |
|
|
|
| |
Problem: NFA regexp uses tolower() to compare ignore-case. (Thayne McCombs)
Solution: Use utf_fold() when possible. (ref. neovim #12456)
|
| |
|
|
|
|
| |
Problem: Ubsan warns for undefined behavior.
Solution: Use unsigned instead of signed variable. (Dominique Pelle,
closes #6193)
|
| |
|
|
|
| |
Problem: Clearing a struct is verbose.
Solution: Define and use CLEAR_FIELD() and CLEAR_POINTER().
|
| |
|
|
|
|
| |
Problem: Several lines of code are duplicated.
Solution: Move duplicated code to a function. (Yegappan Lakshmanan,
closes #5330)
|
| |
|
|
|
| |
Problem: Crash when make_extmatch() runs out of memory.
Solution: Check for NULL. (Dominique Pelle, closs #5392)
|
| |
|
|
|
| |
Problem: Using old C style comments.
Solution: Use // comments where appropriate.
|
| |
|
|
|
|
| |
Problem: Typos in comments.
Solution: Fix the typos. (Dominique Pelle, closes #5160) Also adjust
formatting a bit.
|
| |
|
|
|
|
| |
Problem: Alloc() returning "char_u *" causes a lot of type casts.
Solution: Have it return "void *". (Mike Williams) Define ALLOC_ONE() to
check the simple allocations.
|
| |
|
|
|
| |
Problem: Unnecessary type casts.
Solution: Remove type casts from alloc() and lalloc() calls. (Mike Williams)
|
| |
|
|
|
| |
Problem: Unessesary type casts for lalloc().
Solution: Remove type casts. Change lalloc(size, TRUE) to alloc(size).
|
| |
|
|
|
| |
Problem: Compiler warning for uninitialized variable.
Solution: Initialize it. (Christian Brabandt)
|
| |
|
|
|
|
| |
Problem: Too many curly braces.
Solution: Remove curly braces where they are not needed. (Hirohito Higashi,
closes #3982)
|
| |
|
|
|
|
|
| |
Problem: Pattern with syntax error gives threee error messages. (Kuang-che
Wu)
Solution: Remove outdated internal error. Don't fall back to other engine
after an error.
|
| |
|
|
|
| |
Problem: Crash when using search pattern \%Ufffffc23.
Solution: Limit character to INT_MAX. (closes #4009)
|
| |
|
|
|
|
| |
Problem: Compiling weird regexp pattern is very slow.
Solution: When reallocating post list increase size by 50%. (Kuang-che Wu,
closes #4012) Make assert_inrange() accept float values.
|
| |
|
|
|
|
| |
Problem: Internal error when using pattern with NL in the range.
Solution: Use an actual newline for the range. (closes #3989) Also fix
error message. (Dominique Pelle)
|
| |
|
|
|
| |
Problem: Compiler warnings.
Solution: Add type casts. (Mike Williams)
|
| |
|
|
|
| |
Problem: CI crashes when running out of memory.
Solution: Apply 'maxmempattern' also to new regexp engine.
|
| |
|
|
|
| |
Problem: Crash with tricky search pattern. (Kuang-che Wu)
Solution: Check for runnning out of memory. (closes #3950)
|
| |
|
|
|
| |
Problem: Can't handle large value for %{nr}v in regexp. (Kuang-che Wu)
Solution: Give an error if the value is too large. (closes #3948)
|
| |
|
|
|
| |
Problem: CI tests on AppVeyor are failing.
Solution: Reduce the recursiveness limit for regexp.
|
| |
|
|
|
| |
Problem: Complicated regexp causes a crash. (Kuang-che Wu)
Solution: Limit the recursiveness of addstate(). (closes #3941)
|
| |
|
|
|
|
| |
Problem: No verbose version of character classes.
Solution: Add [:ident:], [:keyword:] and [:fname:]. (Ozaki Kiichi,
closes #1373)
|
| |
|
|
|
| |
Problem: Too many #ifdefs.
Solution: Graduate FEAT_MBYTE, part 3.
|
| |
|
|
|
|
| |
Problem: printf format not checked for semsg().
Solution: Add GNUC attribute and fix reported problems. (Dominique Pelle,
closes #3805)
|
| |
|
|
|
|
|
|
| |
Problem: Giving error messages is not flexible.
Solution: Add semsg(). Change argument from "char_u *" to "char *", also
for msg() and get rid of most MSG macros. (Ozaki Kiichi, closes
#3302) Also make emsg() accept a "char *" argument. Get rid of
an enormous number of type casts.
|
| |
|
|
|
| |
Problem: No check for out-of-memory when converting regexp.
Solution: Bail out when lalloc() returns NULL. (John Marriott)
|
| |
|
|
|
| |
Problem: Executing regexp recursively fails with a crash.
Solution: Move global variables into "rex".
|
| |
|
|
|
|
| |
Problem: Invalid memory use with complicated pattern. (Andy Massimino)
Solution: Reallocate the list of listids when needed. (closes #3175)
Remove unnecessary function prototypes.
|
| |
|
|
|
| |
Problem: Can't build without the +eval feature.
Solution: Add #ifdef.
|
| |
|
|
|
| |
Problem: Exclamation mark in error message not needed.
Solution: Remove the exclamation mark.
|
