| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
Problem: The EBCDIC support is outdated.
Solution: Remove the EBCDIC support.
|
| |
|
|
|
| |
Problem: Some search tests fail.
Solution: Use a better way to reject searching for the Visual area.
|
| |
|
|
|
|
| |
Problem: Accessing invalid memory when a regular expression checks the
Visual area while matching in a string.
Solution: Do not try matching the Visual area in a string.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move the last error messages to errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
|
| |
|
|
|
| |
Problem: Using freed memory with /\%V.
Solution: Get the line again after getvvcol().
|
| |
|
|
|
| |
Problem: The funcexe_T struct members are not named consistently.
Solution: Prefix "fe_" to all the members.
|
| |
|
|
|
| |
Problem: Error messages are everywhere.
Solution: Move more error messages to errors.h and adjust the names.
|
| |
|
|
|
| |
Problem: The +title feature adds a lot of #ifdef but little code.
Solution: Graduate the +title feature.
|
| |
|
|
|
| |
Problem: Using freed memory with regexp using a mark.
Solution: Get the line again after getting the mark position.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move a few more error messages to errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move error messages to errors.h and give them a clear name.
|
| |
|
|
|
| |
Problem: Computing array length is done in various ways.
Solution: Use ARRAY_LENGTH everywhere. (Ken Takata, closes #8305)
|
| |
|
|
|
| |
Problem: Pattern "\%V" does not match all of block selection. (Rick Howe)
Solution: Use the value of vi_curswant. (closes #8285)
|
| |
|
|
|
|
| |
Problem: Vim9: cannot use \=expr in :substitute.
Solution: Compile the expression into instructions and execute them when
invoked.
|
| |
|
|
|
|
| |
Problem: Incsearch does not detect empty pattern properly.
Solution: Return magic state when skipping over a pattern. (Christian
Brabandt, closes #7612, closes #6420)
|
| |
|
|
|
|
| |
Problem: Falling back to old regexp engine can some patterns.
Solution: Do not fall back once [[:lower:]] or [[:upper:]] is used.
(Christian Brabandt, closes #7572)
|
| |
|
|
|
| |
Problem: Some error messages are internal but do not use iemsg().
Solution: Use iemsg(). (Dominique Pellé, closes #6894)
|
| |
|
|
|
| |
Problem: Compiler warning for use of fptr_T.
Solution: Make the type less strict.
|
| |
|
|
|
| |
Problem: Crash when using submatch(0, 1) in substitute().
Solution: Increment reference count. (closes #6887)
|
| |
|
|
|
|
| |
Problem: Vim9: leaking memory when using continuation line.
Solution: Keep a pointer to the continuation line in evalarg_T. Centralize
checking for a next command.
|
| |
|
|
|
| |
Problem: Unnecessary type casts for vim_strnsave().
Solution: Remove the type casts.
|
| |
|
|
|
| |
Problem: Vim9: no check for space before #comment.
Solution: Add space checks.
|
| |
|
|
|
| |
Problem: Clearing a struct is verbose.
Solution: Define and use CLEAR_FIELD() and CLEAR_POINTER().
|
| |
|
|
|
| |
Problem: Vim9: some code is not tested.
Solution: Add more tests. Fix uncovered problems.
|
| |
|
|
|
|
| |
Problem: Several lines of code are duplicated.
Solution: Move duplicated code to a function. (Yegappan Lakshmanan,
closes #5330)
|
| |
|
|
|
| |
Problem: test_clear_search_pat() is unused.
Solution: Remove the function. (Yegappan Lakshmanan, closes #5624)
|
| |
|
|
|
|
| |
Problem: Missing search/substitute pattern hardly tested.
Solution: Add test_clear_search_pat() and tests. (Yegappan Lakshmanan,
closes #5579)
|
| |
|
|
|
| |
Problem: Saving and restoring called_emsg is clumsy.
Solution: Count the number of error messages.
|
| |
|
|
|
| |
Problem: Using old C style comments.
Solution: Use // comments where appropriate.
|
| |
|
|
|
|
| |
Problem: Crash when passing many arguments through a partial. (Andy
Massimino)
Solution: Check the number of arguments. (closes #5186)
|
| |
|
|
|
| |
Problem: Crash when passing partial to substitute().
Solution: Take extra arguments into account. (closes #5186)
|
| |
|
|
|
|
| |
Problem: The regexp.c file is too big.
Solution: Move the backtracking engine to a separate file. (Yegappan
Lakshmanan, closes #4905)
|
| |
|
|
|
| |
Problem: Code for handling file names is spread out.
Solution: Move code to new filepath.c file. Graduate FEAT_MODIFY_FNAME.
|
| |
|
|
|
| |
Problem: Functions used in one file are global.
Solution: Add "static". (Yegappan Lakshmanan, closes #4840)
|
| |
|
|
|
|
| |
Problem: Allocating more memory than needed for extended structs.
Solution: Use offsetof() instead of sizeof(). (Dominique Pelle,
closes #4786)
|
| |
|
|
|
| |
Problem: Function call functions have too many arguments.
Solution: Pass values in a funcexe_T struct.
|
| |
|
|
|
| |
Problem: Crash with very long %[] pattern. (Reza Mirzazade farkhani)
Solution: Check for reg_toolong. (closes #4703)
|
| |
|
|
|
|
| |
Problem: Alloc() returning "char_u *" causes a lot of type casts.
Solution: Have it return "void *". (Mike Williams) Define ALLOC_ONE() to
check the simple allocations.
|
| |
|
|
|
| |
Problem: Unessesary type casts for lalloc().
Solution: Remove type casts. Change lalloc(size, TRUE) to alloc(size).
|
| |
|
|
|
|
| |
Problem: Using "int" for alloc() often results in compiler warnings.
Solution: Use "size_t" and remove type casts. Remove alloc_check(), Vim
only works with 32 bit ints anyway.
|
| |
|
|
|
| |
Problem: Computing function length name in many places.
Solution: compute name length in call_func().
|
| |
|
|
|
| |
Problem: Always get regexp debugging logs when building with -DDEBUG.
Solution: By default do not create regexp debugging logs. (Ken Takata)
|
| |
|
|
|
| |
Problem: Warnings from clang static analyzer. (Yegappan Lakshmanan)
Solution: Fix relevant warnings.
|
| |
|
|
|
| |
Problem: Checking NULL pointer after addition. (Coverity)
Solution: First check for NULL, then add the column.
|
| |
|
|
|
|
| |
Problem: Various small code ugliness.
Solution: Remove pointless NULL checks. Fix function calls. Fix typos.
(Dominique Pelle, closes #4060)
|
