| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
Problem: "clear" macros are not always used.
Solution: Use ALLOC_ONE, VIM_CLEAR, CLEAR_POINTER and CLEAR_FIELD in more
places. (Yegappan Lakshmanan, closes #12104)
|
| |
|
|
|
|
| |
Problem: FOR_ALL_ macros are defined in an unexpected file.
Solution: Move FOR_ALL_ macros to macros.h. Add FOR_ALL_HASHTAB_ITEMS.
(Yegappan Lakshmanan, closes #12109)
|
| |
|
|
|
| |
Problem: Functions without arguments are not always declared properly.
Solution: Use "(void)" instead of "()". (Yegappan Lakshmanan, closes #12031)
|
| |
|
|
|
|
| |
Problem: Code is indented more than necessary.
Solution: Use an early return where it makes sense. (Yegappan Lakshmanan,
closes #11833)
|
| |
|
|
|
|
| |
Problem: Callback name argument is changed by setqflist().
Solution: Use the expanded function name for the callback, do not store it
in the argument. (closes #11653)
|
| |
|
|
|
| |
Problem: 'scrolloff' does not work well with 'smoothscroll'.
Solution: Make positioning the cursor a bit better. Rename functions.
|
| |
|
|
|
|
| |
Problem: Cannot specify a time for :echowindow.
Solution: A count can be used to specify the display time. Add
popup_findecho().
|
| |
|
|
|
|
| |
Problem: Message window popup shows on only one tab page. (Naruhiko
Nishino)
Solution: Show the message window popup on all tab pages. (closes #11231)
|
| |
|
|
|
| |
Problem: Mode message is delayed when :echowin was used. (Maxim Kim)
Solution: Save and restore msg_didout in :echowin. (closes #11193)
|
| |
|
|
|
|
| |
Problem: Using :echowin while at the hit-enter prompt causes problems.
Solution: Do not prompt for :echowin. Postpone showing the message window.
Start the timer when the window is displayed.
|
| |
|
|
|
| |
Problem: Message window may be positioned too low.
Solution: Compute cmdline_row before computing the position.
|
| |
|
|
|
| |
Problem: Current mode shows in message window.
Solution: Reset in_echowindow before redrawing. (issue #11094)
|
| |
|
|
|
|
| |
Problem: Error message for wrong argument type is not specific.
Solution: Include more information in the error. (Yegappan Lakshmanan,
closes #11037)
|
| |
|
|
|
| |
Problem: Message window may obscure the command line.
Solution: Reduce the maximum height of the message window.
|
| |
|
|
|
| |
Problem: :echowindow does not work in a compiled function.
Solution: Handle the expression at compile time.
|
| |
|
|
|
| |
Problem: The 'cmdheight' zero support causes too much trouble.
Solution: Revert support for 'cmdheight' being zero.
|
| |
|
|
|
| |
Problem: Checks for Dictionary argument often give a vague error message.
Solution: Give a useful error message. (Yegappan Lakshmanan, closes #11009)
|
| |
|
|
|
| |
Problem: Cannot use the message popup window directly.
Solution: Add ":echowindow".
|
| |
|
|
|
|
| |
Problem: When updating the whole screen a popup may not be redrawn.
Solution: Mark the screen and windows for redraw also when not clearing.
Also mark popup windows for redraw.
|
| |
|
|
|
|
| |
Problem: Message in popup is shortened unnecessary.
Solution: Do not use 'showcmd' and 'ruler' for a message in the popup.
Set the timer when unhiding the message popup.
|
| |
|
|
|
|
| |
Problem: Crash when 'cmdheight' is 0 and popup_clear() used.
Solution: Reset "message_win" when the message popup is cleared. Close the
popup when 'cmdheight' is non-zero. Add a screendump test.
|
| |
|
|
|
| |
Problem: When 'cmdheight' is zero some messages are not displayed.
Solution: Use a popup notification window.
|
| |
|
|
|
| |
Problem: Redraw flags are not named specifically.
Solution: Prefix "UPD_" to the flags, for UPDate_screen().
|
| |
|
|
|
| |
Problem: Various minor code formatting issues.
Solution: Improve code formatting.
|
| |
|
|
|
| |
Problem: Cannot show virtual text.
Solution: Initial changes for virtual text support, using text properties.
|
| |
|
|
|
| |
Problem: Too many type casts for dict_get functions.
Solution: Change the key argument from "char_u *" to "char *".
|
| |
|
|
|
| |
Problem: Various small issues.
Solution: Various small improvments.
|
| |
|
|
|
|
| |
Problem: Can escape a terminal popup window when the job is finished.
Solution: Only check for a finished job where it is relevant.
(closes #10253)
|
| |
|
|
|
| |
Problem: Scrollbar thumb in tall scrolled popup not visible.
Solution: Show at least one thumb character. (fixes 10492)
|
| |
|
|
|
| |
Problem: Scrollbar thumb in scrolled popup not visible.
Solution: Show at least one thumb character. (fixes 10492)
|
| |
|
|
|
| |
Problem: Confusing error if first argument of popup_create() is wrong.
Solution: Give a more informative error.
|
| |
|
|
|
|
| |
Problem: A finished terminal in a popup window does not show a scrollbar.
Solution: Show the scrollbar if the terminal job is finished. (closes
#10497)
|
| |
|
|
|
| |
Problem: Popup_hide() does not always have effect.
Solution: Add the POPF_HIDDEN_FORCE flag. (closes #10376)
|
| |
|
|
|
| |
Problem: Popup does not use correct topline.
Solution: Also add one when firstline is negative. (closes #10229)
|
| |
|
|
|
|
| |
Problem: When a swap file is found for a popup there is no dialog and the
buffer is loaded anyway.
Solution: Silently load the buffer read-only. (closes #10073)
|
| |
|
|
|
| |
Problem: Verbose check with dict_find() to see if a key is present.
Solution: Add dict_has_key(). (Yegappan Lakshmanan, closes #10074)
|
| |
|
|
|
|
| |
Problem: Buffer allocation failures insufficiently tested.
Solution: Add tests for memory allocation failures. (Yegappan Lakshmanan,
closes #10064)
|
| |
|
|
|
| |
Problem: Popup with "minwidth" and scrollbar not updated properly.
Solution: Adjust the computation if the window width. (closes #10061)
|
| |
|
|
|
|
| |
Problem: Mapping is cancelled when mouse moves and popup is visible.
Solution: Only generate mouse moved events when a popup may use them.
(closes #10004)
|
| |
|
|
|
| |
Problem: Coverity warning for not using a return value.
Solution: Add "(void)".
|
| |
|
|
|
| |
Problem: Theoretical computation overflow.
Solution: Perform multiplication in a wider type. (closes #9657)
|
| |
|
|
|
| |
Problem: Two error messages in the wrong file.
Solution: Use the error message from errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move more errors to errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move more errors to errors.h.
|
| |
|
|
|
| |
Problem: Cannot highlight the number column for a sign.
Solution: Add the "numhl" argument. (James McCoy, closes #9381)
|
| |
|
|
|
|
|
| |
Problem: When editing the command line a FocusLost callback may cause the
screen to scroll up.
Solution: Do not redraw at the last line but at the same place where the
command line was before. (closes #9295)
|
| |
|
|
|
| |
Problem: Error messages are everywhere.
Solution: Move more error messages to errors.h and adjust the names.
|
| |
|
|
|
| |
Problem: Cannot drag a popup without a border.
Solution: Add the "dragall" option. (closes #9218)
|
