| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
Problem: Build failure with small features.
Solution: Add #ifdef.
|
| |
|
|
|
|
| |
Problem: A second popup window with terminal causes trouble.
Solution: Disallow opening a second terminal-popup window. (closes #6101,
closes #6103) Avoid defaulting to an invalid line number.
|
| |
|
|
|
|
| |
Problem: Vim9: performance can be improved.
Solution: Don't call break. Inline check for list materialize. Make an
inline version of ga_grow().
|
| |
|
|
|
| |
Problem: Cannot get a list of all popups.
Solution: Add popup_list(). Use it in the test runner.
|
| |
|
|
|
|
| |
Problem: Cannot forcefully close all popups.
Solution: Add the "force" argument to popup_clear(). Use it after running a
test. Put back the check for a popup when editing a file.
|
| |
|
|
|
| |
Problem: popup_clear() hangs when a popup can't be closed.
Solution: Bail out when a popup can't be closed.
|
| |
|
|
|
| |
Problem: Loops are repeated.
Solution: Use FOR_ALL_ macros. (Yegappan Lakshmanan, closes #5882)
|
| |
|
|
|
| |
Problem: Coverity complains about using uninitialized variable.
Solution: Assign a value to "scol". Move code inside NULL check.
|
| |
|
|
|
| |
Problem: Using the same loop in many places.
Solution: Define more FOR_ALL macros. (Yegappan Lakshmanan, closes #5339)
|
| |
|
|
|
| |
Problem: Tiny popup when creating a terminal popup without minwidth.
Solution: Use a default mininum size of 5 lines of 20 characters.
|
| |
|
|
|
| |
Problem: Coverity warning for not using return value.
Solution: Move error message to separate function.
|
| |
|
|
|
|
| |
Problem: Crash with combination of terminal popup and autocmd.
Solution: Disallow closing a popup that is the current window. Add a check
that the current buffer is valid. (closes #5754)
|
| |
|
|
|
| |
Problem: popup_atcursor() may hang. (Yasuhiro Matsumoto)
Solution: Take the decoration into account. (closes #5728)
|
| |
|
|
|
| |
Problem: Build error with popup window but without terminal.
Solution: Add #ifdef.
|
| |
|
|
|
| |
Problem: Popup filter converts 0x80 bytes.
Solution: Keep 0x80 bytes as-is. (Ozaki Kiichi, closes #5706)
|
| |
|
|
|
|
| |
Problem: No redraw when leaving terminal-normal mode in a terminal popup
window.
Solution: Redraw the popup window. (closes #5708)
|
| |
|
|
|
| |
Problem: Crash when opening and closing two popup terminal windows.
Solution: Check that prevwin is valid. (closes #5707)
|
| |
|
|
|
| |
Problem: Cannot use popup_close() for a terminal popup.
Solution: Allow using popup_close(). (closes #5666)
|
| |
|
|
|
| |
Problem: A popup window with a terminal can be made hidden.
Solution: Disallow hiding a terminal popup.
|
| |
|
|
|
| |
Problem: Error code E899 used twice.
Solution: Use E863 for the terminal in popup error.
|
| |
|
|
|
| |
Problem: Blocking commands for a finished job in a popup window.
Solution: Do not block commands if the job has finished. Adjust test.
|
| |
|
|
|
| |
Problem: Some commands can cause problems in terminal popup.
Solution: Disallow more commands.
|
| |
|
|
|
| |
Problem: Build failure without +terminal feature.
Solution: Add #ifdefs.
|
| |
|
|
|
|
| |
Problem: Cannot put a terminal in a popup window.
Solution: Allow opening a terminal in a popup window. It will always have
keyboard focus until closed.
|
| |
|
|
|
| |
Problem: Still a few places where range() does not work.
Solution: Fix using range() causing problems.
|
| |
|
|
|
| |
Problem: Possible to enter popup window with CTRL-W p. (John Devin)
Solution: Check entered window is not a popup window. (closes #5515)
|
| |
|
|
|
| |
Problem: Crash when cycling to buffers involving popup window .
Solution: Do not decrement buffer reference count.
|
| |
|
|
|
| |
Problem: Cannot create tiny popup window in last column. (Daniel Steinberg)
Solution: Remove position limit. (closes #5447)
|
| |
|
|
|
|
| |
Problem: Crash when calling popup_close() in win_execute().
Solution: Disallow popup_close() in popup window. (Yasuhiro Matsumoto,
closes #5345)
|
| |
|
|
|
| |
Problem: Cannot build with +popupwin but without +quickfix. (John Marriott)
Solution: Adjust #ifdefs.
|
| |
|
|
|
| |
Problem: FEAT_TEXT_PROP is a confusing name.
Solution: Use FEAT_PROP_POPUP. (Naruhiko Nishino, closes #5291)
|
| |
|
|
|
|
| |
Problem: Cannot place signs in a popup window. (Maxim Kim)
Solution: Use the group prefix "PopUp" to specify which signs should show up
in a popup window. (closes #5277)
|
| |
|
|
|
| |
Problem: Possible NULL pointer dereference in popup_locate(). (Coverity)
Solution: Check for NULL pointer.
|
| |
|
|
|
| |
Problem: Positioning popup doesn't work for buffer-local textprop.
Solution: Make it work. (closes #5225)
|
| |
|
|
|
| |
Problem: Cannot get the mouse position when getting a mouse click.
Solution: Add getmousepos().
|
| |
|
|
|
| |
Problem: Redraw breaks going through list of popup windows.
Solution: Use different flags for popup_reset_handled(). (closes #5216)
|
| |
|
|
|
| |
Problem: v:mouse_winid not set on click in popup window.
Solution: Set v:mouse_winid. (closes #5171)
|
| |
|
|
|
|
| |
Problem: Not using all space when popup with "topleft" flips to above.
Solution: Recompute the height when a popup flips from below to above.
(closes #5151)
|
| |
|
|
|
| |
Problem: Using border highlight in popup window leaks memory.
Solution: Free memory before overwriting. (Dominique Pelle, closes #5203)
|
| |
|
|
|
|
| |
Problem: Wrong default when "pos" is changed with popup_atcursor().
Solution: Adjust the default line and col when "pos" is not the default
value. (#5151)
|
| |
|
|
|
| |
Problem: Position unknown for a mouse click in a popup window.
Solution: Set v:mouse_col and v:mouse_lnum. (closes #5171)
|
| |
|
|
|
|
|
| |
Problem: When popup with "botleft" does not fit it flips incorrectly.
Solution: Only flip when there is more space on the other side. Add the
"posinvert" option to disable flipping and do it in both
directions if enabled. (closes #5151)
|
| |
|
|
|
|
| |
Problem: CTRL-U and CTRL-D don't work in popup window.
Solution: Initialize 'scroll'. Add "lastline" in popup_getpos().
(closes #5170)
|
| |
|
|
|
|
| |
Problem: Popup window width changes when scrolling.
Solution: Also adjust maxwidth when applying minwidth and there is a
scrollbar. Fix off-by-one error. (closes #5162)
|
| |
|
|
|
| |
Problem: Popup_textprop tests fail.
Solution: Adjust the column and line positioning.
|
| |
|
|
|
| |
Problem: Using negative offset for popup_create() does not work.
Solution: Use -1 instead of zero. (closes #5111)
|
| |
|
|
|
|
| |
Problem: Popup_setoptions(popup_getoptions()) does not work.
Solution: Also accept a list with three entries for "moved" and
"mousemoved". (closes #5081)
|
| |
|
|
|
| |
Problem: Cannot easily fill the info popup asynchronously.
Solution: Add the "popuphidden" value to 'completeopt'. (closes #4924)
|
| |
|
|
|
|
| |
Problem: Stuck when using "j" in a popupwin with popup_filter_menu if a
line wraps.
Solution: Check the cursor line is visible. (closes #4577)
|
| |
|
|
|
| |
Problem: When a popup is closed with CTRL-C the callback aborts.
Solution: Reset got_int when invoking the callback. (closes #5008)
|
