| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
Problem: assert_fails() checks the last error message.
Solution: Check the first error, it is more relevant. Fix all the tests
that rely on the old behavior.
|
| |
|
|
|
| |
Problem: Using old C style comments.
Solution: Use // comments where appropriate.
|
| |
|
|
|
| |
Problem: Still cannot build with eval but without cscope.
Solution: Move f_cscope_connection() outside of #ifdef.
|
| |
|
|
|
|
|
| |
Problem: The evalfunc.c file is still too big.
Solution: Move f_pathshorten() to filepath.c. Move f_cscope_connection() to
if_cscope.c. Move diff_ functions to diff.c. Move timer_
functions to ex_cmds2.c. move callback functions to evalvars.c.
|
| |
|
|
|
| |
Problem: Code for handling file names is spread out.
Solution: Move code to new filepath.c file. Graduate FEAT_MODIFY_FNAME.
|
| |
|
|
|
| |
Problem: The +cmdline_compl feature is not in the tiny version.
Solution: Graduate the +cmdline_compl feature.
|
| |
|
|
|
|
| |
Problem: Alloc() returning "char_u *" causes a lot of type casts.
Solution: Have it return "void *". (Mike Williams) Define ALLOC_ONE() to
check the simple allocations.
|
| |
|
|
|
|
| |
Problem: Using "int" for alloc() often results in compiler warnings.
Solution: Use "size_t" and remove type casts. Remove alloc_check(), Vim
only works with 32 bit ints anyway.
|
| |
|
|
|
|
|
| |
Problem: Cannot recover from a swap file.
Solution: Do not expand environment variables in the swap file name.
Do not check the extension when we already know a file is a swap
file. (Ken Takata, closes 4415, closes #4369)
|
| |
|
|
|
|
|
| |
Problem: Macros for MS-Windows are inconsistent, using "32", "3264 and
others.
Solution: Use MSWIN for all MS-Windows builds. Use FEAT_GUI_MSWIN for the
GUI build. (Hirohito Higashi, closes #3932)
|
| |
|
|
|
| |
Problem: Argument for message functions is inconsistent.
Solution: Make first argument to msg() "char *".
|
| |
|
|
|
|
| |
Problem: printf format not checked for semsg().
Solution: Add GNUC attribute and fix reported problems. (Dominique Pelle,
closes #3805)
|
| |
|
|
|
|
|
|
| |
Problem: Giving error messages is not flexible.
Solution: Add semsg(). Change argument from "char_u *" to "char *", also
for msg() and get rid of most MSG macros. (Ozaki Kiichi, closes
#3302) Also make emsg() accept a "char *" argument. Get rid of
an enormous number of type casts.
|
| |
|
|
|
| |
Problem: Unnecessary static function prototypes.
Solution: Remove unnecessary prototypes.
|
| |
|
|
|
| |
Problem: File type checking has too many #ifdef.
Solution: Always define the S_IF macros. (Ken Takata, closes #3306)
|
| |
|
|
|
| |
Problem: Expanding a file name "~" results in $HOME. (Aidan Shafran)
Solution: Change "~" to "./~" before expanding. (closes #3072)
|
| |
|
|
|
|
| |
Problem: Too many #ifdefs.
Solution: Graduate the +autocmd feature. Takes away 450 #ifdefs and
increases code size of tiny Vim by only 40 Kbyte.
|
| |
|
|
|
|
| |
Problem: Clearing a pointer takes two lines.
Solution: Add VIM_CLEAR() and replace vim_clear(). (Hirohito Higashi,
closes #2629)
|
| |
|
|
|
| |
Problem: Using pointer before it is set.
Solution: Search in whole buffer instead of next token.
|
| |
|
|
|
|
| |
Problem: If cscope fails a search Vim may hang.
Solution: Bail out when a search error is encountered. (Safouane Baroudi,
closes #2598)
|
| |
|
|
|
|
| |
Problem: FEAT_WINDOWS adds a lot of #ifdefs while it is nearly always
enabled and only adds 7% to the binary size of the tiny build.
Solution: Graduate FEAT_WINDOWS.
|
| |
|
|
|
| |
Problem: There are still a few macros that should be all-caps.
Solution: Make a few more macros all-caps.
|
| |
|
|
|
| |
Problem: Some macros are in lower case.
Solution: Make a few more macros upper case.
|
| |
|
|
|
|
| |
Problem: When running :make the output may be in the system encoding,
different from 'encoding'.
Solution: Add the 'makeencoding' option. (Ken Takata)
|
| |
|
|
|
|
| |
Problem: Build fails with tiny features.
Solution: Change #ifdef for hash_clear(). Avoid warning for unused
argument.
|
| |
|
|
|
| |
Problem: Inconsistent function names.
Solution: Rename do_cscope to ex_cscope. Clean up comments.
|
| |
|
|
|
|
| |
Problem: Cannot make Vim fail on an internal error.
Solution: Add IEMSG() and IEMSG2(). (Domenique Pelle) Avoid reporting an
internal error without mentioning where.
|
| |
|
|
|
|
| |
Problem: Checking did_throw after executing autocommands is wrong. (Daniel
Hahler)
Solution: Call aborting() instead, and only when autocommands were executed.
|
| |
|
|
|
|
| |
Problem: Code for MS-Windows is complicated because of the exceptions for
old systems.
Solution: Drop support for MS-Windows older than Windows XP. (Ken Takata)
|
| |
|
|
|
| |
Problem: Modelines in source code are inconsistant.
Solution: Use the same line in most files. Add 'noet'. (Naruhiko Nishino)
|
| |
|
|
|
| |
Problem: Cscope items are not sorted.
Solution: Put the new "a" command first. (Ken Takata)
|
| |
|
|
|
|
| |
Problem: On MS-Windows large files (> 2Gbyte) cause problems.
Solution: Use "off_T" instead of "off_t". Use "stat_T" instead of "struct
stat". Use 64 bit system functions if available. (Ken Takata)
|
| |
|
|
|
| |
Problem: Cscope interface does not support finding assignments.
Solution: Add the "a" command. (ppettina, closes #882)
|
| |
|
|
|
| |
Problem: Leaking memory in cscope interface.
Solution: Free memory when no tab is found. (Christian Brabandt)
|
| |
|
|
|
| |
Problem: Leaking memory in cs_print_tags_priv().
Solution: Free tbuf. (idea by Forrest Fleming)
|
| |
|
|
|
| |
Problem: Many compiler warnings with MingW.
Solution: Add type casts. (Yasuhiro Matsumoto)
|
| |
|
|
|
|
| |
Problem: Using old style function declarations.
Solution: Change to new style function declarations. (script by Hirohito
Higashi)
|
| |
|
|
|
|
| |
Problem: Still using __ARGS.
Solution: Remove __ARGS in several files. (script by Hirohito Higashi)
Also remove use of HAVE_STDARG_H.
|
| |
|
|
|
| |
Problem: More problems reported by coverity.
Solution: Avoid the warnings. (Christian Brabandt)
|
| |
|
|
|
|
| |
Problem: When starting several Vim instances in diff mode, the temp files
used may not be unique. (Issue 353)
Solution: Add an argument to vim_tempname() to keep the file.
|
| |
|
|
|
| |
Problem: May leak memory or crash when vim_realloc() returns NULL.
Solution: Handle a NULL value properly. (Mike Williams)
|
| |
|
|
|
|
| |
Problem: Warnings for unused arguments when compiling with a combination of
features.
Solution: Add "UNUSED".
|
| |
|
|
|
|
| |
Problem: When using a cscope connection resizing the window may send
SIGWINCH to cscope and it quits.
Solution: Call setpgid(0, 0) in the child process. (Narendran Gopalakrishnan)
|
| |
|
|
|
|
| |
Problem: When current directory changes, path from cscope may no longer be
valid. (AS Budden)
Solution: Always store the absolute path. (Christian Brabandt)
|
| |
|
|
|
|
| |
Problem: Crash when using Cscope.
Solution: Avoid negative argument to vim_strncpy(). (Narendran
Gopalakrishnan)
|
| |
|
|
|
| |
Problem: Typos in source files.
Solution: Fix the typos. (Ken Takata)
|
| |
|
|
|
| |
Problem: Compiler warning.
Solution: Add type cast.
|
| |
|
|
|
| |
Problem: Can't always find the file when using cscope.
Solution: Add the 'cscoperelative' option. (Raghavendra D Prabhu)
|
| |
|
|
|
|
|
| |
Problem: MS-Windows: rename() might delete the file if the name differs but
it's actually the same file.
Solution: Use the file handle to check if it's the same file. (Yukihiro
Nakadaira)
|
| |
|
|
|
| |
Problem: Duplicate include of assert.h.
Solution: Remove it.
|
