| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
Problem: Code is indented too much.
Solution: Use an early return. (Yegappan Lakshmanan, closes #11386)
|
| |
|
|
|
|
| |
Problem: Cygwin: multibyte characters may be broken in terminal window.
Solution: Adjust how to read and write on the channel. (Ken Takata,
closes #11063)
|
| |
|
|
|
| |
Problem: :echowindow does not work in a compiled function.
Solution: Handle the expression at compile time.
|
| |
|
|
|
| |
Problem: Checks for Dictionary argument often give a vague error message.
Solution: Give a useful error message. (Yegappan Lakshmanan, closes #11009)
|
| |
|
|
|
| |
Problem: Redraw flags are not named specifically.
Solution: Prefix "UPD_" to the flags, for UPDate_screen().
|
| |
|
|
|
|
| |
Problem: Some callers of rettv_list_alloc() check for not OK. (Christ van
Willegen)
Solution: Use "==" instead of "!=" when checking the return value.
|
| |
|
|
|
| |
Problem: The channel log only contains some of the raw terminal output.
Solution: Add the "o" flag to log all terminal output. Use it for "--log".
|
| |
|
|
|
| |
Problem: Various white space and cosmetic mistakes.
Solution: Change spaces to tabs, improve comments.
|
| |
|
|
|
| |
Problem: MODE_ enum entries names are too generic.
Solution: use CH_MODE_.
|
| |
|
|
|
| |
Problem: Possible endless loop if there is unused typahead.
Solution: Only loop when the typeahead changed.
|
| |
|
|
|
|
| |
Problem: Large payload for LSP message not tested.
Solution: Add a test with a large LSP payload. (Yegappan Lakshmanan,
closes #10223)
|
| |
|
|
|
|
| |
Problem: Parsing an LSP message fails when it is split.
Solution: Collapse the received data before parsing. (Yegappan Lakshmanan,
closes #10215)
|
| |
|
|
|
| |
Problem: Coverity warns for not checking return value.
Solution: Check return value of rettv_dict_alloc().
|
| |
|
|
|
|
| |
Problem: When using an LSP channel want to get the message ID.
Solution: Have ch_sendexpr() return the ID. (Yegappan Lakshmanan,
closes #10202)
|
| |
|
|
|
| |
Problem: Error from setting an option is silently ignored.
Solution: Handle option value errors better. Fix uses of N_().
|
| |
|
|
|
|
|
| |
Problem: There is no way to start logging very early in startup.
Solution: Add the --log argument. Include the date in the start message in
the log file. Avoid a duplicate message when forking. Log an
executed shell command.
|
| |
|
|
|
|
| |
Problem: Hard to reproduce hang when reading from a channel.
Solution: Check for readahead before starting to wait. (closes #10093,
closes #7781, closes #6364)
|
| |
|
|
|
| |
Problem: Cannot open a channel on a Unix domain socket.
Solution: Add Unix domain socket support. (closes #10062)
|
| |
|
|
|
| |
Problem: Verbose check with dict_find() to see if a key is present.
Solution: Add dict_has_key(). (Yegappan Lakshmanan, closes #10074)
|
| |
|
|
|
|
| |
Problem: Handling LSP messages is a bit slow.
Solution: Included support for LSP messages. (Yegappan Lakshmanan,
closes #10025)
|
| |
|
|
|
| |
Problem: Some type casts are redundant.
Solution: Remove the type casts. (closes #9643)
|
| |
|
|
|
| |
Problem: Using int for second argument of ga_init2().
Solution: Remove unnessary type cast (int) when using sizeof().
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move the last error messages to errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move more errors to errors.h.
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move more errors to errors.h.
|
| |
|
|
|
|
|
| |
Problem: When editing the command line a FocusLost callback may cause the
screen to scroll up.
Solution: Do not redraw at the last line but at the same place where the
command line was before. (closes #9295)
|
| |
|
|
|
| |
Problem: Error messages are everywhere.
Solution: Move more error messages to errors.h and adjust the names.
|
| |
|
|
|
| |
Problem: Freeze when calling term_wait() in a close callback.
Solution: Set a "closing" flag to tell term_wait() to return. (closes #9152)
|
| |
|
|
|
|
| |
Problem: Vim9: Not all function argument types are properly checked.
Solution: Add and improve argument type checks. (Yegappan Lakshmanan,
closes #8839)
|
| |
|
|
|
|
| |
Problem: Some local functions are not static.
Solution: Add "static". Move snprintf() related code to strings.c.
(Yegappan Lakshmanan, closes #8734)
|
| |
|
|
|
| |
Problem: Macro for printf format check can be simplified.
Solution: Add ATTRIBUTE_FORMAT_PRINTF(). (Dominique Pellé, issue #8635)
|
| |
|
|
|
|
| |
Problem: Vim9: runtime and compile time type checks are not the same.
Solution: Add more runtime type checks for builtin functions. (Yegappan
Lakshmanan, closes #8646)
|
| |
|
|
|
|
| |
Problem: Vim9: argument types are not checked at compile time.
Solution: Add several more type checks. Fix type check for matchaddpos().
(Yegappan Lakshmanan, closes #8619)
|
| |
|
|
|
|
| |
Problem: Vim9: argument types are not checked at compile time.
Solution: Add several more type checks, also at runtime. (Yegappan
Lakshmanan, closes #8587)
|
| |
|
|
|
| |
Problem: Vim9: builtin function arguments not checked at compile time.
Solution: Add more type checks. (Yegappan Lakshmanan, closes #8539)
|
| |
|
|
|
|
| |
Problem: A channel command "echoerr" does not show anything.
Solution: Do not use silent errors when using an "echoerr" command.
(closes #8494)
|
| |
|
|
|
| |
Problem: Cannot catch errors in a channel command.
Solution: Instead of skipping the error make it silent. (closes #8477)
|
| |
|
|
|
| |
Problem: Error messages are spread out.
Solution: Move some error messages to errors.h. Use clearer names.
|
| |
|
|
|
| |
Problem: Vim9: no error when using job or channel as a string.
Solution: Be more strict about conversion to string. (closes #8312)
|
| |
|
|
|
| |
Problem: Vim9: not enough function arguments checked for string.
Solution: Check in ch_logfile(), char2nr() and others.
|
| |
|
|
|
|
| |
Problem: Cannot connect to 127.0.0.1 for host with only IPv6 addresses.
Solution: pass AI_V4MAPPED flag to getaddrinfo. (Filipe Brandenburger,
closes #6931)
|
| |
|
|
|
|
|
| |
Problem: When job writes to hidden buffer current window has display
errors. (Johnny McArthur)
Solution: Use aucmd_prepbuf() instead of switch_to_win_for_buf().
(closes #6925)
|
| |
|
|
|
| |
Problem: The channel source file is too big.
Solution: Move job related code to a new source file.
|
| |
|
|
|
| |
Problem: Cannot read back the prompt of a prompt buffer.
Solution: Add prompt_getprompt(). (Ben Jackson, closes #6851)
|
| |
|
|
|
| |
Problem: ch_logfile() is unclear about closing when forking.
Solution: Adjust the log messages.
|
| |
|
|
|
|
| |
Problem: Cannot interrupt shell used for filename expansion. (Dominique
Pellé)
Solution: Do set tmode in mch_delay(). (closes #6770)
|
| |
|
|
|
| |
Problem: Vim9: can't use v:true for option flags.
Solution: Add tv_get_bool_chk(). (closes #6725)
|
| |
|
|
|
| |
Problem: Cannot use a lambda with quickfix functions.
Solution: Add support for lambda. (Yegappan Lakshmanan, closes #6499)
|
| |
|
|
|
|
| |
Problem: Many type casts are used for vim_strnsave().
Solution: Make the length argument size_t instead of int. (Ken Takata,
closes #5633) Remove some type casts.
|
