| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |
|
|
|
|
| |
Problem: Cursor in terminal window blinks by default, while in a real xterm
it does not blink, unless the -bc argument is used.
Solution: Do not use a blinking cursor by default.
|
| |
|
|
|
| |
Problem: Coverity warning for failing to open /dev/null.
Solution: When /dev/null can't be opened exit the child.
|
| |
|
|
|
| |
Problem: Terminal noblock test fails on MS-Windows. (Christian Brabandt)
Solution: Ignore empty line below "done".
|
| |
|
|
|
| |
Problem: Writing to terminal job is not tested.
Solution: Add a test.
|
| |
|
|
|
| |
Problem: Cannot send lines to a terminal job on MS-Windows.
Solution: Set jv_in_buf. Command doesn't get EOF yet though.
|
| |
|
|
|
|
| |
Problem: Cannot send lines to a terminal job.
Solution: Make [range]terminal send selected lines to the job.
Use ++rows and ++cols for the terminal size.
|
| |
|
|
|
| |
Problem: Using freed memory when setting 'backspace'.
Solution: When changing oldval also change origval.
|
| |
|
|
|
| |
Problem: Resetting a string option does not trigger OptionSet. (Rick Howe)
Solution: Set the origval.
|
| |
|
|
|
| |
Problem: initial info about blinking cursor is wrong
Solution: Invert the blink flag. Add t_VS to stop a blinking cursor.
|
| |
|
|
|
| |
Problem: Compiler warnings for unused variables. (Tony Mechelynck)
Solution: Add #ifdefs.
|
| |
|
|
|
| |
Problem: 'winptydll' missing from :options.
Solution: Add the entry.
|
| |
|
|
|
|
|
| |
Problem: if there is no StatusLine highlighting and there is StatusLineNC
or StatusLineTermNC highlighting then an invalid highlight id is
passed to combine_stl_hlt(). (Coverity)
Solution: Check id_S to be -1 instead of zero.
|
| |
|
|
|
| |
Problem: Coverity warning for unused return value.
Solution: Add (void) to avoid the warning.
|
| |
|
|
|
| |
Problem: Crash when switching terminal modes. (Nikolai Pavlov)
Solution: Check that there are scrollback lines.
|
| |
|
|
|
| |
Problem: Using a terminal may cause the cursor to blink.
Solution: Do not set t_vs, since we cannot restore the old blink state.
|
| |
|
|
|
| |
Problem: Build failure without terminal feature.
Solution: Move #endif.
|
| |
|
|
|
|
| |
Problem: The cursor shape is not reset after it was changed in a terminal.
Solution: Request the original cursor shape and restore it. Add t_RS.
Do not add t_SH for now, it does not work properly.
|
| |
|
|
|
| |
Problem: Channel write buffer does not work with poll().
Solution: Use the same mechanism as with select().
|
| |
|
|
|
| |
Problem: Terminal test fails on MacOS. (chdiza)
Solution: Wait for the shell to echo the characters. (closes #1991)
|
| |
|
|
|
|
| |
Problem: Crash with virtualedit and joining lines. (Joshua T Corbin, Neovim
#6726)
Solution: When using a mark check that coladd is valid.
|
| |
|
|
|
| |
Problem: The script to build the installer does not include winpty.
Solution: Add winpty32.dll and winpty-agent.exe like diff.exe
|
| |
|
|
|
|
| |
Problem: Job in terminal does not get CTRL-C, we send a SIGINT instead.
Solution: Don't call may_send_sigint() on CTRL-C. Make CTRL-W CTRL-C end
the job.
|
| |
|
|
|
| |
Problem: Build failure on MS-Windows.
Solution: Use ioctlsocket() instead of fcntl().
|
| |
|
|
|
|
| |
Problem: The terminal test fails on MS-Windows when compiled with the
terminal feature but the winpty DLL is missing.
Solution: Check if the terminal feature works. (Ken Takata)
|
| |
|
|
|
|
| |
Problem: When term_sendkeys() sends many keys it may get stuck in writing
to the job.
Solution: Make the write non-blocking, buffer keys to be sent.
|
| |
|
|
|
|
| |
Problem: Scrolling in a terminal hwindow as flicker when the Normal
background differs from the terminal window background.
Solution: Set the attribute to clear with.
|
| |
|
|
|
|
| |
Problem: Test_existent_file() fails on some file systems.
Solution: Run the test again with a sleep when the test fails without a
sleep. (James McCoy, closes #1984)
|
| |
|
|
|
| |
Problem: /proc/self/exe might be a relative path.
Solution: Make the path a full path. (James McCoy, closes #1983)
|
| |
|
|
|
|
| |
Problem: Get "no write since last change" error in terminal window.
Solution: Use another message when closing a terminal window. Make ":quit!"
also end the job.
|
| |
|
|
|
| |
Problem: MS-Windows: has('terminal') does not check existence of dll file.
Solution: Check if the winpty dll file can be loaded. (Ken Takata)
|
| |
|
|
|
| |
Problem: Another wrong #ifdef.
Solution: Change TERMINAL to FEAT_TERMINAL. (closes #1981)
|
| |
|
|
|
| |
Problem: MS-Windows: wrong #ifdef, compiler warnings for signed/unsigned.
Solution: Change variable type. Change TERMINAL to FEAT_TERMINAL.
|
| |
|
|
|
|
|
| |
Problem: winpty.dll name is fixed.
Solution: Add the 'winptydll' option. Make the default name depend on
whether it is a 32-bit or 64-bit build. (idea by Yasuhiro
Matsumoto, closes #1978)
|
| |
|
|
|
|
| |
Problem: Crash if timer closes window while dragging status line.
Solution: Check if the window still exists. (Yasuhiro Matsumoto, closes
#1979)
|
| |
|
|
|
|
| |
Problem: When in Insert mode and using CTRL-O CTRL-W CTRL-W to move to a
termainal window, get in a weird Insert mode.
Solution: Don't go to Insert mode in a terminal window. (closes #1977)
|
| |
|
|
|
| |
Problem: Using PATH_MAX does not work well on some systems.
Solution: use MAXPATHL instead. (James McCoy, closes #1973)
|
| |
|
|
|
| |
Problem: 64-bit compiler warnings.
Solution: Use "size_t" instead of "int". (Mike Williams)
|
| |
|
|
|
|
| |
Problem: Test_profile is a little bit flaky.
Solution: Accept a match when self and total time are the same. (James
McCoy, closes #1972)
|
| |
|
|
|
| |
Problem: Test_terminal_scrape_multibyte fails if the codepage is not utf-8.
Solution: Start "cmd" with the utf-8 codepage. (micbou, closes #1975)
|
| |
|
|
|
|
| |
Problem: Using freed memory with ":terminal" if an autocommand changes
'shell' when splitting the window. (Marius Gedminas)
Solution: Make a copy of 'shell'. (closes #1974)
|
| |
|
|
|
|
| |
Problem: Existing color schemes don't work well with StatusLineTerm.
Solution: Don't use "reverse", use fg and bg colors. Also add
StatusLineTermNC.
|
| |
|
|
|
| |
Problem: Test_terminal_scrape_multibyte is flaky. (James McCoy)
Solution: Use WaitFor() instead of term_wait().
|
| |
|
|
|
| |
Problem: Test_terminal_env is flaky. (James McCoy)
Solution: Use WaitFor() instead of term_wait().
|
| |
|
|
|
| |
Problem: Scrolling in terminal window is inefficient.
Solution: Use win_del_lines().
|
| |
|
|
|
| |
Problem: User highlight groups are not adjusted for StatusLineTerm.
Solution: Combine attributes like for StatusLineNC.
|
| |
|
|
|
| |
Problem: Mode() returns wrong value for a terminal window.
Solution: Return 't' when typed keys go to a job.
|
| |
|
|
|
| |
Problem: Cannot recognize a terminal buffer in :ls output.
Solution: Use R for a running job and F for a finished job.
|
| |
|
|
|
| |
Problem: Change to struts.h missing in patch.
Solution: Include adding ttyinfo_T.
|
| |
|
|
|
| |
Problem: Terminal test tries to start GUI when it's not possible.
Solution: Check if the GUI can run. (James McCoy, closes #1971)
|
| |
|
|
|
| |
Problem: Terminal may not use right characters for BS and Enter.
Solution: Get the characters from the tty.
|
