| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
Problem: Coverity gets confused by the flags passed to find_tags() and
warnts for an uninitialized variable.
Solution: Disallow using cscope and help tags at the same time.
|
| |
|
|
|
|
|
| |
Problem: When a multi-byte character ends in a zero byte, putting blockwise
text puts it before the character instead of after it.
Solution: Use int instead of char for the character under the cursor.
(Luchr, closes #1403) Add a test.
|
| |
|
|
|
| |
Problem: Checking if PROTO is defined inside a function has no effect.
Solution: Remove the check for PROTO. (Hirohito Higashi)
|
| |
|
|
|
|
|
| |
Problem: Completion for :match does not show "none" and other missing
highlight names.
Solution: Skip over cleared entries before checking the index to be at the
end.
|
| |
|
|
|
|
| |
Problem: Ubsan reports errors for integer overflow.
Solution: Define macros for minimum and maximum values. Select an
expression based on the value. (Mike Williams)
|
| |
|
|
|
| |
Problem: No command line completion for :cexpr, :cgetexpr, :caddexpr, etc.
Solution: Make completion work. (Yegappan Lakshmanan) Add a test.
|
| |
|
|
|
| |
Problem: Build fails without the cscope feature.
Solution: Add #ifdef.
|
| |
|
|
|
|
| |
Problem: When decoding JSON with a JS style object the JSON test may use a
NULL pointer. (Coverity)
Solution: Check for a NULL pointer.
|
| |
|
|
|
|
| |
Problem: When a Cscope line contains CTRL-L a NULL pointer may be used.
(Coverity)
Solution: Don't check for an emacs tag in a cscope line.
|
| |
|
|
|
| |
Problem: Leaking memory when syntax cluster id is unknown. (Coverity)
Solution: Free the memory.
|
| |
|
|
|
|
| |
Problem: The Netbeans "specialKeys" command does not check if the argument
fits in the buffer. (Coverity)
Solution: Add a length check.
|
| |
|
|
|
|
|
| |
Problem: The buffer used to store a key name theoreticaly could be too
small. (Coverity)
Solution: Count all possible modifier characters. Add a check for the
length just in case.
|
| |
|
|
|
| |
Problem: Build fails if the multi-byte feature is disabled.
Solution: Change #ifdef around ins_char_bytes.
|
| |
|
|
|
|
| |
Problem: Vim does not support bracketed paste, as implemented by xterm and
other terminals.
Solution: Add t_BE, t_BD, t_PS and t_PE.
|
| |
|
|
|
|
| |
Problem: When using :substitute with the "c" flag and 'cursorbind' is set
the cursor is not updated in other windows.
Solution: Call do_check_cursorbind(). (Masanori Misono)
|
| |
|
|
|
|
|
| |
Problem: Internally used commands for CTRL-Z and mouse click end up in
history. (Matthew Malcomson)
Solution: Use do_cmdline_cmd() instead of stuffing them in the readahead
buffer. (James McCoy, closes #1395)
|
| |
|
|
|
|
| |
Problem: Leaking file descriptor when system() cannot find the buffer.
(Coverity)
Solution: Close the file descriptor. (Dominique Pelle, closes #1398)
|
| |
|
|
|
| |
Problem: Test coverage for :retab insufficient.
Solution: Add test for :retab. (Dominique Pelle, closes #1391)
|
| |
|
|
|
|
| |
Problem: After :undojoin some commands don't work properly, such as :redo.
(Matthew Malcomson)
Solution: Don't set curbuf->b_u_curhead. (closes #1390)
|
| |
|
|
|
| |
Problem: Compiler warns for uninitialized variable. (Tony Mechelynck)
Solution: When skipping set "id" to -1.
|
| |
|
|
|
|
| |
Problem: Order of complication flags is sometimes wrong.
Solution: Put interface-specific flags before ALL_CFLAGS. (idea by Yousong
Zhou, closes #1100)
|
| |
|
|
|
| |
Problem: No test for invalid syntax group name.
Solution: Add a test for group name error and warning.
|
| |
|
|
|
|
| |
Problem: When completing a group name for a highlight or syntax command
cleared groups are included.
Solution: Skip groups that have been cleared.
|
| |
|
|
|
| |
Problem: Some syntax arguments are not tested.
Solution: Add more syntax command tests.
|
| |
|
|
|
|
|
| |
Problem: Warning for an unused parameter when the libcall feature is
disabled. Warning for a function type cast when compiling with
-pedantic.
Solution: Add UNUSED. Use a different type cast. (Damien Molinier)
|
| |
|
|
|
|
|
|
| |
Problem: Some syntax arguments take effect even after "if 0". (Taylor
Venable)
Solution: Properly skip the syntax statements. Make "syn case" and "syn
conceal" report the current state. Fix that "syn clear" didn't
reset the conceal flag. Add tests for :syntax skipping properly.
|
| | |
|
| |
|
|
|
| |
Problem: On MS-Windows the system() test skips a few parts.
Solution: Swap single and double quotes for the command.
|
| |
|
|
|
|
| |
Problem: The test for :profile is slow and does not work on MS-Windows.
Solution: Use the "-es" argument. (Dominique Pelle) Swap single and double
quotes for system()
|
| |
|
|
|
|
|
| |
Problem: Jumping to a tag that is a static item in the current file fails.
(Kazunobu Kuriyama)
Solution: Make sure the first byte of the tag key is not NUL. (Suggested by
James McCoy, closes #1387)
|
| |
|
|
|
| |
Problem: Profile tests fails if total and self time are equal.
Solution: Make one time optional.
|
| |
|
|
|
| |
Problem: Accidentally removed #ifdef.
Solution: Put it back. (Masanori Misono)
|
| |
|
|
|
|
| |
Problem: Build fails with tiny features.
Solution: Change #ifdef for hash_clear(). Avoid warning for unused
argument.
|
| |
|
|
|
|
|
| |
Problem: Some systems do not have ruby_sysinit(), causing the build to
fail.
Solution: Clean up how ruby_sysinit() and NtInitialize() are used. (Taro
Muraoka)
|
| |
|
|
|
|
| |
Problem: Detecting duplicate tags uses a slow linear search.
Solution: Use a much faster hash table solution. (James McCoy, closes #1046)
But don't add hi_keylen, it makes hash tables 50% bigger.
|
| |
|
|
|
| |
Problem: There are no tests for the :profile command.
Solution: Add tests. (Dominique Pelle, closes #1383)
|
| |
|
|
|
|
| |
Problem: Using NOT_VALID for redraw_later() to update the cursor
line/column highlighting is not efficient.
Solution: Call validate_cursor() when 'cul' or 'cuc' is set.
|
| |
|
|
|
|
| |
Problem: Building with a new Ruby version fails.
Solution: Use ruby_sysinit() instead of NtInitialize(). (Tomas Volf,
closes #1382)
|
| |
|
|
|
| |
Problem: The error message from assert_notequal() is confusing.
Solution: Only mention the expected value.
|
| |
|
|
|
| |
Problem: The system() test fails on MS-Windows.
Solution: Skip the test on MS-Windows.
|
| |
|
|
|
|
|
| |
Problem: When in Ex mode and an error is caught by try-catch, Vim still
exits with a non-zero exit code.
Solution: Don't set ex_exitval when inside a try-catch. (partly by Christian
Brabandt)
|
| |
|
|
|
| |
Problem: Ubsan warns for using a pointer that is not aligned.
Solution: First copy the address. (Yegappan Lakshmanan)
|
| |
|
|
|
|
|
| |
Problem: When 'cursorbind' and 'cursorline' are set, but 'cursorcolumn' is
not, then the cursor line highlighting is not updated. (Hirohito
Higashi)
Solution: Call redraw_later() with NOT_VALID.
|
| |
|
|
|
|
| |
Problem: When 'cursorbind' and 'cursorcolumn' are both on, the column
highlignt in non-current windows is wrong.
Solution: Add validate_cursor(). (Masanori Misono, closes #1372)
|
| |
|
|
|
|
| |
Problem: Error E937 is used both for duplicate key in JSON and for trying
to delete a buffer that is in use.
Solution: Rename the JSON error to E938. (Norio Takagi, closes #1376)
|
| |
|
|
|
|
| |
Problem: 'formatprg' is a global option but the value may depend on the
type of buffer. (Sung Pae)
Solution: Make 'formatprg' global-local. (closes #1380)
|
| |
|
|
|
|
| |
Problem: test_command_count may fail when a previous test interferes, seen
on MS-Windows.
Solution: Run it separately.
|
| |
|
|
|
|
|
|
| |
Problem: When opening a buffer on a directory and inside a try/catch then
the BufEnter event is not triggered.
Solution: Return NOTDONE from readfile() for a directory and deal with the
three possible return values. (Justin M. Keyes, closes #1375,
closes #1353)
|
| |
|
|
|
| |
Problem: Using :change in between :function and :endfunction fails.
Solution: Recognize :change inside a function. (ichizok, closes #1374)
|
| |
|
|
|
|
| |
Problem: Setting language in gvim on MS-Windows does not work when
libintl.dll is dynamically linked with msvcrt.dll.
Solution: Use putenv() from libintl as well. (Ken Takata, closes #1082)
|
