diff options
| author | Bram Moolenaar <Bram@vim.org> | 2022-12-25 19:31:36 +0000 |
|---|---|---|
| committer | Bram Moolenaar <Bram@vim.org> | 2022-12-25 19:31:36 +0000 |
| commit | 6ef5471afa69a654888bc285a51a6035405d33a0 (patch) | |
| tree | 129d598f76891f27518586ab04edbd0cbc3b1884 | |
| parent | 9b99411b93f017609399e04527fdd3b6e83b5a55 (diff) | |
| download | vim-git-6ef5471afa69a654888bc285a51a6035405d33a0.tar.gz | |
patch 9.0.1095: using freed memory when declaration failsv9.0.1095
Problem: Using freed memory when declaration fails. (Yegappan Lakshmanan)
Solution: After unreferencing an object set the reference to NULL.
| -rw-r--r-- | src/testdir/test_vim9_class.vim | 16 | ||||
| -rw-r--r-- | src/typval.c | 2 | ||||
| -rw-r--r-- | src/version.c | 2 |
3 files changed, 20 insertions, 0 deletions
diff --git a/src/testdir/test_vim9_class.vim b/src/testdir/test_vim9_class.vim index c73e80fb6..7e4c92dda 100644 --- a/src/testdir/test_vim9_class.vim +++ b/src/testdir/test_vim9_class.vim @@ -349,6 +349,22 @@ def Test_class_object_member_access() assert_equal('make = 123', c2.GetMake()) END v9.CheckScriptSuccess(lines) + + lines =<< trim END + vim9script + + class MyCar + this.make: string + + def new(make_arg: string) + this.make = make_arg + enddef + endclass + + var c = MyCar.new("abc") + var c = MyCar.new("def") + END + v9.CheckScriptFailure(lines, 'E1041:') enddef def Test_class_member_access() diff --git a/src/typval.c b/src/typval.c index 98915ccca..6eae02b78 100644 --- a/src/typval.c +++ b/src/typval.c @@ -162,9 +162,11 @@ clear_tv(typval_T *varp) break; case VAR_CLASS: class_unref(varp->vval.v_class); + varp->vval.v_class = NULL; break; case VAR_OBJECT: object_unref(varp->vval.v_object); + varp->vval.v_object = NULL; break; case VAR_UNKNOWN: case VAR_ANY: diff --git a/src/version.c b/src/version.c index 95d2a6b6a..36d3f81ff 100644 --- a/src/version.c +++ b/src/version.c @@ -696,6 +696,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1095, +/**/ 1094, /**/ 1093, |