diff options
| author | Bram Moolenaar <Bram@vim.org> | 2021-12-05 12:06:24 +0000 |
|---|---|---|
| committer | Bram Moolenaar <Bram@vim.org> | 2021-12-05 12:06:24 +0000 |
| commit | e031fe90cf2e375ce861ff5e5e281e4ad229ebb9 (patch) | |
| tree | 8723b11cb324f35a8959b759ad94c106e3f62dad | |
| parent | c7269f862748c3b0f56b5a651019e18c7d5190ee (diff) | |
| download | vim-git-e031fe90cf2e375ce861ff5e5e281e4ad229ebb9.tar.gz | |
patch 8.2.3741: using freed memory in open commandv8.2.3741
Problem: Using freed memory in open command.
Solution: Make a copy of the current line.
| -rw-r--r-- | src/ex_docmd.c | 10 | ||||
| -rw-r--r-- | src/testdir/test_ex_mode.vim | 13 | ||||
| -rw-r--r-- | src/version.c | 2 |
3 files changed, 22 insertions, 3 deletions
diff --git a/src/ex_docmd.c b/src/ex_docmd.c index 439a78ced..1fc538b85 100644 --- a/src/ex_docmd.c +++ b/src/ex_docmd.c @@ -6877,13 +6877,17 @@ ex_open(exarg_T *eap) regmatch.regprog = vim_regcomp(eap->arg, magic_isset() ? RE_MAGIC : 0); if (regmatch.regprog != NULL) { + // make a copy of the line, when searching for a mark it might be + // flushed + char_u *line = vim_strsave(ml_get_curline()); + regmatch.rm_ic = p_ic; - p = ml_get_curline(); - if (vim_regexec(®match, p, (colnr_T)0)) - curwin->w_cursor.col = (colnr_T)(regmatch.startp[0] - p); + if (vim_regexec(®match, line, (colnr_T)0)) + curwin->w_cursor.col = (colnr_T)(regmatch.startp[0] - line); else emsg(_(e_nomatch)); vim_regfree(regmatch.regprog); + vim_free(line); } // Move to the NUL, ignore any other arguments. eap->arg += STRLEN(eap->arg); diff --git a/src/testdir/test_ex_mode.vim b/src/testdir/test_ex_mode.vim index 1ca506232..7031115fc 100644 --- a/src/testdir/test_ex_mode.vim +++ b/src/testdir/test_ex_mode.vim @@ -121,6 +121,19 @@ func Test_open_command() close! endfunc +func Test_open_command_flush_line() + " this was accessing freed memory: the regexp match uses a pointer to the + " current line which becomes invalid when searching for the ') mark. + new + call setline(1, ['one', 'two. three']) + s/one/ONE + try + open /\%')/ + catch /E479/ + endtry + bwipe! +endfunc + " Test for :g/pat/visual to run vi commands in Ex mode " This used to hang Vim before 8.2.0274. func Test_Ex_global() diff --git a/src/version.c b/src/version.c index 6e1e30aa9..83326fef6 100644 --- a/src/version.c +++ b/src/version.c @@ -754,6 +754,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 3741, +/**/ 3740, /**/ 3739, |