diff options
author | Bram Moolenaar <Bram@vim.org> | 2021-11-25 13:04:48 +0000 |
---|---|---|
committer | Bram Moolenaar <Bram@vim.org> | 2021-11-25 13:04:48 +0000 |
commit | 34c20ff85b87be587ea5d0398812441b502ee6a5 (patch) | |
tree | 6e4c613ac850ce65d15e3ad306694474fb4fb824 | |
parent | 8af87bd6b1808ffcafdd73b1d7501dd50b9d15bc (diff) | |
download | vim-git-34c20ff85b87be587ea5d0398812441b502ee6a5.tar.gz |
patch 8.2.3671: restarting Insert mode in prompt buffer too oftenv8.2.3671
Problem: Restarting Insert mode in prompt buffer too often when a callback
switches windows and comes back. (Sean Dewar)
Solution: Do not set "restart_edit" when already in Insert mode.
-rw-r--r-- | src/testdir/test_prompt_buffer.vim | 25 | ||||
-rw-r--r-- | src/version.c | 2 | ||||
-rw-r--r-- | src/window.c | 5 |
3 files changed, 30 insertions, 2 deletions
diff --git a/src/testdir/test_prompt_buffer.vim b/src/testdir/test_prompt_buffer.vim index 32ed21e64..8918bd47f 100644 --- a/src/testdir/test_prompt_buffer.vim +++ b/src/testdir/test_prompt_buffer.vim @@ -39,6 +39,10 @@ func WriteScript(name) \ ' set nomodified', \ 'endfunc', \ '', + \ 'func SwitchWindows()', + \ ' call timer_start(0, {-> execute("wincmd p|wincmd p", "")})', + \ 'endfunc', + \ '', \ 'call setline(1, "other buffer")', \ 'set nomodified', \ 'new', @@ -99,6 +103,27 @@ func Test_prompt_editing() call delete(scriptName) endfunc +func Test_prompt_switch_windows() + call CanTestPromptBuffer() + let scriptName = 'XpromptSwitchWindows' + call WriteScript(scriptName) + + let buf = RunVimInTerminal('-S ' . scriptName, {'rows': 12}) + call WaitForAssert({-> assert_equal('cmd:', term_getline(buf, 1))}) + call WaitForAssert({-> assert_match('-- INSERT --', term_getline(buf, 12))}) + + call term_sendkeys(buf, "\<C-O>:call SwitchWindows()\<CR>") + call term_wait(buf, 50) + call WaitForAssert({-> assert_match('-- INSERT --', term_getline(buf, 12))}) + + call term_sendkeys(buf, "\<Esc>") + call term_wait(buf, 50) + call WaitForAssert({-> assert_match('^ *$', term_getline(buf, 12))}) + + call StopVimInTerminal(buf) + call delete(scriptName) +endfunc + func Test_prompt_garbage_collect() func MyPromptCallback(x, text) " NOP diff --git a/src/version.c b/src/version.c index 19188904d..0686cfab9 100644 --- a/src/version.c +++ b/src/version.c @@ -758,6 +758,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 3671, +/**/ 3670, /**/ 3669, diff --git a/src/window.c b/src/window.c index d28962a30..4fbf94428 100644 --- a/src/window.c +++ b/src/window.c @@ -2268,8 +2268,9 @@ entering_window(win_T *win) stop_insert_mode = FALSE; // When entering the prompt window restart Insert mode if we were in Insert - // mode when we left it. - restart_edit = win->w_buffer->b_prompt_insert; + // mode when we left it and not already in Insert mode. + if ((State & INSERT) == 0) + restart_edit = win->w_buffer->b_prompt_insert; } #endif |