summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBram Moolenaar <Bram@vim.org>2020-01-28 22:46:22 +0100
committerBram Moolenaar <Bram@vim.org>2020-01-28 22:46:22 +0100
commit58ceca5cae75ed839b20a89c5fa9998f02552f58 (patch)
tree4b567ea57901fcb1fe3bf95c5332dc049f02fdbc
parent07da94b0f07beb15c7e26b78837def5a91e102dc (diff)
downloadvim-git-58ceca5cae75ed839b20a89c5fa9998f02552f58.tar.gz
patch 8.2.0167: Coverity warning for ignoring return valuev8.2.0167
Problem: Coverity warning for ignoring return value. Solution: Check the return value and jump if failed.
-rw-r--r--src/testdir/test_vim9_expr.vim2
-rw-r--r--src/version.c2
-rw-r--r--src/vim9execute.c3
3 files changed, 6 insertions, 1 deletions
diff --git a/src/testdir/test_vim9_expr.vim b/src/testdir/test_vim9_expr.vim
index ea79c0457..321dbf95a 100644
--- a/src/testdir/test_vim9_expr.vim
+++ b/src/testdir/test_vim9_expr.vim
@@ -687,6 +687,8 @@ func Test_expr7_fails()
call CheckDefFailure("let x = @", "E1002:")
call CheckDefFailure("let x = @<", "E354:")
+
+ call CheckDefFailure("let x = &notexist", "E113:")
endfunc
let g:Funcrefs = [function('add')]
diff --git a/src/version.c b/src/version.c
index d5108d978..c6259bc9f 100644
--- a/src/version.c
+++ b/src/version.c
@@ -743,6 +743,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
+ 167,
+/**/
166,
/**/
165,
diff --git a/src/vim9execute.c b/src/vim9execute.c
index 001d27411..6865ba1e2 100644
--- a/src/vim9execute.c
+++ b/src/vim9execute.c
@@ -556,7 +556,8 @@ call_def_function(
if (ga_grow(&ectx.ec_stack, 1) == FAIL)
goto failed;
- get_option_tv(&name, &optval, TRUE);
+ if (get_option_tv(&name, &optval, TRUE) == FAIL)
+ goto failed;
*STACK_TV_BOT(0) = optval;
++ectx.ec_stack.ga_len;
}