diff options
author | Bram Moolenaar <Bram@vim.org> | 2018-05-19 14:43:45 +0200 |
---|---|---|
committer | Bram Moolenaar <Bram@vim.org> | 2018-05-19 14:43:45 +0200 |
commit | 2abad54cede7c33f090fbde19a9a3eb3dbf78e53 (patch) | |
tree | 3565ce351f918ea2e6dfaeca5e09155a2b20fd1d | |
parent | 2f01889055f14842c1d4f9abd91139fc6bd95f15 (diff) | |
download | vim-git-2abad54cede7c33f090fbde19a9a3eb3dbf78e53.tar.gz |
patch 8.1.0002: :stopinsert changes the message positionv8.1.0002
Problem: :stopinsert changes the message position.
Solution: Save and restore msg_col and msg_row in clearmode(). (Jason
Franklin)
-rw-r--r-- | src/screen.c | 6 | ||||
-rw-r--r-- | src/testdir/test_messages.vim | 21 | ||||
-rw-r--r-- | src/version.c | 2 |
3 files changed, 29 insertions, 0 deletions
diff --git a/src/screen.c b/src/screen.c index 841dc1866..e26bb44ee 100644 --- a/src/screen.c +++ b/src/screen.c @@ -10485,10 +10485,16 @@ unshowmode(int force) void clearmode(void) { + int save_msg_row = msg_row; + int save_msg_col = msg_col; + msg_pos_mode(); if (Recording) recording_mode(HL_ATTR(HLF_CM)); msg_clr_eos(); + + msg_col = save_msg_col; + msg_row = save_msg_row; } static void diff --git a/src/testdir/test_messages.vim b/src/testdir/test_messages.vim index 188406e44..384d2aa94 100644 --- a/src/testdir/test_messages.vim +++ b/src/testdir/test_messages.vim @@ -38,3 +38,24 @@ function Test_messages() let &more = oldmore endtry endfunction + +" Patch 7.4.1696 defined the "clearmode()" command for clearing the mode +" indicator (e.g., "-- INSERT --") when ":stopinsert" is invoked. Message +" output could then be disturbed when 'cmdheight' was greater than one. +" This test ensures that the bugfix for this issue remains in place. +function! Test_stopinsert_does_not_break_message_output() + set cmdheight=2 + redraw! + + stopinsert | echo 'test echo' + call assert_equal(116, screenchar(&lines - 1, 1)) + call assert_equal(32, screenchar(&lines, 1)) + redraw! + + stopinsert | echomsg 'test echomsg' + call assert_equal(116, screenchar(&lines - 1, 1)) + call assert_equal(32, screenchar(&lines, 1)) + redraw! + + set cmdheight& +endfunction diff --git a/src/version.c b/src/version.c index 04d8fb332..9d92ef8cd 100644 --- a/src/version.c +++ b/src/version.c @@ -762,6 +762,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 2, +/**/ 1, /**/ 0 |