summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRico Tzschichholz <ricotz@ubuntu.com>2018-02-18 23:02:23 +0100
committerRico Tzschichholz <ricotz@ubuntu.com>2018-02-19 09:54:01 +0100
commit3b2e2d5a0847b903c7a4b73a41bba49acd5de8da (patch)
tree4a2367814ebef4048f4495c005d7875556e9c60c
parentdff67ff218644f5d99ae7709046609dacf30f263 (diff)
downloadvala-3b2e2d5a0847b903c7a4b73a41bba49acd5de8da.tar.gz
vala: Make SemanticAnalyzer.check_arguments() independent of context
-rw-r--r--vala/valamethodcall.vala4
-rw-r--r--vala/valaobjectcreationexpression.vala4
-rw-r--r--vala/valasemanticanalyzer.vala4
3 files changed, 8 insertions, 4 deletions
diff --git a/vala/valamethodcall.vala b/vala/valamethodcall.vala
index 76f240382..415191ab6 100644
--- a/vala/valamethodcall.vala
+++ b/vala/valamethodcall.vala
@@ -371,6 +371,10 @@ public class Vala.MethodCall : Expression {
var args = get_argument_list ();
Iterator<Expression> arg_it = args.iterator ();
foreach (Parameter param in params) {
+ if (!param.check (context)) {
+ error = true;
+ }
+
if (param.ellipsis) {
break;
}
diff --git a/vala/valaobjectcreationexpression.vala b/vala/valaobjectcreationexpression.vala
index e203a1a2b..7a2d6fbf8 100644
--- a/vala/valaobjectcreationexpression.vala
+++ b/vala/valaobjectcreationexpression.vala
@@ -367,6 +367,10 @@ public class Vala.ObjectCreationExpression : Expression {
var args = get_argument_list ();
Iterator<Expression> arg_it = args.iterator ();
foreach (Parameter param in m.get_parameters ()) {
+ if (!param.check (context)) {
+ error = true;
+ }
+
if (param.ellipsis) {
break;
}
diff --git a/vala/valasemanticanalyzer.vala b/vala/valasemanticanalyzer.vala
index a0535ad42..ddf6f2859 100644
--- a/vala/valasemanticanalyzer.vala
+++ b/vala/valasemanticanalyzer.vala
@@ -408,10 +408,6 @@ public class Vala.SemanticAnalyzer : CodeVisitor {
bool ellipsis = false;
int i = 0;
foreach (Parameter param in params) {
- if (!param.check (context)) {
- return false;
- }
-
if (param.ellipsis) {
ellipsis = true;
break;