summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRico Tzschichholz <ricotz@ubuntu.com>2018-02-13 10:37:03 +0100
committerRico Tzschichholz <ricotz@ubuntu.com>2018-02-13 10:37:03 +0100
commitf15f9f8485b9591493a449aa2a28ded440e07f48 (patch)
treeaa2348282deed585c61e3edd67a5206531d681f2
parentc687bacb4cd881f198a7bfcebb214fce18ba0464 (diff)
downloadvala-f15f9f8485b9591493a449aa2a28ded440e07f48.tar.gz
Don't warn about unused internal methods which are meant to be visible on DBus
https://bugzilla.gnome.org/show_bug.cgi?id=593902
-rw-r--r--vala/valaflowanalyzer.vala3
1 files changed, 3 insertions, 0 deletions
diff --git a/vala/valaflowanalyzer.vala b/vala/valaflowanalyzer.vala
index 122e58d7f..853eae73d 100644
--- a/vala/valaflowanalyzer.vala
+++ b/vala/valaflowanalyzer.vala
@@ -170,6 +170,9 @@ public class Vala.FlowAnalyzer : CodeVisitor {
&& !(m is CreationMethod)) {
if (!m.is_private_symbol () && (context.internal_header_filename != null || context.use_fast_vapi)) {
// do not warn if internal member may be used outside this compilation unit
+ } else if (m.parent_symbol != null && m.parent_symbol.get_attribute ("DBus") != null
+ && m.get_attribute_bool ("DBus", "visible", true)) {
+ // do not warn if internal member is a visible DBus method
} else {
Report.warning (m.source_reference, "method `%s' never used".printf (m.get_full_name ()));
}