summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* build-sys: release++ (v2.26.1)v2.26.1Karel Zak2015-03-132-1/+5
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* docs: update v2.26.1-ReleaseNotesKarel Zak2015-03-131-0/+68
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* docs: update AUTHORS fileKarel Zak2015-03-131-1/+4
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* po: merge changesKarel Zak2015-03-1327-12350/+13855
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* logger: use xstrdup()Karel Zak2015-03-131-4/+4
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* tests: fix fdisk/bsd for ppc64leRuediger Meier2015-03-131-2/+2
| | | | | | | | | | | | Actually Aurelien's patch a80886e9 should have addressed this already because it's the case LE, BSD_LABELSECTOR = 0, BSD_LABELOFFSET = 64. I've asked about this on mailing list but couldn't get more informations. Thread "test fdisk/bsd on exotic archs": http://comments.gmane.org/gmane.linux.utilities.util-linux-ng/10621 Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
* tests: improve readability for fdisk/bsdRuediger Meier2015-03-131-6/+10
| | | | Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
* last: fix utmplist usageKarel Zak2015-03-131-16/+21
| | | | | | | | | | | | | last(1) uses a global list of entries, this is unnecessary and it's also mistake because the pointer to the list is not set to NULL when last(1) opens another utmp file. For example: last -f /var/log/wtmp -f /var/log/wtmp-20150220 ends with unexpected free() call or sometimes with never ending loop. Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1201033 Signed-off-by: Karel Zak <kzak@redhat.com>
* cal: care about setuprterm() resultKarel Zak2015-03-121-21/+38
| | | | | References: https://bugzilla.suse.com/show_bug.cgi?id=903440 Signed-off-by: Karel Zak <kzak@redhat.com>
* libmount: mark overlay as pseudo-FSKarel Zak2015-03-121-0/+1
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* libmount: add mnt_table_get_fs_root() to header fileKarel Zak2015-03-121-0/+4
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* tests: update sfdisk --dump testKarel Zak2015-03-121-0/+2
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* logger: small change in usage()Karel Zak2015-03-121-1/+1
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* logger man page: fix typoRainer Gerhards2015-03-121-1/+1
|
* logger: add --msgid option, permits to set RFC5424 MSGID fieldRainer Gerhards2015-03-122-4/+19
|
* logger: fix multiple format bugs in rfc5424 formatterRainer Gerhards2015-03-121-21/+57
| | | | | | This is more or less a complete rewrite of the formatter. It had multiple issue, e.g. a missing field (MSGID?) and invalid handling of nil values.
* silence compiler warningRainer Gerhards2015-03-121-1/+2
| | | | | This is primarily cosmetic, albeit it also provides an only very slight improvement in compile time error checking.
* libmount: cleanup fs root detection codeKarel Zak2015-03-127-60/+26
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* findmnt: don't rely on st_dev for --targetKarel Zak2015-03-123-10/+20
| | | | | | | | | | | | The overlay filesystem does not provide usable st_dev (in traditional UNIX way). It's necessary to search in /proc/self/mountinfo to detect which path element is mountpoint. $ findmnt --target /mnt/merged/dir-a/foo TARGET SOURCE FSTYPE OPTIONS /mnt/merged overlay overlay rw,relatime,lowerdir=/mnt/low,upperdir=/mnt/high/data,workdir=/mnt/high/work Signed-off-by: Karel Zak <kzak@redhat.com>
* logger: check for ntp_gettime() rather than for timex.hKarel Zak2015-03-122-4/+4
| | | | | | | | It seems that musl libc and uClibc without UCLIBC_NTP_LEGACY does not provide ntp_gettime and compile will fail. References: https://github.com/karelzak/util-linux/issues/174 Signed-off-by: Karel Zak <kzak@redhat.com>
* logger: add --skip-empty to prevent logging empty linesRainer Gerhards2015-03-123-4/+20
| | | | | | | | | | | Empty log messages are generally considered useless. This option enables to turn them off when processing files (including stdin). [kzak@redhat.com: - rename --skip-empty-lines to --skip-empty, - add the option to getopt_long(), - add the option to bash-completion] Signed-off-by: Karel Zak <kzak@redhat.com>
* logger man page: update --size docRainer Gerhards2015-03-121-4/+7
| | | | | | now we have strict sizes Signed-off-by: Karel Zak <kzak@redhat.com>
* logger: bugfix: missing sanity checks with --prio-prefix optionRainer Gerhards2015-03-121-37/+48
| | | | | | | | | | | | | | | | | | | | | | | | There were no apparent sanity checks other than applying the logmask when reading PRI values from files. As such, invalid PRIs (tested with values 192, 210, and 2100) are accepted. This in turn can trigger problems in various receivers, especially older versions. See here for details: http://www.rsyslog.com/remote-syslog-pri-vulnerability-cve-2014-3683/ Note that 2100 was changed to 52 as described in above link. This patch refactors PRI processing. Invalid PRIs are detected and in this case the message is sent with the default priority, with the invalid pri being part of the message to be sent. This is along the line of what 2.26 did when it detected the PRI was invalid. The refactoring now also enables pricese tracking of syslog header length in all cases, so --size is now strictly obeyed. [kzak@redhat.com: - fix compiler warning [-Wunused-variable]] Signed-off-by: Karel Zak <kzak@redhat.com>
* logger: refactor message generationRainer Gerhards2015-03-121-44/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the message format was generated in one big step. Now this is refactored to generate the header independently. This not only provides a better isolation of functionality, but enables to calculate the size of the header *before* generating the user part of the message. That in turn is needed in order to precisely enforce the message size limit. This is especially important while processing files, as here parts of the message may be lost if the receiver truncates the message. The file reader itself tries to guard against this by reading only the permitted number of bytes, but without knowing the header size, it would mis-guess here. Note that when --prio-prefix is given, we still do not know exactly the header length, because the PRI value is between 1 and 3 bytes. Unfortunately, we do not know the actual size before reading. With the current (simple) approach, we need to read the full line before getting the PRI, so this is a hen-egg problem. To solve this, a more complex reader would be required. It is questionable if this is necessary for a tool like logger. So currently, we still have a 2-byte window of uncertainty if --prio-prefix is given. [kzak@redhat.com: - fix compiler warnings [-Wunused-but-set-variable]] Signed-off-by: Karel Zak <kzak@redhat.com>
* logger: permit to send messages larger than 1024 charactersRainer Gerhards2015-03-123-8/+32
| | | | | | | | | | | | | | | | | | This is an important capability that has been specified in RFC5424. However, messages larger than 1024 chars are being accepted for years now by at least rsyslog and syslog-ng. This patch adds the option --size to permit setting a new max size, with 1024 being the default. Note that the size limit is only approximative, as we do not take the header size in account (RFC talks about total message length). [[kzak@redhat.com: - add 'S' to getopt_long(), - rename --message-size to --size - add the option to bash-completion] Signed-off-by: Karel Zak <kzak@redhat.com>
* agetty: reload issue on --autologin --login-pause tooKarel Zak2015-03-121-79/+92
| | | | | | | | The current "agetty --reload" implementation does not refresh issue file output on autologin. Let's support this use-case too. Reported-by: Sitsofe Wheeler <sitsofe@gmail.com> Signed-off-by: Karel Zak <kzak@redhat.com>
* agetty: make sure that reload file existsKarel Zak2015-03-121-5/+16
| | | | | | | | | | agetty monitors /run/agetty.reload file, unfortunately if the file does not exist when agetty starts up then "agetty" --reload does not work. This patch forces agetty to create the file before inotify is enabled. Reported-by: Sitsofe Wheeler <sitsofe@gmail.com> Signed-off-by: Karel Zak <kzak@redhat.com>
* logger man page: bump man page date to currentRainer Gerhards2015-03-121-1/+1
|
* logger man page: fix some "syslog(3) routine" remnantsRainer Gerhards2015-03-121-2/+2
|
* logger: use username as the default tagKarel Zak2015-03-121-1/+1
| | | | | Reported-by: Rainer Gerhards <rgerhards@adiscon.com> Signed-off-by: Karel Zak <kzak@redhat.com>
* logger: bugfix: tcp syslog framing is broken, -T unusableRainer Gerhards2015-03-121-0/+15
| | | | | | | | | | | | | | | | | Logger can send via plain tcp syslog if -n -T options are given. However, the framing is broken so that a syslog receiver can not know where the first message ends and the next one starts. It actually looks like no framing at all is used. Plain TCP syslog framing is described in RFC6587. This patch adds RFC6587 octet-stuffed framing to TCP syslog. For local logging, this is always fine, for remote logging this is NOT recommended by the IETF (the RFC is historic). However, a full blown RFC5425 TLS sender seems to be out of scope for a tool like logger IMO. This patch also refactors the way output is written, seperating the message format generators from the output writer.
* logger: refactor the way output is writtenRainer Gerhards2015-03-121-13/+12
| | | | | | Previously, output was written in exactly the same way in three different places. This is now combined into a single function. This hopefully makes it easier to adapt to changing output needs.
* logger: remove "interface to syslog(3)" from man pageKarel Zak2015-03-121-5/+1
| | | | | | | since v2.26 logger does not use syslog(3) anymore Reported-by: Rainer Gerhards <rgerhards@adiscon.com> Signed-off-by: Karel Zak <kzak@redhat.com>
* logger: fix whitespace and compiler warning [-Wunused-variable]Karel Zak2015-03-121-2/+1
| | | | | | | misc-utils/logger.c: In function ‘syslog_rfc3164’: misc-utils/logger.c:336:9: warning: unused variable ‘now’ [-Wunused-variable] Signed-off-by: Karel Zak <kzak@redhat.com>
* logger: add commentKarel Zak2015-03-121-1/+1
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* logger: fix -p kern.* priority is accepted regressionRainer Gerhards2015-03-121-0/+2
| | | | | Pre 2.26, syslog(3) was used for local logging, and it did not accept kern.* priorities. This is re-enabled by the patch.
* logger: messages are logged with kern.* priority by defaultRainer Gerhards2015-03-121-1/+1
| | | | | | | | | | | The default should be user.notice and kern.* should never be used (syslog(3) forbids this). This is a severe regression, as messages are now logged to the wrong bin or not at all. So they get lost and may confuse readers of the kernel bin. regression from 2.25.2 to 2.26
* logger: fix invalid timestamp regression in local formatRainer Gerhards2015-03-121-13/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since 1d57503378bdcd838365d625f6d2d0a09da9c29d logger no longer uses the syslog(3) call. The way the local timestamp is generated did not match the syslog(3) format. Most importantly, the month name is formatted based on the user's local. For example: $ ./logger --stderr test with logger 2.26.39-eb651-dirty <5>Mär 5 14:17:47 logger: test with logger 2.26.39-eb651-dirty "Mär" like in German "März" for "March". previously: $ logger --stderr test with logger 2.25.2 rger: test with logger 2.25.2 In the system log file, this results to the following: Mar 5 14:17:47 host Mär 5 14:17:47 logger: test with logger 2.26.39-eb651-dirty Mar 5 14:18:01 host rger: test with logger 2.25.2 This local naming is invalid as of RFC3164. One may argue that the local log socket traditionally does not have RFC3164 format, but the timestamp always was as defined in RFC3164 (and along the lines of the ctime() call). Anything else would also be impractical, as a syslog parser would otherwise need to know about all potential locale-specific representations of month names. This patch corrects the problem and also refactors the timestamp handling a bit. The same timestamp is needed in local and rfc3164 processing, so there now is a new function to create that stamp.
* logger: fix inconsistent format regression when logging locallyRainer Gerhards2015-03-121-8/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The message format when writing to local sockets is inconsistent. Example: $ ./logger --stderr test <5>Mär 4 11:03:30 logger: test $ ./logger -u /dev/log --stderr test <5>1 2015-03-04T11:03:31.699841+0100 ubuntu1404esp rger - [timeQuality tzKnown="1" isSynced="1" syncAccuracy="29000"] test The regression was introduced with 4de2e8a03859aaab2c25dc98f33409cd28de6acc As far as the commit comments and man page indicates, this was meant to affect remote system logging only, but it also affects local logging when the -u option is given. This causes problems with receivers who do not expect full-blown RFC format on the log socket, like rsyslog. In consequence, this can also affect log analysis programs and invalidate some of their results. The patch corrects the behaviour so that the same old-style format is used for any type of local logging. New-style can always be selected by command line-options. RFC5424 is still the default for remote logging, as intended in the orignal commit. Result with the patch: $ ./logger --stderr test <5>Mär 4 11:15:35 logger: test $ ./logger -u /dev/log --stderr test <5>Mär 4 11:15:40 logger: test $ ./logger -u /dev/log --rfc5424 --stderr test <5>1 2015-03-04T11:21:28.796170+0100 ubuntu1404esp rger - [timeQuality tzKnown="1" isSynced="1" syncAccuracy="27500"] test
* agetty: support /usr/lib/os-release tooKarel Zak2015-03-123-7/+13
| | | | | | | | | | | | http://www.freedesktop.org/software/systemd/man/os-release.html The file /etc/os-release takes precedence over /usr/lib/os-release. Applications should check for the former, and exclusively use its data if it exists, and only fall back to /usr/lib/os-release if it is missing. Reported-by: Dimitri John Ledkov <dimitri.j.ledkov@intel.com> Signed-off-by: Karel Zak <kzak@redhat.com>
* logger: fix -i argument parsing regressionSami Kerola2015-03-122-5/+13
| | | | | | | | | | | | | | | | | With earlier logger it's possible to combine the option -i with other options, such as -s. But currently: $:~> logger -is logger: failed to parse id: 's' The changed behaviour breaks existing scripts like dhcpcd-run-hooks from dhcpcd. Broken-since: aab5b44405b9a6ada92e419e5a84cc0d1d4afee9 Reference: http://comments.gmane.org/gmane.linux.utilities.util-linux-ng/9683 Reported-by: Juergen Daubert <jue@jue.li> Reviewed-by: Benno Schulenberg <bensberg@justemail.net> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
* logger: fix invalid timestamp in rfc5425 formatRainer Gerhards2015-03-121-2/+6
| | | | | | | | | | | | | The timestamp is written as 2015-03-04T15:02:02.566782+0100 unfortunately, this is not an RFC3339 timestamp as demanded by rfc5424. The colon in the time offset field is missing. The correct timestamp is 2015-03-04T15:02:02.566782+01:00 (Note "+0100" vs. "+01:00")
* libfdisk: add {first,last}-lba header to sfdisk scritpsKarel Zak2015-03-122-10/+94
| | | | | | | | | | | | | | | | | | | | | | The current sfdisk does not allow to create partition that starts before the default libfdisk First LBA (~1MiB). It means that # sfdisk --dump /dev/sda > foo # sfdisk /dev/sdb < foo does not work on systems where 1st partition does not start at offset 2048. This patch add new headers to scripts to inform libfdisk about different First/Last LBA ranges. For example: label: gpt first-lba: 34 allows to override the library default. Signed-off-by: Karel Zak <kzak@redhat.com>
* docs: fstab(5) grammar / English fixes, and some other updatesPeter Cordes2015-03-121-41/+58
| | | | | | | | | | | | | | | | | | | | | I proofread the whole thing. I fixed everything that I thought could use improvement. various grammar and man page style-guide fixes (commas, word order, etc.). Reworded a couple things to hopefully make it clear to someone that didn't already know about fstab. Re-ordered the intro paragraphs for easier skimming. And added an example line. Expanded on a couple things other things. Tightened up the wording in some other places to get the point across faster and in less space. Thanks to Benno Schulenberg <bensberg@justemail.net> for several improvements. Signed-off-by: Peter Cordes <peter@cordes.ca>
* docs: fix some spelling errors and typos in man pagesBill Pemberton2015-03-128-8/+8
| | | | | | | | | | | | | runuser.1: fix spelling implemenation -> implementation scriptreplay.1: fix spelling overide -> override unshare.1: fix spelling permamently -> permanently last.1: fix spelling preferrable -> preferable lslogins.1: fix spelling priviliges -> privileges hwclock.8.in: fix spelling transfered -> transferred prlimit.1: fix typo umlimited -> unlimited agetty.8: fix typo unnsupported -> unsupported Signed-off-by: Bill Pemberton <wfp5p@worldbroken.com>
* colors: cleanup man pages, add hint to usage()Karel Zak2015-03-1210-25/+35
| | | | | | | | cfdisk, fdisk, calm dmesg and hexdump Signed-off-by: Karel Zak <kzak@redhat.com> Signed-off-by: Karel Zak <kzak@redhat.com>
* sfdisk: add missing --colorKarel Zak2015-03-122-3/+40
| | | | | | | The util already support lib/colors.c stuff, but without command line option. Signed-off-by: Karel Zak <kzak@redhat.com>
* lib/colors: add USAGE_COLORS_DEFAULTKarel Zak2015-03-121-0/+7
| | | | Signed-off-by: Karel Zak <kzak@redhat.com>
* build-sys: add --disable-colors-defaultKarel Zak2015-03-122-2/+21
| | | | | | | | The current util-linux is to have enabled colorized outputs by default, this default behavior is possible to change by new configure option --disable-colors-default. Signed-off-by: Karel Zak <kzak@redhat.com>
* logger: link libsystemd-daemon.soRuediger Meier2015-03-121-2/+2
| | | | | | | | | | Noticed on openSUSE 13.1: util-linux-2.26/misc-utils/logger.c:735: undefined reference to `sd_booted' Introduced in d77dc29e. CC: Sami Kerola <kerolasa@iki.fi> Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
View Lorry Controller Status