linfdisk: cleanup fsync usage

 * always use fsync() if the device open read-write
 * use sync() on demand

Signed-off-by: Karel Zak <kzak@redhat.com>

1 files changed, 5 insertions, 4 deletions

diff --git a/libfdisk/src/context.c b/libfdisk/src/context.c
index 61a6ce30a..6f9b4cfc1 100644
--- a/libfdisk/src/context.c
+++ b/libfdisk/src/context.c
@@ -299,9 +299,8 @@ int fdisk_context_deassign_device(struct fdisk_context *cxt, int nosync)
 	assert(cxt);
 	assert(cxt->dev_fd >= 0);
 
-	if (cxt->readonly || nosync)
+	if (cxt->readonly)
 		close(cxt->dev_fd);
-
 	else {
 		if (fsync(cxt->dev_fd) || close(cxt->dev_fd)) {
 			fdisk_warn(cxt, _("%s: close device failed"),
@@ -309,8 +308,10 @@ int fdisk_context_deassign_device(struct fdisk_context *cxt, int nosync)
 			return -errno;
 		}
 
-		fdisk_info(cxt, _("Syncing disks."));
-		sync();
+		if (!nosync) {
+			fdisk_info(cxt, _("Syncing disks."));
+			sync();
+		}
 	}
 	cxt->dev_fd = -1;
 	return 0;