summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSebastian Pipping <sebastian@pipping.org>2021-03-29 22:46:34 +0200
committerSebastian Pipping <sebastian@pipping.org>2021-03-29 22:59:03 +0200
commita53cbbef018d3a0ca9771a626cdfe472c8e2769f (patch)
tree81c6080aa413a5c130febbb516435e3b939fea8a
parentcf1bfe69b02c533bf2803c23a8e300e59127a2f7 (diff)
downloaduriparser-a53cbbef018d3a0ca9771a626cdfe472c8e2769f.tar.gz
tests: Address MSVC compiler warning C4018
warning C4018: '>=': signed/unsigned mismatch
-rw-r--r--ChangeLog1
-rw-r--r--test/MemoryManagerSuite.cpp8
2 files changed, 5 insertions, 4 deletions
diff --git a/ChangeLog b/ChangeLog
index 0dd0640..3e7a898 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -8,6 +8,7 @@ XXXX-XX-XX -- X.X.X
CMAKE_CXX_* variables (GitHub #110)
Thanks to Alexander Richardson for the patch (originally at libexpat)
* Fixed: Windows: Address MSVC compiler warnings (GitHub #111)
+ * Fixed: Addressed MSVC compiler warnings in test suite code (GitHub #113)
2021-03-18 -- 0.9.5
diff --git a/test/MemoryManagerSuite.cpp b/test/MemoryManagerSuite.cpp
index a828d76..26e002e 100644
--- a/test/MemoryManagerSuite.cpp
+++ b/test/MemoryManagerSuite.cpp
@@ -318,11 +318,11 @@ TEST(FailingMemoryManagerSuite, DissectQueryMallocExMm) {
TEST(FailingMemoryManagerSuite, FreeQueryListMm) {
UriQueryListA * const queryList = parseQueryList("k1=v1");
FailingMemoryManager failingMemoryManager;
- ASSERT_EQ(failingMemoryManager.getCallCountFree(), 0);
+ ASSERT_EQ(failingMemoryManager.getCallCountFree(), 0U);
uriFreeQueryListMmA(queryList, &failingMemoryManager);
- ASSERT_GE(failingMemoryManager.getCallCountFree(), 1);
+ ASSERT_GE(failingMemoryManager.getCallCountFree(), 1U);
}
@@ -330,11 +330,11 @@ TEST(FailingMemoryManagerSuite, FreeQueryListMm) {
TEST(FailingMemoryManagerSuite, FreeUriMembersMm) {
UriUriA uri = parse("http://example.org/");
FailingMemoryManager failingMemoryManager;
- ASSERT_EQ(failingMemoryManager.getCallCountFree(), 0);
+ ASSERT_EQ(failingMemoryManager.getCallCountFree(), 0U);
uriFreeUriMembersMmA(&uri, &failingMemoryManager);
- ASSERT_GE(failingMemoryManager.getCallCountFree(), 1);
+ ASSERT_GE(failingMemoryManager.getCallCountFree(), 1U);
uriFreeUriMembersA(&uri);
}