diff options
author | Trent Piepho <xyzzy@speakeasy.org> | 2009-02-18 15:22:05 -0800 |
---|---|---|
committer | Wolfgang Denk <wd@denx.de> | 2009-03-20 22:39:12 +0100 |
commit | f62fb99941c625605aa16a0097b396a5c16d2c88 (patch) | |
tree | a0269ee7e9fa0efacf18d9b6b2a44000c731aa0f /nand_spl | |
parent | 566b652c7cdb0e5e0529bb3d1eaffbd2bf45a032 (diff) | |
download | u-boot-f62fb99941c625605aa16a0097b396a5c16d2c88.tar.gz |
Fix all linker script to handle all rodata sections
A recent gcc added a new unaligned rodata section called '.rodata.str1.1',
which needs to be added the the linker script. Instead of just adding this
one section, we use a wildcard ".rodata*" to get all rodata linker section
gcc has now and might add in the future.
However, '*(.rodata*)' by itself will result in sub-optimal section
ordering. The sections will be sorted by object file, which causes extra
padding between the unaligned rodata.str.1.1 of one object file and the
aligned rodata of the next object file. This is easy to fix by using the
SORT_BY_ALIGNMENT command.
This patch has not be tested one most of the boards modified. Some boards
have a linker script that looks something like this:
*(.text)
. = ALIGN(16);
*(.rodata)
*(.rodata.str1.4)
*(.eh_frame)
I change this to:
*(.text)
. = ALIGN(16);
*(.eh_frame)
*(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*)))
This means the start of rodata will no longer be 16 bytes aligned.
However, the boundary between text and rodata/eh_frame is still aligned to
16 bytes, which is what I think the real purpose of the ALIGN call is.
Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
Diffstat (limited to 'nand_spl')
-rw-r--r-- | nand_spl/board/amcc/acadia/u-boot.lds | 2 | ||||
-rw-r--r-- | nand_spl/board/amcc/bamboo/u-boot.lds | 2 | ||||
-rw-r--r-- | nand_spl/board/amcc/canyonlands/u-boot.lds | 2 | ||||
-rw-r--r-- | nand_spl/board/amcc/kilauea/u-boot.lds | 2 | ||||
-rw-r--r-- | nand_spl/board/amcc/sequoia/u-boot.lds | 2 | ||||
-rw-r--r-- | nand_spl/board/freescale/mpc8313erdb/u-boot.lds | 2 | ||||
-rw-r--r-- | nand_spl/board/samsung/smdk6400/u-boot.lds | 2 | ||||
-rw-r--r-- | nand_spl/board/sheldon/simpc8313/u-boot.lds | 2 |
8 files changed, 8 insertions, 8 deletions
diff --git a/nand_spl/board/amcc/acadia/u-boot.lds b/nand_spl/board/amcc/acadia/u-boot.lds index ab42701404..b89cd809bf 100644 --- a/nand_spl/board/amcc/acadia/u-boot.lds +++ b/nand_spl/board/amcc/acadia/u-boot.lds @@ -42,7 +42,7 @@ SECTIONS .data : { - *(.rodata*) + *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*))) *(.data*) *(.sdata*) __got2_start = .; diff --git a/nand_spl/board/amcc/bamboo/u-boot.lds b/nand_spl/board/amcc/bamboo/u-boot.lds index b13168ffad..d171269c32 100644 --- a/nand_spl/board/amcc/bamboo/u-boot.lds +++ b/nand_spl/board/amcc/bamboo/u-boot.lds @@ -44,7 +44,7 @@ SECTIONS .data : { - *(.rodata*) + *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*))) *(.data*) *(.sdata*) __got2_start = .; diff --git a/nand_spl/board/amcc/canyonlands/u-boot.lds b/nand_spl/board/amcc/canyonlands/u-boot.lds index ef6d5600d4..e676e0c7c0 100644 --- a/nand_spl/board/amcc/canyonlands/u-boot.lds +++ b/nand_spl/board/amcc/canyonlands/u-boot.lds @@ -44,7 +44,7 @@ SECTIONS .data : { - *(.rodata*) + *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*))) *(.data*) *(.sdata*) __got2_start = .; diff --git a/nand_spl/board/amcc/kilauea/u-boot.lds b/nand_spl/board/amcc/kilauea/u-boot.lds index 1335532c91..5a586fc7c8 100644 --- a/nand_spl/board/amcc/kilauea/u-boot.lds +++ b/nand_spl/board/amcc/kilauea/u-boot.lds @@ -42,7 +42,7 @@ SECTIONS .data : { - *(.rodata*) + *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*))) *(.data*) *(.sdata*) __got2_start = .; diff --git a/nand_spl/board/amcc/sequoia/u-boot.lds b/nand_spl/board/amcc/sequoia/u-boot.lds index d38d097752..1601c36891 100644 --- a/nand_spl/board/amcc/sequoia/u-boot.lds +++ b/nand_spl/board/amcc/sequoia/u-boot.lds @@ -44,7 +44,7 @@ SECTIONS .data : { - *(.rodata*) + *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*))) *(.data*) *(.sdata*) __got2_start = .; diff --git a/nand_spl/board/freescale/mpc8313erdb/u-boot.lds b/nand_spl/board/freescale/mpc8313erdb/u-boot.lds index 40c414549c..ad8258957b 100644 --- a/nand_spl/board/freescale/mpc8313erdb/u-boot.lds +++ b/nand_spl/board/freescale/mpc8313erdb/u-boot.lds @@ -30,8 +30,8 @@ SECTIONS .text : { *(.text*) . = ALIGN(16); - *(.rodata*) *(.eh_frame) + *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*))) } . = ALIGN(8); diff --git a/nand_spl/board/samsung/smdk6400/u-boot.lds b/nand_spl/board/samsung/smdk6400/u-boot.lds index eb8910c129..56e10157cf 100644 --- a/nand_spl/board/samsung/smdk6400/u-boot.lds +++ b/nand_spl/board/samsung/smdk6400/u-boot.lds @@ -42,7 +42,7 @@ SECTIONS } . = ALIGN(4); - .rodata : { *(.rodata) } + .rodata : { *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*))) } . = ALIGN(4); .data : { *(.data) } diff --git a/nand_spl/board/sheldon/simpc8313/u-boot.lds b/nand_spl/board/sheldon/simpc8313/u-boot.lds index 40c414549c..ad8258957b 100644 --- a/nand_spl/board/sheldon/simpc8313/u-boot.lds +++ b/nand_spl/board/sheldon/simpc8313/u-boot.lds @@ -30,8 +30,8 @@ SECTIONS .text : { *(.text*) . = ALIGN(16); - *(.rodata*) *(.eh_frame) + *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*))) } . = ALIGN(8); |