diff options
| author | Simon Glass <sjg@chromium.org> | 2020-05-10 11:40:03 -0600 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2020-05-18 18:36:55 -0400 |
| commit | 09140113108541b95d340f3c7b6ee597d31ccc73 (patch) | |
| tree | 4b4241b799bbbb2eeef4164392442b193af1703f /drivers/net/phy | |
| parent | 691d719db7183dfb1d1360efed4c5e9f6899095f (diff) | |
| download | u-boot-09140113108541b95d340f3c7b6ee597d31ccc73.tar.gz | |
command: Remove the cmd_tbl_t typedef
We should not use typedefs in U-Boot. They cannot be used as forward
declarations which means that header files must include the full header to
access them.
Drop the typedef and rename the struct to remove the _s suffix which is
now not useful.
This requires quite a few header-file additions.
Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'drivers/net/phy')
| -rw-r--r-- | drivers/net/phy/b53.c | 7 | ||||
| -rw-r--r-- | drivers/net/phy/mv88e6352.c | 7 |
2 files changed, 8 insertions, 6 deletions
diff --git a/drivers/net/phy/b53.c b/drivers/net/phy/b53.c index 30c4812d82..f039f895c8 100644 --- a/drivers/net/phy/b53.c +++ b/drivers/net/phy/b53.c @@ -23,6 +23,7 @@ */ #include <common.h> +#include <command.h> #include <errno.h> #include <malloc.h> @@ -627,7 +628,7 @@ int phy_b53_init(void) return 0; } -int do_b53_reg_read(const char *name, int argc, char * const argv[]) +int do_b53_reg_read(const char *name, int argc, char *const argv[]) { u8 page, offset, width; struct mii_dev *bus; @@ -681,7 +682,7 @@ int do_b53_reg_read(const char *name, int argc, char * const argv[]) return ret; } -int do_b53_reg_write(const char *name, int argc, char * const argv[]) +int do_b53_reg_write(const char *name, int argc, char *const argv[]) { u8 page, offset, width; struct mii_dev *bus; @@ -727,7 +728,7 @@ int do_b53_reg_write(const char *name, int argc, char * const argv[]) return ret; } -int do_b53_reg(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) +int do_b53_reg(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) { const char *cmd, *mdioname; int ret = 0; diff --git a/drivers/net/phy/mv88e6352.c b/drivers/net/phy/mv88e6352.c index 6fe08b80c1..a27a9cc03e 100644 --- a/drivers/net/phy/mv88e6352.c +++ b/drivers/net/phy/mv88e6352.c @@ -5,6 +5,7 @@ */ #include <common.h> +#include <command.h> #include <miiphy.h> #include <linux/errno.h> #include <mv88e6352.h> @@ -230,7 +231,7 @@ int mv88e_sw_reset(const char *devname, u8 phy_addr) return -ETIMEDOUT; } -int do_mvsw_reg_read(const char *name, int argc, char * const argv[]) +int do_mvsw_reg_read(const char *name, int argc, char *const argv[]) { u16 value = 0, phyaddr, reg, port; int ret; @@ -245,7 +246,7 @@ int do_mvsw_reg_read(const char *name, int argc, char * const argv[]) return ret; } -int do_mvsw_reg_write(const char *name, int argc, char * const argv[]) +int do_mvsw_reg_write(const char *name, int argc, char *const argv[]) { u16 value = 0, phyaddr, reg, port; int ret; @@ -261,7 +262,7 @@ int do_mvsw_reg_write(const char *name, int argc, char * const argv[]) } -int do_mvsw_reg(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) +int do_mvsw_reg(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) { int ret; const char *cmd, *ethname; |