diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /board/tqc/tqma6 | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
download | u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.gz |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'board/tqc/tqma6')
-rw-r--r-- | board/tqc/tqma6/tqma6.c | 4 | ||||
-rw-r--r-- | board/tqc/tqma6/tqma6_bb.h | 4 | ||||
-rw-r--r-- | board/tqc/tqma6/tqma6_mba6.c | 2 | ||||
-rw-r--r-- | board/tqc/tqma6/tqma6_wru4.c | 6 |
4 files changed, 8 insertions, 8 deletions
diff --git a/board/tqc/tqma6/tqma6.c b/board/tqc/tqma6/tqma6.c index d7df4f976a..2df901a584 100644 --- a/board/tqc/tqma6/tqma6.c +++ b/board/tqc/tqma6/tqma6.c @@ -117,7 +117,7 @@ int board_mmc_getwp(struct mmc *mmc) return ret; } -int board_mmc_init(bd_t *bis) +int board_mmc_init(struct bd_info *bis) { imx_iomux_v3_setup_multiple_pads(tqma6_usdhc3_pads, ARRAY_SIZE(tqma6_usdhc3_pads)); @@ -286,7 +286,7 @@ int checkboard(void) */ #if defined(CONFIG_OF_BOARD_SETUP) && defined(CONFIG_OF_LIBFDT) #define MODELSTRLEN 32u -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { char modelstr[MODELSTRLEN]; diff --git a/board/tqc/tqma6/tqma6_bb.h b/board/tqc/tqma6/tqma6_bb.h index 16b8fb9863..b0f1f99a83 100644 --- a/board/tqc/tqma6/tqma6_bb.h +++ b/board/tqc/tqma6/tqma6_bb.h @@ -11,7 +11,7 @@ int tqma6_bb_board_mmc_getwp(struct mmc *mmc); int tqma6_bb_board_mmc_getcd(struct mmc *mmc); -int tqma6_bb_board_mmc_init(bd_t *bis); +int tqma6_bb_board_mmc_init(struct bd_info *bis); int tqma6_bb_board_early_init_f(void); int tqma6_bb_board_init(void); @@ -23,7 +23,7 @@ const char *tqma6_bb_get_boardname(void); * Device Tree Support */ #if defined(CONFIG_OF_BOARD_SETUP) && defined(CONFIG_OF_LIBFDT) -void tqma6_bb_ft_board_setup(void *blob, bd_t *bd); +void tqma6_bb_ft_board_setup(void *blob, struct bd_info *bd); #endif /* defined(CONFIG_OF_BOARD_SETUP) && defined(CONFIG_OF_LIBFDT) */ #endif diff --git a/board/tqc/tqma6/tqma6_mba6.c b/board/tqc/tqma6/tqma6_mba6.c index 84d0e386a3..801619e80b 100644 --- a/board/tqc/tqma6/tqma6_mba6.c +++ b/board/tqc/tqma6/tqma6_mba6.c @@ -186,7 +186,7 @@ const char *tqma6_bb_get_boardname(void) * Device Tree Support */ #if defined(CONFIG_OF_BOARD_SETUP) && defined(CONFIG_OF_LIBFDT) -void tqma6_bb_ft_board_setup(void *blob, bd_t *bd) +void tqma6_bb_ft_board_setup(void *blob, struct bd_info *bd) { /* TBD */ } diff --git a/board/tqc/tqma6/tqma6_wru4.c b/board/tqc/tqma6/tqma6_wru4.c index 0488cbaaa8..3b1bc603ce 100644 --- a/board/tqc/tqma6/tqma6_wru4.c +++ b/board/tqc/tqma6/tqma6_wru4.c @@ -116,7 +116,7 @@ int tqma6_bb_board_mmc_getwp(struct mmc *mmc) return ret; } -int tqma6_bb_board_mmc_init(bd_t *bis) +int tqma6_bb_board_mmc_init(struct bd_info *bis) { int ret; @@ -182,7 +182,7 @@ static void setup_iomuxc_enet(void) gpio_set_value(ENET_PHY_RESET_GPIO, 1); } -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { return cpu_eth_init(bis); } @@ -340,7 +340,7 @@ int board_ehci_power(int port, int on) * Device Tree Support */ #if defined(CONFIG_OF_BOARD_SETUP) && defined(CONFIG_OF_LIBFDT) -void tqma6_bb_ft_board_setup(void *blob, bd_t *bd) +void tqma6_bb_ft_board_setup(void *blob, struct bd_info *bd) { /* TBD */ } |