diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /board/keymile/kmp204x | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
download | u-boot-b75d8dc5642b71eb029e7cd38031a32029e736cc.tar.gz |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'board/keymile/kmp204x')
-rw-r--r-- | board/keymile/kmp204x/eth.c | 2 | ||||
-rw-r--r-- | board/keymile/kmp204x/kmp204x.c | 2 | ||||
-rw-r--r-- | board/keymile/kmp204x/kmp204x.h | 2 | ||||
-rw-r--r-- | board/keymile/kmp204x/pci.c | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/board/keymile/kmp204x/eth.c b/board/keymile/kmp204x/eth.c index 8635a5448b..29c5b339ae 100644 --- a/board/keymile/kmp204x/eth.c +++ b/board/keymile/kmp204x/eth.c @@ -11,7 +11,7 @@ #include <fsl_mdio.h> #include <phy.h> -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { int ret = 0; #ifdef CONFIG_FMAN_ENET diff --git a/board/keymile/kmp204x/kmp204x.c b/board/keymile/kmp204x/kmp204x.c index 21afbc7f39..29dde7a802 100644 --- a/board/keymile/kmp204x/kmp204x.c +++ b/board/keymile/kmp204x/kmp204x.c @@ -222,7 +222,7 @@ void fdt_fixup_fman_mac_addresses(void *blob) } #endif -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { phys_addr_t base; phys_size_t size; diff --git a/board/keymile/kmp204x/kmp204x.h b/board/keymile/kmp204x/kmp204x.h index 00e1a06662..3b858a5571 100644 --- a/board/keymile/kmp204x/kmp204x.h +++ b/board/keymile/kmp204x/kmp204x.h @@ -5,4 +5,4 @@ */ -void pci_of_setup(void *blob, bd_t *bd); +void pci_of_setup(void *blob, struct bd_info *bd); diff --git a/board/keymile/kmp204x/pci.c b/board/keymile/kmp204x/pci.c index 87bf16886a..cdb498da03 100644 --- a/board/keymile/kmp204x/pci.c +++ b/board/keymile/kmp204x/pci.c @@ -119,7 +119,7 @@ void pci_init_board(void) fsl_pcie_init_board(0); } -void pci_of_setup(void *blob, bd_t *bd) +void pci_of_setup(void *blob, struct bd_info *bd) { FT_FSL_PCI_SETUP; } |