diff options
| author | Simon Glass <sjg@chromium.org> | 2018-10-01 12:22:45 -0600 |
|---|---|---|
| committer | Simon Glass <sjg@chromium.org> | 2018-10-09 04:40:27 -0600 |
| commit | eb517315a67320e770cf4a100a922e8ae18fa54e (patch) | |
| tree | 9719fdb41ca23453b55aeee7f01ee04b8b28e67e | |
| parent | 595aac98246bb26d128389e25b147ae9643afb26 (diff) | |
| download | u-boot-eb517315a67320e770cf4a100a922e8ae18fa54e.tar.gz | |
sysreset: Tidy up a few comments and logging
Some comments are incorrect or missing pieces. Fix these and use logging
to print the error.
Signed-off-by: Simon Glass <sjg@chromium.org>
| -rw-r--r-- | drivers/sysreset/sysreset-uclass.c | 4 | ||||
| -rw-r--r-- | include/sysreset.h | 4 | ||||
| -rw-r--r-- | test/dm/sysreset.c | 1 |
3 files changed, 6 insertions, 3 deletions
diff --git a/drivers/sysreset/sysreset-uclass.c b/drivers/sysreset/sysreset-uclass.c index 06ef0ed96c..e38814b3ed 100644 --- a/drivers/sysreset/sysreset-uclass.c +++ b/drivers/sysreset/sysreset-uclass.c @@ -4,6 +4,8 @@ * Written by Simon Glass <sjg@chromium.org> */ +#define LOG_CATEGORY UCLASS_SYSRESET + #include <common.h> #include <sysreset.h> #include <dm.h> @@ -64,7 +66,7 @@ void sysreset_walk_halt(enum sysreset_t type) mdelay(100); /* Still no reset? Give up */ - debug("System reset not supported on this platform\n"); + log_err("System reset not supported on this platform\n"); hang(); } diff --git a/include/sysreset.h b/include/sysreset.h index a5c0b74a47..343e46f1aa 100644 --- a/include/sysreset.h +++ b/include/sysreset.h @@ -31,6 +31,7 @@ struct sysreset_ops { /** * get_status() - get printable reset status information * + * @dev: Device to check * @buf: Buffer to receive the textual reset information * @size: Size of the passed buffer * @return 0 if OK, -ve on error @@ -49,8 +50,9 @@ struct sysreset_ops { int sysreset_request(struct udevice *dev, enum sysreset_t type); /** - * get_status() - get printable reset status information + * sysreset_get_status() - get printable reset status information * + * @dev: Device to check * @buf: Buffer to receive the textual reset information * @size: Size of the passed buffer * @return 0 if OK, -ve on error diff --git a/test/dm/sysreset.c b/test/dm/sysreset.c index 04d4621d9e..218cc239cc 100644 --- a/test/dm/sysreset.c +++ b/test/dm/sysreset.c @@ -62,7 +62,6 @@ static int dm_test_sysreset_get_status(struct unit_test_state *uts) return 0; } - DM_TEST(dm_test_sysreset_get_status, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT); /* Test that we can walk through the sysreset devices */ |