summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Glass <sjg@chromium.org>2018-10-01 12:22:28 -0600
committerSimon Glass <sjg@chromium.org>2018-10-09 04:40:27 -0600
commit34a5e8a2f155589e6274fbeef4be0aacf5244a27 (patch)
treeb9704fa135ee3c830ca0b8235629bfe2c2de88fe
parentc89d32a7b1acc6a16b1e749e93844f7364ceacbf (diff)
downloadu-boot-34a5e8a2f155589e6274fbeef4be0aacf5244a27.tar.gz
tpm: Tidy up logging in tpm-common.c
At present this file uses logging but it should use the new macros. Update it and add a log message for an error. Signed-off-by: Simon Glass <sjg@chromium.org>
-rw-r--r--lib/tpm-common.c10
1 files changed, 7 insertions, 3 deletions
diff --git a/lib/tpm-common.c b/lib/tpm-common.c
index 43b530865a..a440639cec 100644
--- a/lib/tpm-common.c
+++ b/lib/tpm-common.c
@@ -4,6 +4,8 @@
* Coypright (c) 2013 Guntermann & Drunck GmbH
*/
+#define LOG_CATEGORY UCLASS_TPM
+
#include <common.h>
#include <dm.h>
#include <asm/unaligned.h>
@@ -110,6 +112,8 @@ int unpack_byte_string(const u8 *str, size_t size, const char *format, ...)
if (offset + length > size) {
va_end(args);
+ log_err("Failed to read: size=%d, offset=%x, len=%x\n",
+ size, offset, length);
return -1;
}
@@ -176,10 +180,10 @@ u32 tpm_sendrecv_command(const void *command, void *response, size_t *size_ptr)
ret = tpm_return_code(response);
- log(LOGC_NONE, LOGL_DEBUG, "TPM response [ret:%d]: ", ret);
+ log_debug("TPM response [ret:%d]: ", ret);
for (i = 0; i < response_length; i++)
- log(LOGC_NONE, LOGL_DEBUG, "%02x ", ((u8 *)response)[i]);
- log(LOGC_NONE, LOGL_DEBUG, "\n");
+ log_debug("%02x ", ((u8 *)response)[i]);
+ log_debug("\n");
return ret;
}