summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSamuel Holland <samuel@sholland.org>2018-01-27 23:53:20 -0600
committerJagan Teki <jagan@amarulasolutions.com>2018-03-13 21:16:51 +0530
commit2d53018a0ef268ba73aebe2441f1fd7c65533d78 (patch)
tree26ecbb33557887a9bd7aea8de7f5f3eb6489b05b
parentb0b0d22f1a11b656e1a72f0e178f968b14be7ff3 (diff)
downloadu-boot-2d53018a0ef268ba73aebe2441f1fd7c65533d78.tar.gz
net: sun8i_emac: Fix PHY initialization
The previous code tried to update the PHY parameters without waiting for autonegotiation to complete. This caused wrong values to be written to the EMAC in sun8i_adjust_link(). As a result, any commands that called eth_start() before autonegotiation completed would find the network nonfunctional. Fix this by using the correct function to start up the PHY. Signed-off-by: Samuel Holland <samuel@sholland.org> Acked-by: Joe Hershberger <joe.hershberger@ni.com> Reviewed-by: Jagan Teki <jagan@openedev.com>
-rw-r--r--drivers/net/sun8i_emac.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c
index 3ccc6b0bb6..be43472b1a 100644
--- a/drivers/net/sun8i_emac.c
+++ b/drivers/net/sun8i_emac.c
@@ -431,7 +431,7 @@ static int _sun8i_emac_eth_init(struct emac_eth_dev *priv, u8 *enetaddr)
tx_descs_init(priv);
/* PHY Start Up */
- genphy_parse_link(priv->phydev);
+ phy_startup(priv->phydev);
sun8i_adjust_link(priv, priv->phydev);