diff options
| author | Lokesh Vutla <lokeshvutla@ti.com> | 2020-04-22 22:55:31 +0530 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2020-04-23 08:25:37 -0400 |
| commit | dbfd9e0e61ff1f9c65703959ed8e3ceb410d1e7e (patch) | |
| tree | 074441bedd553055dbf49e42e298daf3d4c1840a | |
| parent | a5f9b8a8b592400a01771ad2dac76cba69c914f3 (diff) | |
| download | u-boot-WIP/23Apr2020.tar.gz | |
dm: pinctrl: Use right device pointer for configuring pinctrlWIP/23Apr2020
commit 719cab6d2e2bf ("dm: pinctrl: convert pinctrl-single to livetree")
converted pinctrl driver to livetree. In this conversion, the call to
read pinctrl-single,pins/bits property is provided with pinctrl device
pointer instead of pinctrl config pointer. Because of this none of the
pins gets configured. Fix it by passing the right udevice pointer.
Fixes: 719cab6d2e2bf ("dm: pinctrl: convert pinctrl-single to livetree")
Reported-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
| -rw-r--r-- | drivers/pinctrl/pinctrl-single.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index a5d1ff0e97..738f5bd636 100644 --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c @@ -120,7 +120,7 @@ static int single_set_state(struct udevice *dev, const struct single_fdt_bits_cfg *prop_bits; int len; - prop = dev_read_prop(dev, "pinctrl-single,pins", &len); + prop = dev_read_prop(config, "pinctrl-single,pins", &len); if (prop) { dev_dbg(dev, "configuring pins for %s\n", config->name); @@ -133,7 +133,7 @@ static int single_set_state(struct udevice *dev, } /* pinctrl-single,pins not found so check for pinctrl-single,bits */ - prop_bits = dev_read_prop(dev, "pinctrl-single,bits", &len); + prop_bits = dev_read_prop(config, "pinctrl-single,bits", &len); if (prop_bits) { dev_dbg(dev, "configuring pins for %s\n", config->name); if (len % sizeof(struct single_fdt_bits_cfg)) { |