| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Correct a potential comment length sanity check overflow.
Commit additional hardening to comment packet decode.
Also add allocation checks, since these can still run us out of address space
if someone actually sends a GB or two of comment data.
[Import parts of changes from Tremor (69dfba9 2010-10-13)]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
needed to decode was not an integer number of dims wide. This caused
it to overflow the output vector as the termination condition was in
the outer loop of vorbis_book_decodev_set.
None of the various vorbis_book_decodeXXXX calls internally guard
against this case either, but in every other use the calling code does
properly guard (and avoids putting more checks in the tight inner
decode loop).
For floor0, move the checks into the inner loop as there's little
penalty for doing so. Add commentary indicating where guarding is
done.
[Import part of changes from Tremor (80661a1 2010-10-18)]
|
|
|
|
|
|
| |
Disallow books with dim<1 and book index < 0 in floor0
[Import changes from Tremor (8b4f038 2010-10-18)]
|
|
|
|
| |
[Import changes from Tremor (c7b26d1 2011-09-24)]
|
|
|
|
| |
[Import changes from Tremor (3daa274 2012-01-20)]
|
|
|
|
|
|
|
| |
range of the piecewise representation, it can overflow the lookup.
Proper fix here is just a simple clamp.
[Import changes from Tremor (d9c0b17 2010-10-18)]
|
|
|
|
|
|
| |
codebook.c:434:5: warning: suggest parentheses around '-' inside '>>'
[Import changes from Tremor (ef65123 2010-10-16)]
|
|
|
|
| |
[Import part of the changes from Tremor (3b65200 2010-10-16)]
|
|
|
|
|
|
|
|
|
|
|
| |
Header setup allows the LSP order to be as low as one, but the code in
vorbis_lsp_to_curve() assumed it was at least two.
This wasn't terrible in libvorbis... it would multiply a nonsense (but defined)
value into the output, and nothing more.
In Tremor, it referenced several completely undefined (stack) values, which
could cause out-of-bounds lookup table accesses and crashes.
[Impot changes from Tremor (3ada73c 2010-10-15)]
|
|
|
|
|
|
| |
Don't allow ordered codebooks with codeword lengths longer than 32 bits.
[Import changes from Tremor (7b7f841 2010-10-14)]
|
|
|
|
|
|
|
|
| |
ivorbisfile_example.c ignores an error code and plows ahead blindly if
libvorbisidec reports the current bitstream section is bad (OV_EBADLINK).
Retrying after the error crashes libvorbisidec due to the unitialized state.
[Import part of the changes from Tremor (ff67c8b 2010-10-14)]
|
|
|
|
|
|
| |
Commit additional hardening to setup packet decode.
[Import changes from Tremor (28854b5 2010-10-14)]
|
|
|
|
|
|
| |
Fix for https://bugzilla.mozilla.org/show_bug.cgi?id=501279
[Import changes from Tremor (ba51e86 2010-10-14)]
|
|
|
|
|
|
| |
Correct an accidental dereference-before-check in error cleanup in comments.
[Import changes from Tremor(e847296 2010-10-13)]
|
|
|
|
|
|
| |
Correctly handle the nonsensical codebook.dim==0 case.
[Import changes from Tremor (1d1f93e 2010-10-13)]
|
|
|
|
|
|
| |
Moral equivalent of r15937 for libvorbis.
[Import changes from Tremor (3d08906 2010-10-13)]
|
| |
|
| |
|
|
|
|
| |
Add WinMain definition for WIN32_WCE
|
|
|
|
| |
Some compilers expect explicit cast of pointers to void in appropriate pointer types.
|
| |
|
|
|
|
| |
optimization).
|
| |
|
| |
|
|
|
|
| |
Add small optimization in case 3 of decode_map function.
|
|
|
|
|
|
| |
File decode_mapMIPS.S can be used on all MIPS32R2 architectures.
Files floor1_inverse2MIPS.S and mdct_backwardMIPS.S can be used on MIPS32R2
architectures that support MIPS DSP ASE rev 1
|
| |
|
|
|
|
|
|
|
|
| |
WAV format.
git-svn-id: https://svn.xiph.org/branches/lowmem-branch/Tremolo@17299 0101bb08-14d6-0310-b084-bc0e0c8e3800
|
|
|
|
| |
git-svn-id: https://svn.xiph.org/branches/lowmem-branch/Tremolo@17298 0101bb08-14d6-0310-b084-bc0e0c8e3800
|
|
|
|
|
|
|
|
| |
streams - thanks to Stuart Fisher for the pointer to the problem stream.
git-svn-id: https://svn.xiph.org/branches/lowmem-branch/Tremolo@17297 0101bb08-14d6-0310-b084-bc0e0c8e3800
|
|
|
|
|
|
|
|
|
| |
into the stream chain.
git-svn-id: https://svn.xiph.org/branches/lowmem-branch/Tremolo@17264 0101bb08-14d6-0310-b084-bc0e0c8e3800
|
|
|
|
| |
git-svn-id: https://svn.xiph.org/branches/lowmem-branch/Tremolo@17263 0101bb08-14d6-0310-b084-bc0e0c8e3800
|
|
|
|
| |
git-svn-id: https://svn.xiph.org/branches/lowmem-branch/Tremolo@17260 0101bb08-14d6-0310-b084-bc0e0c8e3800
|
|
|
|
|
|
|
|
|
| |
Add missing couple of vorbis dsp entrypoints.
git-svn-id: https://svn.xiph.org/branches/lowmem-branch/Tremolo@17258 0101bb08-14d6-0310-b084-bc0e0c8e3800
|
|
|
|
|
|
|
|
|
|
| |
from arm2gnu format. Update revised temporary makefile that now invokes
the conversion script as required.
git-svn-id: https://svn.xiph.org/branches/lowmem-branch/Tremolo@17254 0101bb08-14d6-0310-b084-bc0e0c8e3800
|
|
|
|
|
|
|
|
|
|
|
| |
test_genesis.ogg has entries=6561, and used_entries=81. This results in the
code attempting to alloca 54K on the stack. Instead change the code to use
malloc.
git-svn-id: https://svn.xiph.org/branches/lowmem-branch/Tremolo@17253 0101bb08-14d6-0310-b084-bc0e0c8e3800
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add simple test app testtremor.c.
Add temporary test Makefile, Makefile2 that builds testtremor for
a beagleboard.
Testing with Makefile2/testtremor shows that the C version and the version
with ARM code differs by a maximum of 1 in the output due to different
rounding behaviour.
git-svn-id: https://svn.xiph.org/branches/lowmem-branch/Tremolo@17244 0101bb08-14d6-0310-b084-bc0e0c8e3800
|
|
|
|
| |
git-svn-id: https://svn.xiph.org/branches/lowmem-branch/Tremolo@17243 0101bb08-14d6-0310-b084-bc0e0c8e3800
|
|
|
|
|
|
|
|
| |
For now arm configuration -> _ARM_ASSEM_ -> little endian ARM architecture.
git-svn-id: https://svn.xiph.org/branches/lowmem-branch/Tremolo@17227 0101bb08-14d6-0310-b084-bc0e0c8e3800
|
|
|
|
|
|
|
|
| |
versions).
git-svn-id: https://svn.xiph.org/branches/lowmem-branch/Tremolo@17219 0101bb08-14d6-0310-b084-bc0e0c8e3800
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also changes in the configure.ac file to correctly include the assembly
files on ARM targets.
This is 'my first autoconf' stuff, so any hints/pointers on how to do it
better gratefully accepted.
git-svn-id: https://svn.xiph.org/branches/lowmem-branch/Tremolo@17218 0101bb08-14d6-0310-b084-bc0e0c8e3800
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mostly squashing of warnings with some explicit casts, and removing some
variables that are never used.
Optimisations to render_line.
Various checks for (m)alloc failures and out of range inputs.
Change to use explicit dec_buf rather than repeated calls to alloca.
Change to use dec_method/switch rather than nested if.
Reorder of contents of codebook struct in preparation for ARM code.
git-svn-id: https://svn.xiph.org/branches/lowmem-branch/Tremolo@17217 0101bb08-14d6-0310-b084-bc0e0c8e3800
|
|
git-svn-id: https://svn.xiph.org/branches/lowmem-branch/Tremolo@17216 0101bb08-14d6-0310-b084-bc0e0c8e3800
|