diff options
| author | Yuxuan 'fishy' Wang <yuxuan.wang@reddit.com> | 2022-05-10 13:21:11 -0700 |
|---|---|---|
| committer | Yuxuan 'fishy' Wang <fishywang@gmail.com> | 2022-05-12 13:28:14 -0700 |
| commit | 8e217dca69081016b6b7df344fbf957342243c7f (patch) | |
| tree | 1610da6f7730200f1aaeb26e6b8a285a3f3c6329 | |
| parent | 71ba05ba2dd50aff11f1e88df0712aa9f6df8c9d (diff) | |
| download | thrift-8e217dca69081016b6b7df344fbf957342243c7f.tar.gz | |
Revert "THRIFT-5569: add negative size checks in Go generator when reading maps, sets and lists"
This reverts commit 8987820e84ac26392293ab40480cf8f2971fb314.
| -rw-r--r-- | compiler/cpp/src/thrift/generate/t_go_generator.cc | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/compiler/cpp/src/thrift/generate/t_go_generator.cc b/compiler/cpp/src/thrift/generate/t_go_generator.cc index 4833420c9..f4b94a455 100644 --- a/compiler/cpp/src/thrift/generate/t_go_generator.cc +++ b/compiler/cpp/src/thrift/generate/t_go_generator.cc @@ -3375,9 +3375,6 @@ void t_go_generator::generate_deserialize_container(ostream& out, // Declare variables, read header if (ttype->is_map()) { out << indent() << "_, _, size, err := iprot.ReadMapBegin(ctx)" << endl; - out << indent() << "if size < 0 {" << endl; - out << indent() << " return errors.New(\"map size is negative\")" << endl; - out << indent() << "}" << endl; out << indent() << "if err != nil {" << endl; out << indent() << " return thrift.PrependError(\"error reading map begin: \", err)" << endl; out << indent() << "}" << endl; @@ -3385,9 +3382,6 @@ void t_go_generator::generate_deserialize_container(ostream& out, out << indent() << prefix << eq << " " << (pointer_field ? "&" : "") << "tMap" << endl; } else if (ttype->is_set()) { out << indent() << "_, size, err := iprot.ReadSetBegin(ctx)" << endl; - out << indent() << "if size < 0 {" << endl; - out << indent() << " return errors.New(\"set size is negative\")" << endl; - out << indent() << "}" << endl; out << indent() << "if err != nil {" << endl; out << indent() << " return thrift.PrependError(\"error reading set begin: \", err)" << endl; out << indent() << "}" << endl; @@ -3395,9 +3389,6 @@ void t_go_generator::generate_deserialize_container(ostream& out, out << indent() << prefix << eq << " " << (pointer_field ? "&" : "") << "tSet" << endl; } else if (ttype->is_list()) { out << indent() << "_, size, err := iprot.ReadListBegin(ctx)" << endl; - out << indent() << "if size < 0 {" << endl; - out << indent() << " return errors.New(\"list size is negative\")" << endl; - out << indent() << "}" << endl; out << indent() << "if err != nil {" << endl; out << indent() << " return thrift.PrependError(\"error reading list begin: \", err)" << endl; out << indent() << "}" << endl; |