THRIFT-4973 Add deprecation messages for csharp and netcore

Client: csharp, netcore
Patch: Jens Geyer

This closes #1895

3 files changed, 8 insertions, 0 deletions

diff --git a/compiler/cpp/src/thrift/generate/t_csharp_generator.cc b/compiler/cpp/src/thrift/generate/t_csharp_generator.cc
index e4d99b2cc..a6ece8083 100644
--- a/compiler/cpp/src/thrift/generate/t_csharp_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_csharp_generator.cc
@@ -87,6 +87,8 @@ public:
       }
     }
 
+    pwarning(1, "The 'csharp' target is deprecated. Consider using 'netstd' instead.\n");
+
     out_dir_base_ = "gen-csharp";
   }
   void init_generator() override;
diff --git a/compiler/cpp/src/thrift/generate/t_netcore_generator.cc b/compiler/cpp/src/thrift/generate/t_netcore_generator.cc
index 1a5c3842f..ed6a365ac 100644
--- a/compiler/cpp/src/thrift/generate/t_netcore_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_netcore_generator.cc
@@ -91,6 +91,8 @@ t_netcore_generator::t_netcore_generator(t_program* program, const map<string, s
         }
     }
 
+    pwarning(1, "The 'netcore' target is deprecated. Consider using 'netstd' instead.\n");
+
     out_dir_base_ = "gen-netcore";
 }
 
diff --git a/compiler/cpp/src/thrift/parse/t_program.h b/compiler/cpp/src/thrift/parse/t_program.h
index 140dc35d9..e0b4b6ecd 100644
--- a/compiler/cpp/src/thrift/parse/t_program.h
+++ b/compiler/cpp/src/thrift/parse/t_program.h
@@ -291,6 +291,10 @@ public:
         pwarning(1, "Namespace 'smalltalk' is deprecated. Use 'st' instead");
         base_language = "st";
       }
+      else if ((base_language == "csharp") || (base_language == "netcore")) {
+        pwarning(1, "The '%s' target is deprecated. Consider moving to 'netstd' instead.", base_language.c_str());
+        // warn only, don't change base_language
+      }
 
       t_generator_registry::gen_map_t my_copy = t_generator_registry::get_generator_map();