| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
My commit eaefb26 introduced a regression: by assuming that any class
that implements add_event is writable, logs were being written to the
legacy Empathy location.
By splitting the legacy location handling into a subclass, we can
override add_event to un-implement it and make the subclass read-only,
as well as removing special cases from the XML store itself.
Thanks to Debarshi Ray for catching this!
|
|
|
|
|
| |
By consistently using the wrapper function rather than calling our
implementation directly, subclassing won't break.
|
|
|
|
|
|
|
| |
log_store_xml_get_name() makes the same Empathy vs. TpLogger decision as
the test_mode path was making. Since the log store's name is used to
find the real directory, it also seems better to use the same code path
in the test suite.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Earlier we were using threads to implement the asynchronous get_events
and rewind methods, so we used a mutex to serialize them. However, now
get_events has been moved to a single threaded model, so using a mutex
will lead to undefined behaviour.
Instead we use a queue to store incoming operations (ie. get_events or
rewind) and they are executed one after the other.
Fixes: https://bugs.freedesktop.org/54270
|
|
|
|
|
|
| |
As a result we don't need the wrapper callback for fill_cache.
Fixes: https://bugs.freedesktop.org/54270
|
|
|
|
| |
Fixes: https://bugs.freedesktop.org/54270
|
|
|
|
| |
Fixes: https://bugs.freedesktop.org/54270
|
|
|
|
|
|
| |
... to cover the use of a filter.
Fixes: https://bugs.freedesktop.org/54270
|
|
|
|
|
|
| |
... to cover the use of a filter.
Fixes: https://bugs.freedesktop.org/54270
|
|
|
|
| |
Purely cosmetic. No changes in functionality.
|
|
|
|
|
|
|
|
|
|
| |
This ensures that the TplLogEventFilter is always run from the same
thread which invoked the walker. This is implemented by keeping track
of skipped events in the history instead of silently ignoring them
within the LogIters. This has the nice side effect that we do not need
to run the filter while rewinding.
Fixes: https://bugs.freedesktop.org/54270
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
... so that only the caches are filled asynchronously and the rest of
the work does not involve the use of a separate thread. This is the
first step towards ensuring that we do not run the TplLogEventFilter
from a separate thread.
NB: This does not solve the actual problem. The TplLogEventFilter is
still invoked from a separate thread. However this refactoring lets us
move in that direction.
Fixes: https://bugs.freedesktop.org/54270
|
|
|
|
|
|
|
|
|
|
|
| |
This is Autoconf best-practice, and ensures that the GLib and Telepathy
version-selection macros defined by configure.ac work as intended.
Including config.h turns on ENABLE_DEBUG, which in turn leads to the
usage of _tpl_debug_set_flags_from_env. In those cases we should
include telepathy-logger/debug-internal.h also.
Fixes: https://bugs.freedesktop.org/59165
|
|
|
|
| |
We are using g_clear_object.
|
|\ |
|
| |
| |
| |
| | |
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| |
| |
| |
| | |
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| | |
|
| |
| |
| |
| | |
It is generated during the build.
|
| |
| |
| |
| |
| |
| | |
This is an ugly patch but it'll do for now.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| |
| |
| |
| | |
Fixes: https://bugs.freedesktop.org/53345
|
| | |
|
| |
| |
| |
| | |
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|\ \
| | |
| | |
| | | |
https://bugs.freedesktop.org/show_bug.cgi?id=55338
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
Given that _tpl_log_store_get_name exists, there's really no reason to
have a property as well.
|
| | |
| | |
| | |
| | |
| | |
| | | |
For all log stores except the Xml one, this is always set to the same
thing. For the Xml one, the name of the store depends entirely on the
value of empathy-legacy.
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
Again, it's meaningless to have this be a writeable construct-only
property—a store is either readable or it's not.
|
| | |
| | |
| | |
| | |
| | |
| | | |
This property was defined by the interface to be readwrite, but this
doesn't make any sense: if the object implements the add_event method,
then it is writable, and if not, it doesn't.
|
| | |
| | |
| | |
| | | |
:readable and :writable had their doc comments swapped.
|
|/ / |
|
| | |
|
| |
| |
| |
| | |
Fixes: https://bugs.freedesktop.org/41772
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
Fixes: https://bugs.freedesktop.org/41772
|
| |
| |
| |
| | |
It is generated during the build.
|
| |
| |
| |
| |
| |
| |
| | |
... to cover events coming from multiple stores spanning several days
where multiple events might have the same timestamp.
Fixes: https://bugs.freedesktop.org/41772
|
| |
| |
| |
| |
| |
| |
| | |
... to cover events coming from multiple stores spanning several days
where multiple events might have the same timestamp.
Fixes: https://bugs.freedesktop.org/41772
|
| |
| |
| |
| |
| |
| |
| | |
The actual test case will be added later. Existing test cases have
been adjusted accordingly.
Fixes: https://bugs.freedesktop.org/41772
|
| |
| |
| |
| |
| |
| | |
... to cover text events spanning multiple days.
Fixes: https://bugs.freedesktop.org/41772
|
| |
| |
| |
| |
| |
| | |
... to cover text events spanning multiple days.
Fixes: https://bugs.freedesktop.org/41772
|
| |
| |
| |
| |
| |
| |
| | |
... to cover text events spanning multiple days, and a mix of call and
text events.
Fixes: https://bugs.freedesktop.org/41772
|