diff options
| author | Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk> | 2011-01-03 20:33:20 +0000 |
|---|---|---|
| committer | Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk> | 2011-01-03 20:33:20 +0000 |
| commit | 92601850db0c69908be898df50350bf3167319c6 (patch) | |
| tree | 15f87e05d21b0609ca8254e35cff5c9f44cf26e3 | |
| parent | 45767c759cb8a86bdd17b6f297f33108ad1cac8c (diff) | |
| download | telepathy-logger-92601850db0c69908be898df50350bf3167319c6.tar.gz | |
Avoid freeing random memory
If the TplEntry isn't a TplEntryText, we jump to out and free date,
which is uninitialised, causing memory corruption.
==19750== Conditional jump or move depends on uninitialised value(s)
==19750== at 0x62BB792: g_free (gmem.c:262)
==19750== by 0x4E5005E: _insert_to_cache_table (log-store-sqlite.c:777)
==19750== by 0x4E4F8D2: tpl_log_store_sqlite_add_message_cache (log-store-sqlite.c:603)
==19750== by 0x4E4FABA: tpl_log_store_sqlite_add_message (log-store-sqlite.c:667)
==19750== by 0x4E49613: _tpl_log_store_add_message (log-store.c:162)
==19750== by 0x4E4586E: _tpl_log_manager_add_message (log-manager.c:301)
==19750== by 0x4E38307: log_call (channel-streamed-media.c:609)
==19750== by 0x4E37B57: pendingproc_log_call (channel-streamed-media.c:519)
==19750== by 0x4E35402: _tpl_action_chain_continue (action-chain.c:123)
==19750== by 0x4E37B29: pendingproc_connect_message_signals (channel-streamed-media.c:510)
==19750== by 0x4E35402: _tpl_action_chain_continue (action-chain.c:123)
==19750== by 0x4E37221: pendingproc_get_room_info (channel-streamed-media.c:317)
| -rw-r--r-- | telepathy-logger/log-store-sqlite.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/telepathy-logger/log-store-sqlite.c b/telepathy-logger/log-store-sqlite.c index 75a19ea..7d90796 100644 --- a/telepathy-logger/log-store-sqlite.c +++ b/telepathy-logger/log-store-sqlite.c @@ -689,7 +689,7 @@ _insert_to_cache_table (TplLogStore *self, TplLogStoreSqlitePrivate *priv = GET_PRIV (self); const char *account, *channel, *identifier, *log_id; gboolean chatroom; - char *date; + char *date = NULL; gint msg_id; sqlite3_stmt *sql = NULL; gboolean retval = FALSE; |