| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
| |
badness.
|
|
|
|
| |
just not move backward.
|
|
|
|
|
|
|
| |
this means that we don't go past the end of the captured data when
dumping raw packet data and that we distinguish between "this packet was
cut off by the snapshot length" and "this packet is continued in a
subsequent TCP segment".
|
|
|
|
| |
every iteration of a loop.
|
|
|
|
|
|
| |
status value as such.
Constify some tables.
|
|
|
|
| |
for counted strings, and use them where appropriate.
|
| |
|
|
|
|
|
|
| |
I've seen; get rid of it.
Do, however, show the byte count.
|
|
|
|
|
|
|
|
| |
boundary, and base the Unicode-vs-non-Unicode decision on the "strings
are Unicode" bit in Flags2, except for those few strings that are always
ASCII, rather than doing a heuristic check.
Fix the padding in FindFirst2 requests.
|
|
|
|
| |
indicates whether the offsets and lengths are 32 bit or 64 bit.
|
|
|
|
|
|
|
|
|
|
|
| |
In "print_smb()", Don't go past the passed-in length when printing the
word data.
The andX command is 1 byte, not 2 bytes.
Check that the andX offset is after the offset of the previous SMB
information, so we don't get caught in a loop if there's a bogus andX
offset.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
"print_smb()".
Don't print "smb_vwv[] =" - just print the "smb_vwv[i] =" for each of
the words in the word data if we're dumping it as raw data.
Only print "smb_buf[] =" if we're dumping the byte data as raw data.
Always print the byte count (except for Trans2, but we should probably
print it there as well).
|
|
|
|
|
|
| |
don't bother specifying big-endian for one-byte fields.
Show the length in all NBSS packets.
|
|
|
|
|
| |
The first byte of an NBT Session Service message is the message type -
the *second* byte is the flags.
|
|
|
|
|
|
|
|
|
| |
"smb_fdata()" string for non-verbose mode (all on one line), and an
"smb_fdata()" string for verbose mode. Add entries for a number of
additional commands.
Don't look for an SMB packet except in Datagram, Broadcast Datagram,
Data First/Middle, or Data Only/Last NBF packets.
|
|
|
|
|
|
|
|
|
|
| |
appropriately, and that GNUmakefile and the MSVC++ project file define
it apppriately, as we do with libpcap, rather than defining it in
"interface.h".
Undo the rcsid-shuffling and addition of extra #includes, as we no
longer need to arrange that "interface.h" be included before using _U_
in an RCS ID or copyright.
|
|
|
|
|
|
|
|
|
|
|
| |
use "_U_" in the definitions of "rcsid[]", to eliminate
complaints about those variables being unused;
move the definitions after the include of "interface.h", or add
an include of "interface.h", so that "_U_" is defined.
Include "config.h" before including "tcpdump-stdinc.h" in
"missing/datalinks.c".
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unused-parameter problems reported by GCC. Add an _U_ tag to label
parameters as unused if the function is called through a pointer (so
that you can't change its signature by removing parameters) or if there
are unused parameters only because the function isn't complete.
Add some additional bounds checks the necessity for which was revealed
while cleaning up unused-parameter problems.
Make some routines static.
"lcp_print()", defined in "print-lcp.c", isn't called anywhere -
"print-ppp.c" has the code to dissect LCP. Get rid of "print-lcp.c".
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
From Neil T. Spring: fixes for many of those warnings:
addrtoname.c, configure.in: Linux needs netinet/ether.h for
ether_ntohost
print-*.c: change char *foo = "bar" to const char *foo = "bar"
to appease -Wwrite-strings; should affect no run-time behavior.
print-*.c: make some variables unsigned.
print-bgp.c: plen ('prefix len') is unsigned, no reason to
validate by comparing to zero.
print-cnfp.c, print-rx.c: use intoa, provided by addrtoname,
instead of inet_ntoa.
print-domain.c: unsigned int l; (l=foo()) < 0 is guaranteed to
be false, so check for (u_int)-1, which represents failure,
explicitly.
print-isakmp.c: complete initialization of attrmap objects.
print-lwres.c: "if(x); print foo;" seemed much more likely to be
intended to be "if(x) { print foo; }".
print-smb.c: complete initialization of some structures.
In addition, add some fixes for the signed vs. unsigned comparison
warnings:
extract.h: cast the result of the byte-extraction-and-combining,
as, at least for the 16-bit version, C's integral promotions
will turn "u_int16_t" into "int" if there are other "int"s
nearby.
print-*.c: make some more variables unsigned, or add casts to an
unsigned type of signed values known not to be negative, or add
casts to "int" of unsigned values known to fit in an "int", and
make other changes needed to handle the aforementioned variables
now being unsigned.
print-isakmp.c: clean up the handling of error/status indicators
in notify messages.
print-ppp.c: get rid of a check that an unsigned quantity is >=
0.
print-radius.c: clean up some of the bounds checking.
print-smb.c: extract the word count into a "u_int" to avoid the
aforementioned problems with C's integral promotions.
print-snmp.c: change a check that an unsigned variable is >= 0
to a check that it's != 0.
Also, fix some formats to use "%u" rather than "%d" for unsigned
quantities.
|
| |
|
| |
|
|
|
|
| |
Packet".
|
|
|
|
|
|
|
|
| |
pointers from "char *" to "u_char *", to eliminate signed vs. unsigned
complaints from some compilers.
Don't use "++"s in initialization, to avoid warnings from the Sun C
compiler.
|
|
|
|
| |
"EXTRACT_16BITS()").
|
|
|
|
| |
a lot of boundary checking.
|
|
|
|
| |
no boundary check).
|
|
|
|
|
|
|
|
|
|
|
| |
Use const more.
Use EXTRACT_* macros more.
Use TCHECK* more.
Use tok2str() to replace some home-grown workalikes.
smb:
- Get rid of private types, use tcpdump-defined types
- Rename fdata and fdata1 to smb_fdata and smb_fdata1 to avoid conflict
with IRIX library function.
|
|
|
|
| |
1002 - Microsoft added them).
|
| |
|
|
|
|
| |
go through buffer length issues....
|
| |
|
|
|
|
| |
printf type mismatch, as well as buffer overrun possibilities
|
|
|
|
|
| |
couple of indent fixes (ts=8 sw=4) so that we can do
a buffer overrun audit effectively.
|
|
|
|
| |
Not-really-submitted by: archie@freebsd.org
|
|
|
|
|
| |
I changed his patches to actually use -vv. Obviously tcpdump actually
needs more-targeted -v flags (like "-v smb").
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(We call it "nwlink-dgm" for now; Ethereal calls it a NWLink SMB
datagram.)
Don't throw every LLC frame with unknown SAPs at the NetBIOS-over-IPX
dissector; just throw the frames for IPX sockets 0x455 and 0x553 at it,
as those appear to be the sockets used (if there are any others, please
add them to the IPX dissector - putting it back in the LLC dissector
won't help, as all IPX frames, including LLC frames, should now be
handed to the IPX dissector).
Do better bounds checking in "ipx_netbios_print()" and
"netbeui_print()", i.e. don't go past the end of the captured data in
the packet when looking for the 0xFF S M B signature.
|
|
|
|
|
|
|
|
|
|
|
|
| |
for an S or I frame; have the LLC dissector pass the control field value
as an argument to the NetBEUI dissector, rather than having the NetBEUI
dissector extract the control field value itself, and have it pass a
pointer to the beginning of the LLC *payload* rather than to the control
field.
Keep the NetBEUI dissector from running past the end of the buffer.
Add support for the NetBEUI SESSION ALIVE frame.
|
|
|
|
| |
packet.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
API.
* print-bgp.c: improve options printing. ugly code exists for
unaligned option parsing (need some fix).
* const poisoning in SMB decoder.
* make dump format back to original. someone may want to add an
option to do ascii printing, but keep the default behavior as is
for scripts used in many places.
* -Wall -Werror clean checks.
|
|
|
|
|
|
|
| |
remove unused variables
make a few functions static
fix very confused code with & vs. == precedence errors as well as
a failure to shift the field value
|
|
|