summaryrefslogtreecommitdiff
path: root/print-rx.c
Commit message (Collapse)AuthorAgeFilesLines
* u_intN_t is dead, long live uintN_t.Guy Harris2014-04-231-35/+35
| | | | | | | | | And, as we require at least autoconf 2.61, and as autoconf 2.61 and later have AC_TYPE_UINTn_T and AC_TYPE_INTn_T macros, we use them to define the uintN_t and intN_t macros if the system doesn't define them for us. This lets us get rid of bitypes.h as well.
* NDOize the rest of util.cDenis Ovsienko2014-04-141-4/+4
|
* fix a couple typosDenis Ovsienko2014-04-061-1/+1
|
* squelch compiler warnings after previous commitDenis Ovsienko2014-03-301-0/+1
| | | | | It was OK with GCC but Clang wants <stdlib.h> back because of malloc() and free() that shouldn't be declared implicitly.
* NDOize RX decoderDenis Ovsienko2014-03-301-462/+474
|
* refine the previous changeDenis Ovsienko2014-02-261-1/+1
| | | | | | | This time eliminate a few instances of the code initializing struct tok with negative values and squelch the warnings like below: warning: initializer will be sign-extended: -1
* remove tcpdump's own CVS keywordsDenis Ovsienko2014-01-031-5/+0
| | | | | | Remove lots of $Header's and a few $Id's that all belong to the former CVS repository of tcpdump itself. These keywords have been frozen since the migration to git in late 2008.
* Merge branch 'master' of git+ssh://bpf.tcpdump.org/tcpdump/master/git/tcpdumpMichael Richardson2014-01-011-2/+80
|\ | | | | | | | | Conflicts: enc.h
| * Pull a bunch of headers into the only source file that includes them.Guy Harris2013-12-301-2/+80
| | | | | | | | | | | | For headers included in only one source file, put the header contents in the source file in question, and get rid of a bunch of stuff from the header not used in the source file.
* | whitespace changesMichael Richardson2014-01-011-1/+1
|/
* make more array declarations static/constDenis Ovsienko2013-12-191-1/+1
|
* justify declarations of struct tok arraysDenis Ovsienko2013-09-241-13/+13
| | | | | | Make sure all of them are declared const and most of them -- static. Proper declaration of token arrays is a common review point for new code that is based on existing decoders. Thus fix the issue at its root.
* Fix off-by-one error in print-rx.cDenis Ovsienko2013-04-191-1/+1
| | | | | | | | Avoid dereferencing rx_cache[RX_CACHE_SIZE], which is one past the last valid element. (This fixes SF bug 3599633 / GH bug 287. I could not identify the name or email address of the original contributor. -- Denis)
* Fix use of PRIu64.guy2008-07-011-2/+2
|
* Use PRIu64 rather than %llu - %llu might be wrong, if u_int64_t is justguy2008-07-011-2/+2
| | | | "unsigned long int", or if this is Windows with Microsoft's C compiler.
* From Michael A. Meffie III:guy2008-05-121-12/+320
| | | | | | | Update decoding of rx packets used by AFS. Add missing RPC opcodes for fileserver, cache manager, volume server, and ubik (database elections). Add missing decoding of volume server RPC arguments and reply data.
* Pick up from NetBSD a change to use a maximum string length on the scanfguy2007-06-151-3/+6
| | | | format used to parse ACL entries.
* Extract "firstPacket" into a variable with EXTRACT_32BITS(), and useguy2006-04-071-10/+12
| | | | | that whenever we print its value, so that we always get it in the right byte order.
* Have the configure script arrange that the Makefile define _U_guy2003-11-161-4/+4
| | | | | | | | | | appropriately, and that GNUmakefile and the MSVC++ project file define it apppriately, as we do with libpcap, rather than defining it in "interface.h". Undo the rcsid-shuffling and addition of extra #includes, as we no longer need to arrange that "interface.h" be included before using _U_ in an RCS ID or copyright.
* From Neil Spring:guy2003-11-151-4/+4
| | | | | | | | | | | use "_U_" in the definitions of "rcsid[]", to eliminate complaints about those variables being unused; move the definitions after the include of "interface.h", or add an include of "interface.h", so that "_U_" is defined. Include "config.h" before including "tcpdump-stdinc.h" in "missing/datalinks.c".
* From an anonymous SourceForge user: get rid of "ack_print()" in favor ofguy2003-01-251-74/+3
| | | | "rx_ack_print()", and add a new ack reason "idle".
* Get rid of the "-Wno-unused" flag, and fix up most of theguy2002-09-051-10/+9
| | | | | | | | | | | | | | | unused-parameter problems reported by GCC. Add an _U_ tag to label parameters as unused if the function is called through a pointer (so that you can't change its signature by removing parameters) or if there are unused parameters only because the function isn't complete. Add some additional bounds checks the necessity for which was revealed while cleaning up unused-parameter problems. Make some routines static. "lcp_print()", defined in "print-lcp.c", isn't called anywhere - "print-ppp.c" has the code to dissect LCP. Get rid of "print-lcp.c".
* Add a few more GCC warnings on GCC >= 2 for ".devel" builds.guy2002-09-051-31/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | From Neil T. Spring: fixes for many of those warnings: addrtoname.c, configure.in: Linux needs netinet/ether.h for ether_ntohost print-*.c: change char *foo = "bar" to const char *foo = "bar" to appease -Wwrite-strings; should affect no run-time behavior. print-*.c: make some variables unsigned. print-bgp.c: plen ('prefix len') is unsigned, no reason to validate by comparing to zero. print-cnfp.c, print-rx.c: use intoa, provided by addrtoname, instead of inet_ntoa. print-domain.c: unsigned int l; (l=foo()) < 0 is guaranteed to be false, so check for (u_int)-1, which represents failure, explicitly. print-isakmp.c: complete initialization of attrmap objects. print-lwres.c: "if(x); print foo;" seemed much more likely to be intended to be "if(x) { print foo; }". print-smb.c: complete initialization of some structures. In addition, add some fixes for the signed vs. unsigned comparison warnings: extract.h: cast the result of the byte-extraction-and-combining, as, at least for the 16-bit version, C's integral promotions will turn "u_int16_t" into "int" if there are other "int"s nearby. print-*.c: make some more variables unsigned, or add casts to an unsigned type of signed values known not to be negative, or add casts to "int" of unsigned values known to fit in an "int", and make other changes needed to handle the aforementioned variables now being unsigned. print-isakmp.c: clean up the handling of error/status indicators in notify messages. print-ppp.c: get rid of a check that an unsigned quantity is >= 0. print-radius.c: clean up some of the bounds checking. print-smb.c: extract the word count into a "u_int" to avoid the aforementioned problems with C's integral promotions. print-snmp.c: change a check that an unsigned variable is >= 0 to a check that it's != 0. Also, fix some formats to use "%u" rather than "%d" for unsigned quantities.
* Get rid of some unnecessary includes (<time.h>, <netdb.h>, and <ctype.h>guy2002-08-061-4/+1
| | | | | are included by <tcpdump-stdinc.h>, so we don't have to include them explicitly; <errno.h> isn't needed by print routines).
* Added support for Win32, based on WinPcap.risso2002-08-011-7/+2
|
* whitespace cleanupitojun2002-06-111-37/+37
|
* Squelch some compiler warnings caused by passing "char *"s rather thanguy2002-04-301-6/+6
| | | | "unsigned char *"s to "fn_print()".
* Protect includes of <time.h> with "#ifdef TIME_WITH_SYS_TIME".guy2002-04-201-1/+3
|
* copyright clarification.itojun2001-10-201-2/+23
|
* Updates to RX support, from Nickolai Zeldovich <kolya@MIT.EDU>.guy2001-09-091-8/+25
|
* VECOUT() lacked proper boundary checks.itojun2001-07-091-9/+8
| | | | old code should have been okay as MAX < sizeof(s), but we need to be cautious.
* -Wunused pedantitojun2001-07-091-5/+1
|
* Don't allow STROUT() to use a negative string length.fenner2001-07-091-10/+18
| | | | Use fn_print() and fn_printn() to print strings from the packet.
* No, we didn't need to include "nameser.h" here, so remove the #include.guy2001-06-271-5/+1
|
* Move all the "undefine so that the compiler doesn't whine aboutguy2001-06-261-3/+4
| | | | | | | | | | | | | redefinitions" stuff from files that include "nameser.h" to "nameser.h" itself (we used to include <arpa/nameser.h>, over which we had no control so we couldn't do that, but we now have our own "nameser.h"). Add T_OPT to the list of things we undefine, and undefine T_UNSPEC iff T_UNSPEC is defined, not iff NOERROR is defined. Replace the include of <arpa/nameser.h> in "print-rx.c" with an include of "nameser.h", and "#if 0" it out pending a determination of whether it's necessary (why would AFS's RX care about the internals of DNS packets?) or not.
* Fix a minor buffer bounds problem: if the length of an ACL is greaterfenner2001-01-101-5/+7
| | | | | | than AFSOPAQUEMAX, a NUL could be written out of bounds of the storage for the ACL. This is almost definitely unexploitable, since no network-supplied data is written (only a NUL).
* some sprintf fixes, from kris@freebsd.org (patches@tcpdump.org #89)itojun2000-10-051-12/+20
| | | | pedant.
* Get rid of includes of <netinet/in_systm.h>, and replace "n_short",guy2000-09-291-2/+1
| | | | "n_long", and "n_time", defined in that file, with other types.
* Define some functions as "static", to match the declarations of thoseguy2000-09-241-4/+4
| | | | functions as static earlier in the file; some compilers warn about that.
* Add an "ip.h" header, to declare the IP stuff needed by dissectors, andguy2000-09-231-2/+3
| | | | | | | | | | | have dissectors include them rather than <netinet/ip.h> or <netinet/ip_var.h>, if they actually need that stuff. Put the declarations of the ICMP stuff directly into "print-icmp.c". Remove all unnecessary includes of <netinet/ip*.h> files. Copy the byte-order stuff from "nameser.h" into "tcp.h".
* replace non-existing TRUNC with standard TCHECK2assar2000-07-291-14/+14
|
* print the RX ack packetsassar2000-07-291-2/+74
|
* use standard TCHECK2 instead of the home-cooked TRUNC, therebyassar2000-07-221-46/+45
| | | | avoiding off-by-one error
* add <time.h>assar2000-07-101-1/+2
|
* Make the handling of the -v flag a little more sensible, and document it.kenh2000-02-101-14/+21
|
* Fix a minor bug in the ack packet printing.kenh2000-02-091-4/+6
|
* Clean up some warnings.kenh2000-02-091-4/+4
|
* Convert from direct use of ntohs/ntohl to EXTRACT_16BITS/EXTRACT_32BITS.kenh2000-02-081-60/+280
| | | | Add support for decoding RX ack packets.
* Unify rcsid[]'s.fenner2000-01-091-1/+1
|
* (fs_reply_print): support parsing and printing of the errors in abortassar2000-01-071-8/+32
| | | | packets in symbolic form. From Love <lha@stacken.kth.se>
View Lorry Controller Status