| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
The function body should have its opening brace on the next line.
|
|
|
|
|
|
|
|
|
| |
And, as we require at least autoconf 2.61, and as autoconf 2.61 and
later have AC_TYPE_UINTn_T and AC_TYPE_INTn_T macros, we use them to
define the uintN_t and intN_t macros if the system doesn't define them
for us.
This lets us get rid of bitypes.h as well.
|
|
|
|
|
|
|
|
| |
Have them take a netdissect_options * argument, and get the "no name
resolution" flag from it.
Move the declaration of dnaddr_string to addrtoname.h, along with the
other XXX-to-string routines.
|
| |
|
| |
|
|
|
|
|
|
| |
Remove lots of $Header's and a few $Id's that all belong to the former
CVS repository of tcpdump itself. These keywords have been frozen since
the migration to git in late 2008.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
For each decoder that has more than one instance of truncation signaling
and prints the same string in each instance make sure that the string is
declared as "static const char tstr[]" right after the initial includes
block. Where necessary, replace fputs(s, stdout) with equivalent
printf("%s", s).
|
|
|
|
|
|
| |
Make sure all of them are declared const and most of them -- static.
Proper declaration of token arrays is a common review point for new code
that is based on existing decoders. Thus fix the issue at its root.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Based on a patch from cr4ckn@sourceforge.net, but with a macro
PLURAL_SUFFIX() defined to return either "s" or "" (rather than possibly
printing a NUL character with %c), and with that macro used in a couple
of cases where the equivalent had been done by hand, and with one case
the patch missed fixed as well.
|
|
|
|
|
|
|
|
| |
Use the EXTRACT_ macros to extract multi-byte integral values from
packets, rather than just dereferencing pointers into the packet; there
is no guarantee that the packet data will be aligned on the right
boundary, and there is no guarantee that, if they're not, a direct
access will work correctly.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
add support for OSPF Link-Local Signaling (RFC 4811/4812/4813);
when printing the Database Description, show the MTU and
sequence number;
fix "bogus length" messages when printing LSA headers.
|
| |
|
|
|
|
| |
use safeputs to print the password.
|
|
|
|
| |
-misc. cosmetic cleanups
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with a maximum length, where a string shorter than that length is padded
with NULs), as "fn_print()" won't handle the maximum length *and* the
snapshot length and "fn_printn()" won't stop on a null string. Use it
where appropriate.
Always pass "snapend" to "fn_print()" and "fn_printn()" if they're
passed a pointer into the packet data; only pass NULL if they're being
handed a pointer into a buffer that's not part of the packet data.
Always check the return value of "fn_print()", "fn_printn()", and
"fn_printzp()" if they're passed "snapend", and do the appropriate
string termination and "packet truncated" indication if they return 1.
|
| |
|
|
|
|
|
|
|
|
| |
- consistent use of length field (not payload-len)
- no message type number given in PIM/OSPF printers
as those changes affect only verbose mode and/or
routing protocols we hope not to break existing scripts;
|
| |
|
|
|
|
| |
Capabilities TLV as per draft-ietf-ospf-cap-03
|
|
|
|
| |
BC models
|
| |
|
|
|
|
| |
Add a length check.
|
| |
|
| |
|
|
|
|
|
| |
processing the TLV - there might not be any TLVs. Instead, check before
fetching the type.
|
|
|
|
|
|
|
|
|
|
| |
appropriately, and that GNUmakefile and the MSVC++ project file define
it apppriately, as we do with libpcap, rather than defining it in
"interface.h".
Undo the rcsid-shuffling and addition of extra #includes, as we no
longer need to arrange that "interface.h" be included before using _U_
in an RCS ID or copyright.
|
|
|
|
|
|
|
|
|
|
|
| |
use "_U_" in the definitions of "rcsid[]", to eliminate
complaints about those variables being unused;
move the definitions after the include of "interface.h", or add
an include of "interface.h", so that "_U_" is defined.
Include "config.h" before including "tcpdump-stdinc.h" in
"missing/datalinks.c".
|
|
|
|
| |
Add some length checks.
|
|
|
|
|
|
|
| |
u_int32_t ls_type becomes
u_int8_t ls_type[4];
- teach the LS-Request decoder howto properly print Opaque LSAs
|
| |
|
|
|
|
|
|
|
|
| |
-that fixes the LSA-ACK printing of Opaque LSAs
bugreport courtesy Carles Kishimoto Bisbe ckishimo [AT] ac [DOT] upc [DOT] es
- make use of ospf_print_lshdr() inside ospf_print_lsa()
- shared link risk group decoder from Carles Kishimoto Bisbe ckishimo [AT] ac [DOT] upc [DOT] es
- print IP adresses for LINK_IDs
|
|
|
|
|
|
|
| |
[DOT] upc [DOT] es
-parse TE-TLVs until the ls_length field is zero
-print router-ID TLV
|
|
|
|
|
|
| |
courtesy Neil Spring nspring [AT] cs [DOT] washington [DOT] edu
- add support for the Traffic Engineering TLV plus all known subTLVs
- add support for draft-ietf-ccamp-ospf-gmpls-extensions defined subTLVs
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
compile with Sun C, as "interface.h" isn't being included before the
structures are being declared.
Furthermore, in the files that Sun C *can* compile, it doesn't cause Sun
C to generate code that's safe with unaligned accesses, as
"__attribute__" is defined as a do-nothing macro with compilers that
don't support it.
Therefore, we get rid of that tag on the structures to which it was
added, and instead use "EXTRACT_16BIT()" and "EXTRACT_32BIT()" to fetch
16-bit and 32-bit big-endian quantities from packets. We also fix some
other references to multi-byte quantities to get rid of code that tries
to do unaligned loads on platforms that don't support them.
We also throw in a hack that makes those macros use
"__attribute__((packed))" on structures containing only one 16-bit or
32-bit integer to get the compiler to generate unaligned-safe code
rather than doing it by hand. (GCC on SPARC produces the same code that
doing it by hand does; I don't know if GCC on any other big-endian
strict-alignment processor generates better code for that case. On
little-endian processors, as "ntohs()" and "ntohl()" might be functions,
that might actually produce worse code.)
Fix some places to use "%u" rather than "%d" to print unsigned
quantities.
|
|
|
|
|
|
| |
it to "u_int32_t" when printing with "%[duox]".
Print unsigned quantities with "%u", not "%d".
|
|
|
|
|
|
|
|
|
| |
- get rid of lots of private tok2string() lookalikes
- changed output formatting to idented multiline output (-v option)
- added defs for opaque, NSSA LSAs
- completed option byte processing
more changes to come;
|
| |
|
|
|
|
| |
Remove extra space before "OSPF".
|