summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Don't check for libcrypto if we don't have openssl/crypto.h.tcpdump-4.7Guy Harris2017-05-143-4/+39
| | | | | | Thanks, Apple, for making us do this (and for making tcpdump unable to do some decryption without either installing OpenSSL or working on trying to do the decryption with Apple's frameworks).
* Fix the pcap version in tests/cve2015-0261-crash.pcapFrancois-Xavier Le Bail2015-11-191-0/+0
| | | | | It will be always usable with the upcoming libpcap versions sanity checks. (old version: 12336.12336, new version: 2.4)
* RSVP: Add some bounds checksFrancois-Xavier Le Bail2015-11-191-3/+18
| | | | | Moreover: Add and use tstr[] string.
* ISOCLNS: Fix a segmentation faultFrancois-Xavier Le Bail2015-11-191-19/+23
| | | | | Moreover: Avoid two consecutive truncation messages.
* ISOCLNS: Fix two segmentation faultsFrancois-Xavier Le Bail2015-11-192-35/+46
| | | | | | | | Moreover: Add/fix a lot of bounds and length checks. Add and use tstr[] string. Fix some typos. Update the output of a test according to these changes.
* ISOCLNS: Fix some warningsFrancois-Xavier Le Bail2015-11-191-5/+6
| | | | | | | | | | | The warnings were: ./print-isoclns.c: In function 'osi_print_cksum': ./print-isoclns.c:3107:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] || length > ndo->ndo_snaplen ^ ./print-isoclns.c:3108:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] || checksum_offset > ndo->ndo_snaplen ^
* RSVP: Fix an infinite loopFrancois-Xavier Le Bail2015-11-191-0/+8
|
* DTP: improve packet integrity checksDenis Ovsienko2015-11-191-8/+20
| | | | | | | | | Adjust the TLV infinite loop check to require the right amount of bytes for T and L; do it after printing the TLV header so it is easier to understand what was wrong. Check if the TLV V is within the capture. Use the new "invalid" exit label to indicate a packet anomaly and add more checks for the length value into the type-specific case blocks. Print the domain string with fn_printzp().
* netdissect.h: Update ND_TTEST2 to fix issue 443Francois-Xavier Le Bail2015-11-191-1/+4
| | | | | | | Add IS_NOT_NEGATIVE macro. Avoid these warnings: - comparison of unsigned expression >= 0 is always true [-Wtype-limits], - comparison is always true due to limited range of data type [-Wtype-limits].
* The official #define for 32-bit and 64-bit Windows is _WIN32.Guy Harris2015-09-024-54/+54
| | | | | | | | | | | | | It's _WIN32, with a leading underscore, not WIN32. See, for example: https://sourceforge.net/p/predef/wiki/OperatingSystems/ and https://msdn.microsoft.com/en-us/library/b0084kay.aspx *Some* environments may also define WIN32, but we shouldn't depend on that.
* For -L, print the DLTs in order, not reverse order.Guy Harris2015-09-021-7/+7
| | | | Reverse order puts the default DLT last, which is a bit weird.
* Reflect the addition of a space before "(unverified)".Guy Harris2015-09-021-1/+1
|
* Add a missing space to a printout.Guy Harris2015-09-021-1/+1
|
* Give more details about packet time stamps.Guy Harris2015-09-021-5/+9
| | | | | | | | | | | | | Don't speak of "Ethernet" and "wire", as you might not be sniffing an Ethernet or, indeed, any form of wired network. Note that not only could there be a delay between the point at which the interface is finished receiving the packet and when an interrupt is delivered (whether due to bus delays, polling rather than immediate interrupts being used, or delays in the CPU responding to the interrupt, or more than one of those) but also a delay between the point at which the kernel responds to the interrupt and the point at which it actually applies a time stamp to the packet.
* Don't assume the ONC RPC header is nicely aligned.Guy Harris2015-08-251-1/+2
| | | | | | | Use UNALIGNED_MEMCPY() to extract the XID from it; otherwise, this might crash on machines that require strict alignment (e.g., SPARC machines). Fixes GitHub issue #478.
* Fix display of timestamps with -ttt and -ttttt optionsFrancois-Xavier Le Bail2015-07-024-22/+114
| | | | | | | | - Fix display of some nanoseconds timestamps For example, bad print 00:-16:-2.000851566 is now 00:00:00.037851566 - Fix display of timestamp of a packet when it is lower than previous one For example, bad print 00:00:-1.000999790 is now -00:00:00.000000210
* Fix display of nanoseconds timestamps with -tt option (GH issue 466)Francois-Xavier Le Bail2015-06-301-3/+39
| | | | Add 'ts_unix_format' function.
* Fix a non-reentrant code in a functionFrancois-Xavier Le Bail2015-06-301-8/+14
| | | | | | | | Delete the 'static char buf' array in ts_format(). buf is now a parameter of ts_format(). Moreover: Decrease a too long string. Fix a space in a comment.
* SFLOW: Fix bounds checkingFrancois-Xavier Le Bail2015-05-081-3/+52
|
* RPL: Fix suboption printFrancois-Xavier Le Bail2015-05-061-1/+1
|
* Fix heuristic not to be byte-order-dependent.Guy Harris2015-05-031-1/+1
| | | | | | | | | | I'm *guessing* that the item being fetched is big-endian; the "vt" protocol might be old enough that they developed it on (non-Sun386i) Sun workstations, assuming they didn't just say "this is an Internet protocol, hence fields are big-endian"). That also prevents problems on platforms that don't support unaligned accesses.
* Fetch a 32-bit big-endian quantity with EXTRACT_32BITS().Guy Harris2015-05-031-1/+1
| | | | | | *Don't* fetch it with a pointer cast and dereference! That will fail on little-endian machines and may fail on machines that don't handle unaligned references.
* Print the formatted IP address, not the raw binary address, as a string.Guy Harris2015-05-031-3/+3
|
* Source and destination addresses were backwards.Guy Harris2015-05-031-1/+1
|
* Don't do IPv6 stuff if INET6 isn't defined.Guy Harris2015-05-031-0/+2
|
* Fix checksumming of PIMv2 Register messages.Guy Harris2015-05-034-12/+75
| | | | | | | The checksum only covers the header, not the encapsulated packet, so only checksum that. However, if that checksum fails, try checksumming the entire packet, as, according to RFC 4601, packets with the entire packet checksummed should also be accepted, for interoperability.
* Use unsigned values in tok2str and bittok2str routines.Guy Harris2015-04-182-14/+13
| | | | | | | | | | This prevents the compiler issue mentioned in GitHub issue #451, and also cleans up some other signed vs. unsigned stuff. While we're at it, clean up bittok2str_internal() (just pass it the separator string, not a Boolean value that's tested to choose the separator string), and print unknown arguments to the bittok2str routines in hex, not decimal.
* Not all C compilers accept C++/C99 comments by default.Guy Harris2015-04-141-3/+7
| | | | Use "#if 0" instead to comment out code.
* Update version.Guy Harris2015-04-101-1/+1
|
* Fix dates.Guy Harris2015-04-101-3/+3
|
* Add information for 4.7.4 release.Guy Harris2015-04-101-0/+6
|
* Clean up CREDITS file.Guy Harris2015-04-101-3/+7
|
* We're not copying the string to buf, so print the string, not buf.Guy Harris2015-04-093-4/+3
| | | | Get rid of the now-unused buf array while we're at it.
* Print strings with fn_printn().Guy Harris2015-04-092-12/+3
| | | | That filters out non-printable characters.
* RPKI to Router Protocol: Fix Segmentation Faults and other problemsFrancois-Xavier Le Bail2015-04-097-15/+130
| | | | | | -Fix/add ND_TCHECK2 tests, -Fix a buffer overflow, -Remove a debug printf
* whiteboard: fixup a few reversed tests (GH #446)Denis Ovsienko2015-03-261-3/+3
| | | | This is a follow-up to commit 3a3ec26.
* Clean up Capsicum rights setting a bit.Guy Harris2015-03-101-4/+5
| | | | | | | | Rename set_dump_fd_capsicum_rights() to set_dumper_capsicum_rights() and have it take a pcap_dumper_t * as an argument and extract the file descriptor itself, rather than having the caller do so. This fixes a syntax error in one of the calls.
* Get rid of unused variable.Guy Harris2015-03-101-3/+0
|
* Merge remote-tracking branch 'origin/tcpdump_4_7_cve' into tcpdump-4.7tcpdump-4.7.2Michael Richardson2015-03-092-7/+17
|\
| * protected osi_print_cksum is more general fashionMichael Richardson2015-03-091-6/+9
| |
| * annotate kday packets with CVE numbersMichael Richardson2015-03-091-1/+8
| |
* | Merge remote-tracking branch 'origin/tcpdump_4_7_cve' into tcpdump-4.7Michael Richardson2015-03-09114-1618/+3532
|\ \ | |/
| * update cve-2015-0261 test packets with expected outputMichael Richardson2015-03-092-0/+3
| |
| * update kday test packets with expected outputMichael Richardson2015-03-098-0/+624
| |
| * make sure that EXIT code is appended to results fileMichael Richardson2015-03-091-1/+1
| |
| * ND_TEST2 should validate that l is non-negativeMichael Richardson2015-03-091-1/+2
| |
| * added notes about CVEs that were fixedMichael Richardson2015-03-091-1/+4
| |
| * some patches to deal with kday pcap filesMichael Richardson2015-03-0910-288/+26
| |
| * enumerate F_OP values explicitely, provide reference to where they are defined.Michael Richardson2015-03-091-17/+21
| | | | | | | | guard against case where ops->print is nil
| * test case for cve2015-0261 -- corrupted IPv6 mobility headerMichael Richardson2015-03-096-2/+27
| |