| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| | |
This is a side trip of GH #418.
|
| |
| |
| |
| |
| |
| |
| | |
Allow an extra byte in the buffer for snprintf()'s null character,
otherwise it does not work as intended (issue spotted by Gisle Vanem on
Windows, where snprintf() behaviour seems to be different). Update the
tests.
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
When compiled with Capsicum, tcpdump -E 'file filename' fails to read
the secret from the file with the "Not permitted in capability mode"
error and exits with code 3. Skip respective tests until this logic is
handled in a better way.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Commit 05d7191 fixed detection of Capsicum availability and the
Capsicum-specific code in tcpdump made it into the compilation process
on respective FreeBSD systems. However, it would fail to compile at
least on FreeBSD 10.1-RELEASE as quoted below. This commit fixes it.
In file included from ./tcpdump.c:89:
/usr/include/net/bpf.h:65:8: error: redefinition of 'bpf_program'
struct bpf_program {
^
../libpcap/pcap/bpf.h:106:8: note: previous definition is here
struct bpf_program {
^
In file included from ./tcpdump.c:89:
/usr/include/net/bpf.h:1206:8: error: redefinition of 'bpf_insn'
struct bpf_insn {
^
../libpcap/pcap/bpf.h:1466:8: note: previous definition is here
struct bpf_insn {
^
2 errors generated.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The cross target is probably some flavor of Linux (this includes
Android) or *BSD (or maybe iOS if you're building for a jailbroken
system), and those should have non-buggy getaddrinfo().
If somebody's cross-compiling for a target with a buggy getaddrinfo(),
and tcpdump incorrectly converting IPv6 addresses to host names causes
the universe to collapse into a giant black hole or something equally
horrible, too bad.
Expand a comment while we're at it.
|
| | |
|
| |
| |
| |
| |
| | |
It's a macro, wrapping another function, in at least some versions of
FreeBSD, and AC_CHECK_FUNCS() doesn't handle that.
|
| |
| |
| |
| |
| | |
Fix link-layer header length for Cisco-style encapsulation while we're
at it.
|
| | |
|
| |
| |
| |
| |
| |
| | |
Check for the ICMP types that *do* include an IP packet, rather than
checking for a set that doesn't. This does a better job of handling
unknown ICMP types.
|
| | |
|
| |
| |
| |
| | |
Also, clean up the message printed when it's 6.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Check only the amount of length that matters at any given point; yes,
this means we do multiple checks, but so it goes.
We don't need to check for LLC+SNAP - llc_print() does that for us. We
do, however, need to check to make sure we can safely skip the Fore
header.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Check both the captured length and the on-the-wire length (the latter
*should* be greater than or equal to the former, but that's not
guaranteed).
Add some additional length checks, so neither caplen nor length
underflow.
If we stop dissecting because the packet is too short, return 1, not 0,
as we've "dissected" what we can; 0 means "this is LLC+SNAP with an OUI
of 0 and an unknown Ethertype".
|
| | |
|
| |
| |
| |
| |
| | |
While we're at it, use ND_TCHECK(), rather than a hand-rolled check, to
check whether we have the full fixed-length portion of the IPv4 header.
|
| |
| |
| |
| |
| |
| | |
add date command
add quiet option for apt-get
change Coverity token
|
| | |
|
| |
| |
| |
| | |
Acked-by: Jamal Hadi Salim
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Introduce a new function that tries to dispatch an OFPT_VENDOR message
to a vendor-specific printer function. Add such a function for Big
Switch Networks vendor with about as little decoding as necessary to
cover the existing 7050Q OF1.0 capture.
|
| |
| |
| |
| |
| |
| |
| |
| | |
The new function goes into print-openflow.c as vendor name decoding is
the same in all versions of OpenFlow (although in 1.0 it is "vendor"
and in subsequent versions it is "experimenter"). The mapping is from:
https://rs.opennetworking.org/wiki/display/PUBLIC/ONF+Registry
|
| | |
|
| |
| |
| |
| |
| | |
Add a bounds check
Fix spaces
|
| |
| |
| |
| |
| |
| |
| | |
The bounds check is already done before by ND_TCHECK2(*msg_data, addr_size +
name_entry_len + name_entry_padding).
So we are deliberately ignoring the return values of fn_printn with last
argument NULL (no bounds check).
|
| |
| |
| |
| |
| |
| | |
The bounds check is already done before by ND_TCHECK2(*tptr, len).
So we are deliberately ignoring the return values of fn_printn with last
argument NULL (no bounds check).
|
| | |
|
| | |
|
| |\ |
|
| | | |
|
| | | |
|
| | | |
|
| |\ \
| | |/ |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
- print missing protocol name
- print parentheses around generic header values in verbose mode
- fix indentation
|
| | | |
|
| |\ \
| | |/ |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
Currently, TESTonce uses 'diff -w' so it ignores all white space.
We need a strict comparison, else there is no difference between, for example,
'Association Setup' and 'AssociationSetup' => removing the option '-w'
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| |/ / |
|
| | | |
|