diff options
| author | Jim Meyering <meyering@fb.com> | 2018-03-18 21:32:19 -0700 |
|---|---|---|
| committer | Sergey Poznyakoff <gray@gnu.org> | 2018-04-07 10:38:31 +0300 |
| commit | 0a0242582f134c9994bbad77a57f64d388cf9e19 (patch) | |
| tree | 0bd90dfe64cd316cdf7bbd13d29a4994740c5d65 | |
| parent | 2baa531ce53d5876d34f941a97b5041573da453a (diff) | |
| download | tar-0a0242582f134c9994bbad77a57f64d388cf9e19.tar.gz | |
maint: avoid -Wstringop-truncation warnings from upcoming GCC8
* src/create.c (start_private_header, start_header): Convert
trivial uses of strncpy to memcpy, to avoid warnings like this:
In function 'strncpy',
inlined from 'start_private_header' at create.c:522:3:
/usr/include/bits/string_fortified.h:106:10: warning: \
'__builtin_strncpy' output truncated before terminating nul \
copying 2 bytes from a string of the same length \
[-Wstringop-truncation]
| -rw-r--r-- | src/create.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/create.c b/src/create.c index 35bcf5b0..7737c524 100644 --- a/src/create.c +++ b/src/create.c @@ -518,8 +518,8 @@ start_private_header (const char *name, size_t size, time_t t) MODE_TO_CHARS (S_IFREG|S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH, header->header.mode); UID_TO_CHARS (0, header->header.uid); GID_TO_CHARS (0, header->header.gid); - strncpy (header->header.magic, TMAGIC, TMAGLEN); - strncpy (header->header.version, TVERSION, TVERSLEN); + memcpy (header->header.magic, TMAGIC, TMAGLEN); + memcpy (header->header.version, TVERSION, TVERSLEN); return header; } @@ -917,8 +917,8 @@ start_header (struct tar_stat_info *st) case POSIX_FORMAT: case USTAR_FORMAT: - strncpy (header->header.magic, TMAGIC, TMAGLEN); - strncpy (header->header.version, TVERSION, TVERSLEN); + memcpy (header->header.magic, TMAGIC, TMAGLEN); + memcpy (header->header.version, TVERSION, TVERSLEN); break; default: |