summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* tree-wide: drop license boilerplateZbigniew Jędrzejewski-Szmek2018-04-061463-19044/+24
| | | | | | | | | | Files which are installed as-is (any .service and other unit files, .conf files, .policy files, etc), are left as is. My assumption is that SPDX identifiers are not yet that well known, so it's better to retain the extended header to avoid any doubt. I also kept any copyright lines. We can probably remove them, but it'd nice to obtain explicit acks from all involved authors before doing that.
* fuzz-unit-file: allow a space between variable name and "=" (#8670)Zbigniew Jędrzejewski-Szmek2018-04-061-1/+1
| | | | | The parser allows that, so the check when to skip needs this too. https://oss-fuzz.com/v2/issue/5106486364602368/7422
* Merge pull request #8663 from poettering/dissect-tightenZbigniew Jędrzejewski-Szmek2018-04-062-3/+31
|\ | | | | Small fixes for image dissection code.
| * dissect: when pulling metadata from an image, don't bother with /home or ESPLennart Poettering2018-04-051-2/+4
| | | | | | | | | | | | | | | | When we try to read meta-data from an image, don't bother with mounting /home or the ESP, as that's not where the metadata is. This not only speeds things up a bit, but also has the benefit that setups where an unencrypted root is mixed with an encrypted /home (which I have on one of my own systems) won't result in errors that the crypto key is needed.
| * update TODOLennart Poettering2018-04-051-0/+3
| |
| * dissect: tighten block device checks a bitLennart Poettering2018-04-051-1/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This extends on #8609, and makes two changes: 1. We'll now explicitly check that the child devices of a block device we are interested in (i.e. the partitions) are block devices themselves. On newer kernels the mmc rpmb stuff is actually exposed as char rather than block device as before, and they probably should have been that in the first place. By adding this check we'll hence filter out these weird devices through a second rule too, that hopefully makes things a bit more future-proof, should more devices like this be added eventually, or other subsystems do a similar thing. 2. When counting partitions we'll now also check the devnum of the device being non-null, which we already do when matching up the devices in the second iteration. This should make things more robust, and prevent other kinds of miscounting, which after all was the main issue #8609 fixed.
* | core/device: remove unnecessary check (#8661)Yu Watanabe2018-04-061-4/+1
| | | | | | Follow-up for 0dfb0a0abd98f8726a39f26e4d737f47ec0fd53b.
* | nspawn: wait for network namespace creation before interface setup (#8633)Philip Sequeira2018-04-051-4/+15
| | | | | | | | | | | | | | | | | | | | Otherwise, network interfaces can be "moved" into the container's namespace while it's still the same as the host namespace, in which case e.g. host0 for a veth ends up on the host side instead of inside the container. Regression introduced in 0441378080489e4ab6704cd0a2d78cb1ceaca899. Fixes #8599.
* | Merge pull request #8662 from poettering/rfkill-enxioZbigniew Jędrzejewski-Szmek2018-04-051-8/+9
|\ \ | | | | | | handle ENODEV and ENXIO gracefully in rfkill
| * | rfkill: treat ENXIO/ENODEV the same way as ENOENTLennart Poettering2018-04-051-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If an rfkill device disappears between the time we get notified about the existance and we fully opened it we might get ENXIO or ENODEV (i.e. the two kinds of "device not found" errors, which are typically generated when for example a device node has no actual backing device behind it). let's handle that the same way as ENOENT, and downgrade the log message to LOG_DEBUG. Fixes: #8586
| * | rfkill: use our usual style for writing destructorsLennart Poettering2018-04-051-4/+4
| |/ | | | | | | Let's accept NULL values gracefully, and let's return NULL.
* | journald: bump rate limits (#8660)David Tardon2018-04-053-3/+3
|/ | | | Apparently, it is quite common to hit a problem, where systemd-journald would drop messages because service is logging too fast.
* Merge pull request #8617 from keszybz/tmpfiles-relaxLennart Poettering2018-04-055-16/+24
|\ | | | | Do not exit with error when systemd-tmpfiles --boot fails
| * tmpfiles: ignore "operational" errors during setupZbigniew Jędrzejewski-Szmek2018-04-052-2/+2
| | | | | | | | | | | | | | | | | | | | We still get the errors logged, but we don't fail the service. This is better for users because rerunning tmpfiles-setup.service a second time is dangerous (c.f. cd9f5b68ce08375eb1d68a4ddaa7a24a5092d7ba). Note that this only touches sd-tmpfiles-setup.service and sd-tmpfiles-setup-dev.service. sd-tmpfiles-clean.service is as before. https://bugzilla.redhat.com/show_bug.cgi?id=1539341
| * tmpfiles: add a new return code for "operational failure" when processingZbigniew Jędrzejewski-Szmek2018-04-053-14/+22
| | | | | | | | | | | | | | | | Things can fail, and we have no control over it: - file system issues (immutable bits, file system errors, MAC refusals, etc) - kernel refusing certain arguments when writing to /proc/sys or /sys Let's add a new code for the case where we parsed configuration but failed to execute it because of external errors.
* | Merge pull request #8656 from yuwata/random-fixesLennart Poettering2018-04-05139-744/+389
|\ \ | | | | | | use TAKE_PTR() and TAKE_FD() macros, and small fixes
| * | core/device: trivial simplificationYu Watanabe2018-04-051-4/+2
| | |
| * | tree-wide: use TAKE_PTR() and TAKE_FD() macrosYu Watanabe2018-04-05136-736/+383
| | |
| * | network: fix typo in log messageYu Watanabe2018-04-051-1/+1
| | |
| * | meson: sort source filesYu Watanabe2018-04-051-2/+2
| | |
| * | bus-util: fix a meaningless assertionYu Watanabe2018-04-051-1/+1
|/ /
* | Merge pull request #8605 from poettering/drop-in-name-fixZbigniew Jędrzejewski-Szmek2018-04-049-68/+186
|\ \ | | | | | | | | | Fix validation of unit file drop-in naming in install.c.
| * | bus-unit-util: one less newlineLennart Poettering2018-03-291-1/+0
| | |
| * | install: don't enforce that .d/ dropin files (and their symlink chain ↵Lennart Poettering2018-03-291-40/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | elements) for units must have names that qualify as unit names The names of drop-in files can be anything as long as they are suffixed in ".conf", hence don't be stricter than necessary when validating the names used in symlink chains of such drop-in files. Also, drop-in files should not be ale to change the type of unit file itself, i.e. not affect whether it is considered masked or an alias as a whole. This adds a flag SEARCH_DROPIN that is passed whenever we load a drop-in rather the main unit file, and in that case loosen checks and behaviour we otherwise enforce for the unit file itself. Specifically: 1. If SEARCH_DROPIN is passed we won't change the unit's info->type field anymore, as that field (which can be REGULAR, MASKED, SYMLINK) should not be affected by drop-ins, but only by the unit file itself. 2. If SEARCH_DROPIN is passed we will shortcut following of symlink chains, and not validate the naming of each element in the chain, since that's irrelevant for drop-ins, and only matters for the unit file itself. Or in other words, without this: 1. A symlink /etc/systemd/system/foobar.service.d/20-quux.conf → /dev/null might have caused the whole of foobar.service to be considered "masked". 2. A symlink /etc/systemd/system/foobar.service.d/20-quux.conf → /tmp/miepf might have caused the whole loading of foobar.service to fail as EINVAL, as "miepf" is not a valid unit name.
| * | fs-util: add shortcut for chase_symlinks() when it is called like open(O_PATH)Lennart Poettering2018-03-291-0/+10
| | | | | | | | | | | | | | | Let's optimize things, and let the kernel chase the paths if none of the features chase_symlinks() offers are actually used.
| * | dissect: port code to chase_symlinks_and_open()Lennart Poettering2018-03-291-8/+4
| | |
| * | fs-util: add calls that combine chase_symlinks() and open()/opendir() in oneLennart Poettering2018-03-292-3/+90
| | | | | | | | | | | | | | | This is useful when opening files within disk images, as we'll then take the relative root directory properly into account.
| * | fd-util: introduce fd_reopen() helper for reopening an fdLennart Poettering2018-03-294-16/+24
| |/ | | | | | | | | | | We have the same code for this in place at various locations, let's unify that. Also, let's repurpose test-fs-util.c as a test for this new helper cal..
* | test-path: Set umask explicitly (#8616)Filipe Brandenburger2018-04-041-0/+4
| | | | | | | | | | | | | | | | | | | | Running `test-path` under an umask such as 027 fails with: Assertion '(s.st_mode & S_IRWXO) == 0004' failed at ../src/test/test-path.c:247, function test_path_makedirectory_directorymode(). Aborting. Looking at directory /tmp/test-path_makedirectory, it was indeed created with mode 0740, applying the umask to the requested 0744. Set an explicit umask for this test, to ensure reproducible results.
* | units: use `systemctl exit` to kill the user manager (#8648)Filipe Brandenburger2018-04-042-2/+1
| | | | | | | | | | | | | | | | | | | | | | Use `systemctl --user --force exit` to implement the systemd-exit user service. This removes our dependence on an external `kill` binary and the concerns about whether they recognize SIGRTMIN+n by name or what their interpretation of SIGRTMIN is. Tested: `systemctl --user start systemd-exit.service` kills the `systemd --user` instance for my user.
* | fix missed bracket of exec-personality-ppc64le.service (#8650)Feng Sun2018-04-041-1/+1
| | | | | | Signed-off-by: Neil Sun <neilsun@yunify.com>
* | Merge pull request #8624 from yuwata/fix-8371Zbigniew Jędrzejewski-Szmek2018-04-041-7/+8
|\ \ | | | | | | bash-completion: fixes for busctl
| * | bash-completion: busctl: make variables localYu Watanabe2018-03-301-4/+4
| | |
| * | bash-completion: busctl: do not suggest "-" for signatureYu Watanabe2018-03-301-1/+1
| | | | | | | | | | | | Fixes #8371.
| * | bash-completion: busctl: suggests only writable properties for set-propertyYu Watanabe2018-03-301-2/+3
| | |
* | | oss-fuzz: Fallback to `ninja-build` when available (#8641)Filipe Brandenburger2018-04-041-1/+9
| | | | | | | | | | | | | | | The ninja binary is deployed as `ninja-build` in older distros such as RHEL 7/CentOS 7. Detect that and use `ninja-build` instead of `ninja` when it's available.
* | | Merge pull request #8643 from poettering/coding-style-fixletsEvgeny Vereshchagin2018-04-042-5/+43
|\ \ \ | | | | | | | | Trivial CODING_STYLE additions
| * | | CODING_STYLE: document suggested suffixes to use in documentationLennart Poettering2018-04-031-0/+12
| | | |
| * | | CODING_STYLE: two minor additionsLennart Poettering2018-04-031-2/+4
| | | |
| * | | CODING_STYLE: mention that we ship .editconfig/.vimrc/.dir-locals.el in our repoLennart Poettering2018-04-031-3/+5
| | | |
| * | | update TODOLennart Poettering2018-04-031-0/+22
|/ / /
* | | tmpfiles: fix directory removal with force symlink (#8619)Ricardo Salveti de Araujo2018-04-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | symlink_atomic returns -EISDIR when the target symlink path is a directory. Fixes #7447 Signed-off-by: Ricardo Salveti <ricardo@opensourcefoundries.com>
* | | core: skip the removal of cgroups in the TEST_RUN_MINIMAL mode (#8622)Evgeny Vereshchagin2018-04-031-1/+1
| | | | | | | | | | | | | | | | | | When `systemd` is run in the TEST_RUN_MINIMAL mode, it doesn't really set up cgroups, so it shouldn't try to remove anything. Closes https://github.com/systemd/systemd/issues/8474.
* | | dissect: Don't count RPMB and boot partitions (#8609)João Paulo Rechi Vita2018-04-031-7/+20
| | | | | | | | | | | | | | | | | | | | | | | | Filter-out RPMB partitions and boot partitions from MMC devices when counting partitions enumerated by the kernel. Also factor out the now duplicated code into a separate function. This complement the previous fixes to the problem reported in https://github.com/systemd/systemd/issues/5806
* | | Merge pull request #8628 from jwrdegoede/hwdb-sensors2Lennart Poettering2018-04-031-9/+33
|\ \ \ | | | | | | | | Hwdb sensors2
| * | | hwdb: Add accelerometer orientation quirk for the Pipo W4 tabletHans de Goede2018-03-301-0/+4
| | | | | | | | | | | | | | | | Add an accelerometer orientation quirk for the Pipo W4 tablet.
| * | | hwdb: Add accelerometer orientation quirk for the Lenovo Ideapad Miix 310Hans de Goede2018-03-301-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add an accelerometer orientation quirk for the Lenovo Ideapad Miix 310. Note this quirk is limited to the production batches which ship with a portrait panel, rather then with a landscape panel (recognized by the different BIOS version these 2 variants use).
| * | | hwdb: Add accelerometer orientation quirk for the MSI S100 2-in-1Hans de Goede2018-03-301-0/+6
| | | | | | | | | | | | | | | | Add an accelerometer orientation quirk for the MSI S100 2-in-1.
| * | | hwdb: Add accelerometer orientation quirk for the Yours Y8W81 tabletHans de Goede2018-03-301-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add an accelerometer orientation quirk for the Yours Y8W81 8" tablet. For future reference: this tablet has the same case and mostly the same internals as the Chuwi Vi8. Both seem to be from an ODM called inet-tek. Both are labelled: "INET-I86M-REVxx" on the PCB, with the Chuwi Vi8 being REV03 (and having a ALC5640 audio codec) and the Yours Y8W81 being REV21 (and having a ALC5651 audio codec).
| * | | hwdb: Add accelerometer orientation entry for the I.T.Works TW701 tabletHans de Goede2018-03-301-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | Add accelerometer orientation entry for the I.T.Works TW701 7" windows tablet, note this is the same hardware/PCB as the Trekstor ST70416-6 for which we already have the same quirk.
View Lorry Controller Status