summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #12252 from keszybz/libmount-dont-unescapev242-rc4Zbigniew Jędrzejewski-Szmek2019-04-096-43/+156
|\ | | | | Don't unescape paths from libmount
| * pid1,shutdown: do not cunescape paths from libmountZbigniew Jędrzejewski-Szmek2019-04-092-32/+20
| | | | | | | | | | The test added in previous commit shows that libmount does the unescaping internally.
| * test-libmount: let's see how libmount parses stuffZbigniew Jędrzejewski-Szmek2019-04-092-0/+123
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With libmount-2.33.1-3.fc30.x86_64 I get: /* test_libmount_unescaping_one escaped space + utf8 */ from '729 38 0:59 / /tmp/\342\200\236zupa\\040z\304\231bowa\342\200\235 rw,relatime shared:395 - tmpfs die\\040Br\303\274he rw,seclabel' source: 'die Brühe' source: 'die Br\303\274he' source: 'die Brühe' expected: 'die Brühe' target: '/tmp/„zupa zębowa”' target: '/tmp/\342\200\236zupa z\304\231bowa\342\200\235' target: '/tmp/„zupa zębowa”' expected: '/tmp/„zupa zębowa”' /* test_libmount_unescaping_one escaped newline */ from '729 38 0:59 / /tmp/x\\012y rw,relatime shared:395 - tmpfs newline rw,seclabel' source: 'newline' source: 'newline' source: 'newline' expected: 'newline' target: '/tmp/x y' target: '/tmp/x\ny' target: '/tmp/x y' expected: '/tmp/x y' /* test_libmount_unescaping_one empty source */ from '760 38 0:60 / /tmp/emptysource rw,relatime shared:410 - tmpfs rw,seclabel' source: '' source: '' source: '' expected: '' target: '/tmp/emptysource' target: '/tmp/emptysource' target: '/tmp/emptysource' expected: '/tmp/emptysource' /* test_libmount_unescaping_one foo\rbar */ from '790 38 0:61 / /tmp/foo\rbar rw,relatime shared:425 - tmpfs tmpfs rw,seclabel' source: 'tmpfs' source: 'tmpfs' source: 'tmpfs' expected: 'tmpfs' target: '/tmp/foo' target: '/tmp/foo' target: '/tmp/foo' expected: 'n/a' With https://github.com/karelzak/util-linux/issues/780 fixed, we get /* test_libmount_unescaping_one foo\rbar */ from '790 38 0:61 / /tmp/foo\rbar rw,relatime shared:425 - tmpfs tmpfs rw,seclabel' source: 'tmpfs' source: 'tmpfs' source: 'tmpfs' expected: 'tmpfs' target: '/tmp/foo bar' target: '/tmp/foo\rbar' target: '/tmp/foo bar' expected: '/tmp/foo bar'
| * shared: add a single definition of libmount cleanup functionsZbigniew Jędrzejewski-Szmek2019-04-054-11/+13
| | | | | | | | | | | | | | | | Use a trivial header file to share mnt_free_tablep and mnt_free_iterp. It would be nicer put this in mount-util.h, but libmount.h is not in the default include path, and the build system would have to be adjusted to pass pkg-config include path in various places, and it's just not worth the trouble. A separate header file works nicely.
* | Merge pull request #12223 from yuwata/network-wireguard-preshared-key-fileZbigniew Jędrzejewski-Szmek2019-04-0914-181/+357
|\ \ | | | | | | network: add PresharedKeyFile= setting and make reading key file failure fatal
| * | NEWS: mention PresharedKeyFile=Yu Watanabe2019-04-091-2/+2
| | |
| * | test-network: add tests for WireGuardPeer.PresharedKey= and PresharedKeyFile=Yu Watanabe2019-04-093-1/+9
| | |
| * | network: make wireguard_decode_key_and_warn() take uint8_t buf[static ↵Yu Watanabe2019-04-091-1/+1
| | | | | | | | | | | | WG_KEY_LEN]
| * | network: warn when wireguard keys are stored in world readable filesYu Watanabe2019-04-091-0/+3
| | |
| * | network: add WireGuardPeer.PresharedKeyFile= settingYu Watanabe2019-04-095-1/+68
| | |
| * | network: clear wireguard keys on failure or on exitYu Watanabe2019-04-091-6/+12
| | |
| * | network: make reading PrivateKeyFile= failure always fatalYu Watanabe2019-04-093-41/+27
| | | | | | | | | | | | This also refactor wireguard_read_key_file().
| * | fileio: add READ_FULL_FILE_UNBASE64 flag for read_full_file_full()Yu Watanabe2019-04-092-1/+10
| | |
| * | fileio: read_full_file_full() also warns when file is world readable and ↵Yu Watanabe2019-04-092-3/+7
| | | | | | | | | | | | secure flag is set
| * | fileio: introduce warn_file_is_world_accessible()Yu Watanabe2019-04-092-0/+28
| | |
| * | util: introduce READ_FULL_FILE_SECURE flag for reading secure dataYu Watanabe2019-04-092-24/+59
| | |
| * | util: extend unbase64mem() to accept secure flagYu Watanabe2019-04-082-24/+56
| | | | | | | | | | | | When the flag is set, buffer is cleared on failure.
| * | network: re-indent conf parsers in wireguard.cYu Watanabe2019-04-081-82/+80
| | |
* | | l10n: Updated Lithuanian translationwelaq2019-04-091-15/+48
| | |
* | | Merge pull request #12241 from keszybz/two-man-link-additionsZbigniew Jędrzejewski-Szmek2019-04-081-9/+65
|\ \ \ | | | | | | | | Two man link additions
| * | | man: add a lengthy example for NamePolicy= debuggingZbigniew Jędrzejewski-Szmek2019-04-081-4/+55
| | | | | | | | | | | | | | | | | | | | This is still rather opaque, and test-builtin is quite useful in this case, let's advertise it a bit more.
| * | | man: say that .link NamePolicy= should be empty for Name= to take effectZbigniew Jędrzejewski-Szmek2019-04-081-9/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The description of NamePolicy= implied this, but didn't spell it out. It's a very common use case, so let's add a bit of explanation and ehance the example a bit. Inspired by https://bugzilla.redhat.com/show_bug.cgi?id=1695894.
* | | | inhibit: fix argv[] usageLennart Poettering2019-04-081-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Another fix in style of ed179fd71030ddd657500591dac37e7499fc7b2c and bd169c2be0fbdaf6eb2ea7951e650d5e5983fbf6.. I hope we are soon complete with these. Fixes: #12246
* | | | NEWS: add mention of time-set.targetZbigniew Jędrzejewski-Szmek2019-04-081-6/+12
| | | |
* | | | Merge pull request #12244 from poettering/242-news-finalLennart Poettering2019-04-088-278/+1380
|\ \ \ \ | | | | | | | | | | final 242 NEWS tweaks + another hwdb update
| * | | | hwdb: update hwdbLennart Poettering2019-04-087-267/+1368
| | | | |
| * | | | update NEWS for 242 finalLennart Poettering2019-04-081-11/+12
| | | | |
* | | | | man: add references from the .mount and .service man pages to ↵Lennart Poettering2019-04-082-2/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | systemd-{mount,run} pages Fixes: #12235
* | | | | Merge pull request #12245 from poettering/empty-or-dashZbigniew Jędrzejewski-Szmek2019-04-0810-66/+53
|\ \ \ \ \ | | | | | | | | | | | | introduce empty_or_dash() helper
| * | | | | coccinelle: add coccinelle script for empty_or_dash() useLennart Poettering2019-04-081-0/+5
| | | | | |
| * | | | | basic: add new helper call empty_or_dash_to_null()Lennart Poettering2019-04-087-50/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We have a function like this at two places already. Let's unify it in one generic location and let's port a number of users over.
| * | | | | tree-wide: introduce empty_or_dash() helperLennart Poettering2019-04-089-32/+32
| |/ / / / | | | | | | | | | | | | | | | | | | | | At quite a few places we check isempty() || streq(…, "-"), let's add a helper to simplify that, and replace that by a single function call.
* | | | | man: elaborate on fd ownership in sd_event_add_io(3)Lennart Poettering2019-04-081-0/+6
| | | | | | | | | | | | | | | | | | | | Replaces: #12239
* | | | | units: add time-set.targetPeter A. Bigot2019-04-086-3/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | time-sync.target is supposed to indicate system clock is synchronized with a remote clock, but as used through 241 it only provided a system clock that was updated based on a locally-maintained timestamp. Systems that are powered off for extended periods would not come up with accurate time. Retain the existing behavior using a new time-set.target leaving time-sync.target for cases where accuracy is required. Closes #8861
* | | | | man/systemd-sysusers: Fix typo in *from* to *form*Paul Menzel2019-04-081-1/+1
|/ / / /
* | | | Merge pull request #12238 from keszybz/one-genuine-bugfix+lots-of-line-wrappingLennart Poettering2019-04-083-173/+186
|\ \ \ \ | | | | | | | | | | One genuine bugfix and lots of line wrapping
| * | | | sysusers: use return_error_errno() where possibleZbigniew Jędrzejewski-Szmek2019-04-071-140/+119
| | | | |
| * | | | sysusers: add missing initalizerZbigniew Jędrzejewski-Szmek2019-04-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | I assume that this is the error causing the invalid free in https://bugzilla.redhat.com/show_bug.cgi?id=1670679.
| * | | | logind: linewrap some long lines and remove unnecessary conditionalZbigniew Jędrzejewski-Szmek2019-04-072-32/+66
| | | | |
* | | | | pam-systemd: use secure_getenv() rather than getenv()Lennart Poettering2019-04-081-3/+10
| |/ / / |/| | | | | | | | | | | And explain why in a comment.
* | | | man: correct units path usage according to FHS (#11388)Jonas DOREL2019-04-081-4/+6
|/ / / | | | | | | | | | According to the Filesystem Hierarchy Standard, "The /usr/local hierarchy is for use by the system administrator when installing software locally. It needs to be safe from being overwritten when the system software is updated". So it should not be used by installed packages.
* | | meson: drop misplaced -Wl,--undefined argumentJussi Pakkanen2019-04-071-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ld's man page says the following: -u symbol --undefined=symbol Force symbol to be entered in the output file as an undefined symbol. Doing this may, for example, trigger linking of additional modules from standard libraries. -u may be repeated with different option arguments to enter additional undefined symbols. This option is equivalent to the "EXTERN" linker script command. If this option is being used to force additional modules to be pulled into the link, and if it is an error for the symbol to remain undefined, then the option --require-defined should be used instead. This would imply that it always requires an argument, which this does not pass. Thus it will grab the next argument on the command line as its argument. Before it took one of the many -lrt args (presumably) and now it grabs something other random linker argument and things break. [zj: this line was added in the first version of the meson configuration back in 5c23128daba7236a6080383b2a5649033cfef85c. AFAICT, this was a mistake. No such flag appeared in Makefile.am at the time.] https://github.com/mesonbuild/meson/issues/5113
* | | Merge pull request #12234 from yuwata/calendarspec-fix-oss-fuzz-14108Lennart Poettering2019-04-072-94/+77
|\ \ \ | |/ / |/| | Calendarspec cleanups and fixes integer overflow
| * | calendarspec: fix possible integer overflowYu Watanabe2019-04-082-0/+4
| | | | | | | | | | | | | | | Fixes oss-fuzz#14108. https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=14108
| * | calendarspec: use _cleanup_ attributes for CalendarComponentYu Watanabe2019-04-081-74/+46
| | |
| * | calendarspec: rename free_chain() to chain_free()Yu Watanabe2019-04-081-24/+24
| | |
| * | calendarspec: use structured initializersYu Watanabe2019-04-081-13/+20
|/ /
* | nspawn: create boot_id and kmsg files for overmounting in /run, not /tmpLennart Poettering2019-04-071-8/+5
| | | | | | | | | | | | | | | | /tmp might not be mounted at all yet (given that we support SYSTEMD_NSPAWN_TMPFS_TMP=0 to turn this off), and /tmp is a dir systemd usually tries to unmount during shutdown (unlike /run), and we shouldn't keep it busy. Hence let's just move these deleted files to /run so that we don't keep /tmp needlessly busy.
* | lgtm: warn about strerror() useLennart Poettering2019-04-051-0/+3
| |
* | meson: sort source files againLennart Poettering2019-04-051-2/+2
| |