summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | test-network: add test for Property= in [Match] sectionYu Watanabe2019-07-013-0/+24
| | |
| * | test: add tests for config_parse_match_{strv,ifnames}()Yu Watanabe2019-07-011-0/+23
| | |
| * | man: fix wrong udev property nameYu Watanabe2019-07-012-2/+2
| | |
| * | network,udev: add Property= setting in [Match] sectionYu Watanabe2019-07-0112-6/+143
| | | | | | | | | | | | Closes #5665.
| * | network,udev: make net_match_config() take sd_deviceYu Watanabe2019-07-014-35/+23
| | |
| * | network,udev: fix multiple invert matching linesYu Watanabe2019-07-015-36/+111
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, ``` [Match] Name=!aaa Name=!bbb ``` does not work. This fixes the issue.
* | | udev: accept lines which have only PROGRAM=Yu Watanabe2019-07-011-1/+1
| | | | | | | | | | | | As PROGRAM= may cause side effect, and users may expect that.
* | | Merge pull request #12916 from yuwata/meson-drop-duplicated-lineMichael Biebl2019-07-011-1/+0
|\ \ \ | |/ / |/| | meson: drop duplicated source
| * | meson: drop duplicated sourceYu Watanabe2019-07-011-1/+0
|/ /
* | networkctl: do not show '(null)' in HW Address entryYu Watanabe2019-06-301-6/+6
| | | | | | | | This also fixes indentation.
* | Merge pull request #12910 from keszybz/udev-kvmYu Watanabe2019-06-302-28/+24
|\ \ | |/ |/| Fix permissions on /dev/kvm
| * udev: don't force device ownership and mode on every eventZbigniew Jędrzejewski-Szmek2019-06-292-27/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This partially reverts 25de7aa7b90c23d33ea50ada1e50c5834a414237. I don't think the change was intended there. The problem I'm trying to solve: for /dev/kvm we get first an ADD uevent, and then CHANGE whenever something connects or disconnects to the character device. The rules in 50-default-udev.rules set UID, GID, and MODE on ADD, but not on CHANGE. When the change event happens, we would reset the ownership and permissions. This happens because node_permissions_apply() would (after 25de7aa7b90c23d33) set uid=gid=0 if they weren't set by the rules. So let's only pass uid/gid/mode to node_permissions_apply() if appropriately configured. Also let node_permissions_apply() do the skip of uid/gid/mode if not set, and rename "always_apply" to more closely reflect its meaning.
| * udev: tiny fix to debug messageZbigniew Jędrzejewski-Szmek2019-06-291-1/+1
| |
* | Merge pull request #12903 from keszybz/condition-quotingYu Watanabe2019-06-3027-179/+244
|\ \ | | | | | | Condition quoting
| * | test-condition: do not accidentally treat error as passing conditionZbigniew Jędrzejewski-Szmek2019-06-291-51/+51
| | | | | | | | | | | | condition_test returns 0, 1, or error.
| * | Treat kernel version condition as a list of quoted checksZbigniew Jędrzejewski-Szmek2019-06-294-10/+72
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before only one comparison was allowed. Let's make this more flexible: ConditionKernelVersion = ">=4.0" "<=4.5" Fixes #12881. This also fixes expressions like "ConditionKernelVersion=>" which would evaluate as true.
| * | test-execute: add test for ConditionKernelVersion= with quotationYu Watanabe2019-06-291-0/+2
| | |
| * | Rename EXTRACT_QUOTES to EXTRACT_UNQUOTEZbigniew Jędrzejewski-Szmek2019-06-2824-93/+93
| | | | | | | | | | | | | | | | | | Whenever I see EXTRACT_QUOTES, I'm always confused whether it means to leave the quotes in or to take them out. Let's say "unquote", like we say "cunescape".
| * | Reindent some things for readabilityZbigniew Jędrzejewski-Szmek2019-06-282-25/+26
| | |
* | | Merge pull request #12907 from yuwata/meson-default-libidn2Zbigniew Jędrzejewski-Szmek2019-06-293-14/+12
|\ \ \ | | | | | | | | meson: use libidn2 and drop udev debug option
| * | | NEWS: mention that the libidn2 is used by defaultYu Watanabe2019-06-291-0/+3
| | | |
| * | | meson: default to use libidn2 if both libidn2 and libidn are installedYu Watanabe2019-06-291-8/+8
| | | |
| * | | meson: drop unused debug optionYu Watanabe2019-06-292-6/+1
| | | |
* | | | udev: fix wrong event source to set descriptionYu Watanabe2019-06-291-1/+1
| | | |
* | | | Merge pull request #12908 from yuwata/udevadm-completion-actionZbigniew Jędrzejewski-Szmek2019-06-296-7/+24
|\ \ \ \ | | | | | | | | | | udevadm: support special value 'help' for --action option
| * | | | bash-completion: udevadm: list all possible values for --action optionYu Watanabe2019-06-291-2/+2
| | | | |
| * | | | udevadm: support special value 'help' for --action optionYu Watanabe2019-06-293-5/+17
| | | | |
| * | | | sd-device: introduce dump_device_action_table()Yu Watanabe2019-06-292-0/+5
|/ / / / | | | | | | | | | | | | Will be used in later commits.
* | | | Merge pull request #12905 from keszybz/udev-warningsYu Watanabe2019-06-294-267/+291
|\ \ \ \ | |/ / / |/| | / | | |/ | |/| Udev warnings
| * | udev-rules: add more info to errors about attr formatsZbigniew Jędrzejewski-Szmek2019-06-281-15/+23
| | |
| * | udev-rules: add precise information to rule failure logsZbigniew Jędrzejewski-Szmek2019-06-283-43/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is pretty hard to figure out what the problem actually is, esp. when the rule is long. On my machine: systemd[1]: Starting udev Kernel Device Manager... systemd-udevd[217399]: /usr/lib/udev/rules.d/11-dm-lvm.rules:40 Invalid value for OPTIONS key, ignoring: 'event_timeout=180' systemd-udevd[217399]: /usr/lib/udev/rules.d/11-dm-lvm.rules:40 The line takes no effect, ignoring. systemd-udevd[217399]: /etc/udev/rules.d/60-ipath.rules:4 Invalid value "kcopy/%02n" for NAME (char 7: invalid substitution type), ignoring, but please fix it. systemd-udevd[217399]: /usr/lib/udev/rules.d/65-md-incremental.rules:28 Invalid value "/sbin/mdadm -I $env{DEVNAME} --export $devnode --offroot ${DEVLINKS}" for IMPORT (char 58: invalid substitution type), ignoring, but please fix it. systemd-udevd[217399]: /etc/udev/rules.d/73-special-net-names.rules:14 Invalid value "/bin/sh -ec 'D=${DEVPATH#*/vio/}; D=${D%%%%/*}; D=${D#????}; D=${D#0}; D=${D#0}; D=${D#0}; D=${D#0}; echo ${D:-0}'" for PROGRAM (char 16: invalid substitution type), ignoring, but please fix it. systemd-udevd[217399]: /usr/lib/udev/rules.d/84-nm-drivers.rules:10 Invalid value "/bin/sh -c 'ethtool -i $1 | sed -n s/^driver:\ //p' -- $env{INTERFACE}" for PROGRAM (char 24: invalid substitution type), ignoring, but please fix it. systemd-udevd[217399]: /usr/lib/udev/rules.d/90-libgpod.rules:19 IMPORT key takes '==' or '!=' operator, assuming '==', but please fix it. systemd-udevd[217399]: /usr/lib/udev/rules.d/90-libgpod.rules:23 IMPORT key takes '==' or '!=' operator, assuming '==', but please fix it. systemd-udevd[217399]: /usr/lib/udev/rules.d/99-vmware-scsi-udev.rules:5 Invalid value "/bin/sh -c 'echo 180 >/sys$DEVPATH/device/timeout'" for RUN (char 27: invalid substitution type), ignoring, but please fix it. systemd-udevd[217399]: /usr/lib/udev/rules.d/99-vmware-scsi-udev.rules:6 Invalid value "/bin/sh -c 'echo 180 >/sys$DEVPATH/device/timeout'" for RUN (char 27: invalid substitution type), ignoring, but please fix it. systemd[1]: Started udev Kernel Device Manager.
| * | udev-event: use normal pointer ops where appropriateZbigniew Jędrzejewski-Szmek2019-06-281-12/+12
| | |
| * | udev: move rule structure definitions into the .c fileZbigniew Jędrzejewski-Szmek2019-06-282-145/+146
| | | | | | | | | | | | They are (and should) only be used there, no need to expose them.
| * | udev: move rules logging functions into the .c fileZbigniew Jędrzejewski-Szmek2019-06-282-61/+66
| |/ | | | | | | They are (and can) only be used there, no need to expose them.
* | Merge pull request #12887 from fbuihuu/coredump-cleanup-part-1Zbigniew Jędrzejewski-Szmek2019-06-2810-268/+283
|\ \ | |/ |/| Coredump cleanup part 1
| * coredump: make use of the iovec-array helpersFranck Bui2019-06-281-145/+129
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previous code was allocating an array of iovecs big enough to store all the fields added later by various functions. This forced us to calculate the size of the array in advance which is too error prone if for example one wants to add new fields or simply rework the code. Various assertions were added to make sure there's no overflow but it's still more code for no good reasons. Instead, this patch switches to the new iovec array handling interface so the array is grown dynamically when needed. The other contraint was that some iovecs were supposed to be freed whereas some others were not. This makes the code hard to (re)organize. The new code always allocates fields so it becomes easier to rework the code.
| * io-util: introduce iovw_put_string_field() helperFranck Bui2019-06-272-0/+23
| |
| * journal-import: extract helpers for handling arrays of iovec and make them ↵Franck Bui2019-06-277-48/+77
| | | | | | | | available for others
| * coredump: drop 2 useless assertionsFranck Bui2019-06-271-3/+0
| |
| * coredump: slighlty simplify stack trace generation logicFranck Bui2019-06-273-31/+33
| | | | | | | | | | | | | | The main advantage is to avoid the code duplication used to build MESSAGE= field. No functional changes.
| * coredump: fix the check on the number of passed args in backtrace modeFranck Bui2019-06-271-2/+2
| | | | | | | | In backtrace mode, '--backtrace' option should also be counted.
| * coredump: gather_pid_metadata() doesn't return 1 anymoreFranck Bui2019-06-271-5/+1
| | | | | | | | | | Since commit 92e92d71faea0f107312f296b7756cc04281ba99, gather_pid_metadata() returns only 0 or a negative value.
| * coredump: rename set_iovec_field_free() into set_iovec_string_field_free()Franck Bui2019-06-273-23/+24
| | | | | | | | | | | | It's more in line with its counterpart set_iovec_string_field(). Also move the definition to io-util next to set_iovec_string_field().
| * coredump: rely on /proc exclusively to get the name of the crashing processFranck Bui2019-06-262-29/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I couldn't see any reason why the kernel could provide COMM to the coredump handler via the core_pattern command line but could not make it available in /proc. So let's assume that this info is always available in /proc. For "backtrace" mode (when --backtrace option is passed), I assumed that the crashing process still exists at the time systemd-coredump is called. Also changing the core_pattern line is an API breakage for any users of the backtrace mode but given that systemd-coredump is installed in /usr/lib/systemd, it's a private tool which has no internal users. At least no one complained when the hostname was added to the core_pattern line (f45b8015513)... Indeed it's much easier to get it from /proc since the kernel substitutes '%e' specifier with multiple strings if the process name contains spaces (!).
| * coredump: fix one memleak in backtrace modeFranck Bui2019-06-261-1/+1
| | | | | | | | Journal importer internal structures need to be freed.
| * coredump: make use of STRINGIFYFranck Bui2019-06-261-5/+2
| |
* | cryptsetup-generator: fix luks-* entry parsing from crypttabLubomir Rintel2019-06-281-1/+3
| | | | | | | | | | | | | | | | | | This reverts a part of commit 49fe5c099639 ('tree-wide: port various places over to STARTSWITH_SET()') that replaced a pair of startswith() calls with STARTSWITH_SET(). They were in fact for a different strings (device vs. name), botching the crypttap parsing.
* | bash-completion: support systemd-analyze conditionYu Watanabe2019-06-281-1/+1
| |
* | Merge pull request #12889 from keszybz/analyze-conditionYu Watanabe2019-06-2811-31/+242
|\ \ | | | | | | Add systemd-analyze condition
| * | core: skip whitespace after "|" and "!" in the condition parserZbigniew Jędrzejewski-Szmek2019-06-271-4/+4
| | | | | | | | | | | | | | | | | | We'd skip any whitespace immediately after "=", but then we'd treat whitespace that is between "|" or "!" and the value as significant. This is rather confusing, let's ignore it too.