diff options
author | Yu Watanabe <watanabe.yu+github@gmail.com> | 2018-04-05 14:26:26 +0900 |
---|---|---|
committer | Yu Watanabe <watanabe.yu+github@gmail.com> | 2018-04-05 14:26:26 +0900 |
commit | 1cc6c93a9569a9f2664d0d26cd0e50408307c430 (patch) | |
tree | 57e115a1beb9b097f731da79c3192015ff35cc94 /src/shared/path-lookup.c | |
parent | 3d282fff063c81893dc4bbd0282193d20dd5357e (diff) | |
download | systemd-1cc6c93a9569a9f2664d0d26cd0e50408307c430.tar.gz |
tree-wide: use TAKE_PTR() and TAKE_FD() macros
Diffstat (limited to 'src/shared/path-lookup.c')
-rw-r--r-- | src/shared/path-lookup.c | 45 |
1 files changed, 17 insertions, 28 deletions
diff --git a/src/shared/path-lookup.c b/src/shared/path-lookup.c index a472e80aec..792175a8d8 100644 --- a/src/shared/path-lookup.c +++ b/src/shared/path-lookup.c @@ -302,11 +302,10 @@ static int acquire_generator_dirs( if (!z) return -ENOMEM; - *generator = x; - *generator_early = y; - *generator_late = z; + *generator = TAKE_PTR(x); + *generator_early = TAKE_PTR(y); + *generator_late = TAKE_PTR(z); - x = y = z = NULL; return 0; } @@ -381,9 +380,8 @@ static int acquire_config_dirs(UnitFileScope scope, char **persistent, char **ru if (!a || !b) return -ENOMEM; - *persistent = a; - *runtime = b; - a = b = NULL; + *persistent = TAKE_PTR(a); + *runtime = TAKE_PTR(b); return 0; } @@ -647,12 +645,10 @@ int lookup_paths_init( r = strv_extend_strv(&paths, add, true); if (r < 0) return r; - } else { + } else /* Small optimization: if paths is NULL (and it usually is), we can simply assign 'add' to it, * and don't have to copy anything */ - paths = add; - add = NULL; - } + paths = TAKE_PTR(add); } r = patch_root_prefix(&persistent_config, root); @@ -691,27 +687,20 @@ int lookup_paths_init( p->search_path = strv_uniq(paths); paths = NULL; - p->persistent_config = persistent_config; - p->runtime_config = runtime_config; - persistent_config = runtime_config = NULL; - - p->generator = generator; - p->generator_early = generator_early; - p->generator_late = generator_late; - generator = generator_early = generator_late = NULL; + p->persistent_config = TAKE_PTR(persistent_config); + p->runtime_config = TAKE_PTR(runtime_config); - p->transient = transient; - transient = NULL; + p->generator = TAKE_PTR(generator); + p->generator_early = TAKE_PTR(generator_early); + p->generator_late = TAKE_PTR(generator_late); - p->persistent_control = persistent_control; - p->runtime_control = runtime_control; - persistent_control = runtime_control = NULL; + p->transient = TAKE_PTR(transient); - p->root_dir = root; - root = NULL; + p->persistent_control = TAKE_PTR(persistent_control); + p->runtime_control = TAKE_PTR(runtime_control); - p->temporary_dir = tempdir; - tempdir = NULL; + p->root_dir = TAKE_PTR(root); + p->temporary_dir = TAKE_PTR(tempdir); return 0; } |