diff options
| author | Lennart Poettering <lennart@poettering.net> | 2021-09-29 10:30:17 +0200 |
|---|---|---|
| committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2021-10-12 18:01:35 +0200 |
| commit | 0a965fbd6bba51bc832013058ae97a8265a52b3d (patch) | |
| tree | 4645b0b2e56fd51ffa2851b1a5150283656dc97a | |
| parent | 4f67f7483e3d8997c9e5414afd88d259aa46fe7f (diff) | |
| download | systemd-0a965fbd6bba51bc832013058ae97a8265a52b3d.tar.gz | |
core: drop "const" from NeedsDaemonReload unit dbus property
It's not "const", it can change any time if people change the fs, and we
don#t send out notifications for it. Hence don't claim it was const.
(Otherwise clients might cache it, but they should not)
Prompted-by: #20792
(cherry picked from commit e30a3ba16a5da4b46cd6c8bc363dbccb791fc45e)
(cherry picked from commit 3636724012003a2f9b45eb9f8991ae93661de462)
| -rw-r--r-- | man/org.freedesktop.systemd1.xml | 2 | ||||
| -rw-r--r-- | src/core/dbus-unit.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/man/org.freedesktop.systemd1.xml b/man/org.freedesktop.systemd1.xml index aff43217e1..263cdcde46 100644 --- a/man/org.freedesktop.systemd1.xml +++ b/man/org.freedesktop.systemd1.xml @@ -1691,7 +1691,7 @@ node /org/freedesktop/systemd1/unit/avahi_2ddaemon_2eservice { readonly s OnFailureJobMode = '...'; @org.freedesktop.DBus.Property.EmitsChangedSignal("const") readonly b IgnoreOnIsolate = ...; - @org.freedesktop.DBus.Property.EmitsChangedSignal("const") + @org.freedesktop.DBus.Property.EmitsChangedSignal("false") readonly b NeedDaemonReload = ...; @org.freedesktop.DBus.Property.EmitsChangedSignal("false") readonly as Markers = ['...', ...]; diff --git a/src/core/dbus-unit.c b/src/core/dbus-unit.c index 39d6799b59..89f5808275 100644 --- a/src/core/dbus-unit.c +++ b/src/core/dbus-unit.c @@ -895,7 +895,7 @@ const sd_bus_vtable bus_unit_vtable[] = { SD_BUS_PROPERTY("DefaultDependencies", "b", bus_property_get_bool, offsetof(Unit, default_dependencies), SD_BUS_VTABLE_PROPERTY_CONST), SD_BUS_PROPERTY("OnFailureJobMode", "s", property_get_job_mode, offsetof(Unit, on_failure_job_mode), SD_BUS_VTABLE_PROPERTY_CONST), SD_BUS_PROPERTY("IgnoreOnIsolate", "b", bus_property_get_bool, offsetof(Unit, ignore_on_isolate), SD_BUS_VTABLE_PROPERTY_CONST), - SD_BUS_PROPERTY("NeedDaemonReload", "b", property_get_need_daemon_reload, 0, SD_BUS_VTABLE_PROPERTY_CONST), + SD_BUS_PROPERTY("NeedDaemonReload", "b", property_get_need_daemon_reload, 0, 0), SD_BUS_PROPERTY("Markers", "as", property_get_markers, offsetof(Unit, markers), 0), SD_BUS_PROPERTY("JobTimeoutUSec", "t", bus_property_get_usec, offsetof(Unit, job_timeout), SD_BUS_VTABLE_PROPERTY_CONST), SD_BUS_PROPERTY("JobRunningTimeoutUSec", "t", bus_property_get_usec, offsetof(Unit, job_running_timeout), SD_BUS_VTABLE_PROPERTY_CONST), |