summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>2018-12-05 21:34:24 +0100
committerLukáš Nykrýn <lnykryn@redhat.com>2019-02-07 12:57:43 +0100
commit04326c02ca80666e66a5da8e6a46c2fc4476000c (patch)
treef5dc0d9f55531f259de22d94a01047b8d6e00830
parent6298317e2d0dffb1ff4ecebedb8709645de36b6a (diff)
downloadsystemd-04326c02ca80666e66a5da8e6a46c2fc4476000c.tar.gz
coredump: fix message when we fail to save a journald coredump
If creation of the message failed, we'd write a bogus entry: systemd-coredump[1400]: Cannot store coredump of 416 (systemd-journal): No space left on device systemd-coredump[1400]: MESSAGE=Process 416 (systemd-journal) of user 0 dumped core. systemd-coredump[1400]: Coredump diverted to (cherry-picked from commit f0136e09221364f931c3a3b715da4e4d3ee9f2ac) Related: #1664976
-rw-r--r--src/coredump/coredump.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/coredump/coredump.c b/src/coredump/coredump.c
index ffa88f612d..2a130e8838 100644
--- a/src/coredump/coredump.c
+++ b/src/coredump/coredump.c
@@ -783,8 +783,8 @@ log:
core_message = strjoin("MESSAGE=Process ", context[CONTEXT_PID],
" (", context[CONTEXT_COMM], ") of user ",
context[CONTEXT_UID], " dumped core.",
- journald_crash ? "\nCoredump diverted to " : NULL,
- journald_crash ? filename : NULL);
+ journald_crash && filename ? "\nCoredump diverted to " : NULL,
+ journald_crash && filename ? filename : NULL);
if (!core_message)
return log_oom();