diff options
author | Yu Watanabe <watanabe.yu+github@gmail.com> | 2019-10-23 16:11:27 +0900 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-10-23 16:11:27 +0900 |
commit | c199cc0704271378ea5eafc0bddb6b7453c4e71f (patch) | |
tree | 66aafdf811046128add1857aa7da1553d4012488 | |
parent | 12c829376a95ee0a734b8dbd347042062516f0a9 (diff) | |
parent | ecfd9a990c4a59f68fb129bd932eec871119f4f6 (diff) | |
download | systemd-c199cc0704271378ea5eafc0bddb6b7453c4e71f.tar.gz |
Merge pull request #13820 from keszybz/dead-code-removal
Dead code removal
-rw-r--r-- | src/journal-remote/journal-remote-main.c | 3 | ||||
-rw-r--r-- | src/tty-ask-password-agent/tty-ask-password-agent.c | 10 | ||||
-rw-r--r-- | src/update-utmp/update-utmp.c | 21 |
3 files changed, 15 insertions, 19 deletions
diff --git a/src/journal-remote/journal-remote-main.c b/src/journal-remote/journal-remote-main.c index 329505cd2c..ac2bf648d2 100644 --- a/src/journal-remote/journal-remote-main.c +++ b/src/journal-remote/journal-remote-main.c @@ -266,7 +266,6 @@ static int request_handler( int r, code, fd; _cleanup_free_ char *hostname = NULL; bool chunked = false; - size_t len; assert(connection); assert(connection_cls); @@ -302,6 +301,8 @@ static int request_handler( header = MHD_lookup_connection_value(connection, MHD_HEADER_KIND, "Content-Length"); if (header) { + size_t len; + if (chunked) return mhd_respond(connection, MHD_HTTP_BAD_REQUEST, "Content-Length must not specified when Transfer-Encoding type is 'chuncked'"); diff --git a/src/tty-ask-password-agent/tty-ask-password-agent.c b/src/tty-ask-password-agent/tty-ask-password-agent.c index 2e57a628b2..068988e203 100644 --- a/src/tty-ask-password-agent/tty-ask-password-agent.c +++ b/src/tty-ask-password-agent/tty-ask-password-agent.c @@ -337,7 +337,7 @@ static int process_and_watch_password_files(bool watch) { }; _cleanup_close_ int notify = -1, signal_fd = -1, tty_block_fd = -1; - struct pollfd pollfd[_FD_MAX] = {}; + struct pollfd pollfd[_FD_MAX]; sigset_t mask; int r; @@ -354,8 +354,7 @@ static int process_and_watch_password_files(bool watch) { if (signal_fd < 0) return log_error_errno(errno, "Failed to allocate signal file descriptor: %m"); - pollfd[FD_SIGNAL].fd = signal_fd; - pollfd[FD_SIGNAL].events = POLLIN; + pollfd[FD_SIGNAL] = (struct pollfd) { .fd = signal_fd, .events = POLLIN }; notify = inotify_init1(IN_CLOEXEC); if (notify < 0) @@ -365,8 +364,7 @@ static int process_and_watch_password_files(bool watch) { if (r < 0) return r; - pollfd[FD_INOTIFY].fd = notify; - pollfd[FD_INOTIFY].events = POLLIN; + pollfd[FD_INOTIFY] = (struct pollfd) { .fd = notify, .events = POLLIN }; } for (;;) { @@ -389,7 +387,7 @@ static int process_and_watch_password_files(bool watch) { if (!watch) break; - if (poll(pollfd, watch ? _FD_MAX : _FD_MAX-1, timeout) < 0) { + if (poll(pollfd, _FD_MAX, timeout) < 0) { if (errno == EINTR) continue; diff --git a/src/update-utmp/update-utmp.c b/src/update-utmp/update-utmp.c index f0fc181b57..9338524a33 100644 --- a/src/update-utmp/update-utmp.c +++ b/src/update-utmp/update-utmp.c @@ -21,6 +21,7 @@ #include "main-func.h" #include "process-util.h" #include "special.h" +#include "stdio-util.h" #include "strv.h" #include "unit-name.h" #include "util.h" @@ -188,10 +189,8 @@ static int on_runlevel(Context *c) { /* Secondly, get new runlevel */ runlevel = get_current_runlevel(c); - if (runlevel < 0) return runlevel; - if (runlevel == 0) return log_warning("Failed to get new runlevel, utmp update skipped."); @@ -200,23 +199,21 @@ static int on_runlevel(Context *c) { #if HAVE_AUDIT if (c->audit_fd >= 0) { - _cleanup_free_ char *s = NULL; + char s[STRLEN("old-level=_ new-level=_") + 1]; - if (asprintf(&s, "old-level=%c new-level=%c", - previous > 0 ? previous : 'N', - runlevel > 0 ? runlevel : 'N') < 0) - return log_oom(); + xsprintf(s, "old-level=%c new-level=%c", + previous > 0 ? previous : 'N', + runlevel); - if (audit_log_user_comm_message(c->audit_fd, AUDIT_SYSTEM_RUNLEVEL, s, "systemd-update-utmp", NULL, NULL, NULL, 1) < 0 && errno != EPERM) + if (audit_log_user_comm_message(c->audit_fd, AUDIT_SYSTEM_RUNLEVEL, s, + "systemd-update-utmp", NULL, NULL, NULL, 1) < 0 && errno != EPERM) r = log_error_errno(errno, "Failed to send audit message: %m"); } #endif q = utmp_put_runlevel(runlevel, previous); - if (q < 0 && !IN_SET(q, -ESRCH, -ENOENT)) { - log_error_errno(q, "Failed to write utmp record: %m"); - r = q; - } + if (q < 0 && !IN_SET(q, -ESRCH, -ENOENT)) + return log_error_errno(q, "Failed to write utmp record: %m"); return r; } |