summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOlly Betts <olly@survex.com>2021-03-26 11:18:07 +1300
committerOlly Betts <olly@survex.com>2021-03-26 11:18:07 +1300
commitb8409114107f2f9bf37c23e506cc4e5d8a19ab9a (patch)
treefc68f69ac212cd4ba6e9acf607b7fec2aabf3374
parent3fba8e7daa24c23c56ce6d7451831fc8f6961851 (diff)
downloadswig-b8409114107f2f9bf37c23e506cc4e5d8a19ab9a.tar.gz
Remove outdated FIXME/TODO from php.cxx
See #1529
-rw-r--r--Source/Modules/php.cxx16
1 files changed, 0 insertions, 16 deletions
diff --git a/Source/Modules/php.cxx b/Source/Modules/php.cxx
index d8ee75b45..b02aaf90d 100644
--- a/Source/Modules/php.cxx
+++ b/Source/Modules/php.cxx
@@ -24,17 +24,6 @@
* value which is a compound C++ expression (i.e. as if we had a
* method with two overloaded forms instead of a single method with
* a default parameter value).
- *
- * Long term:
- *
- * Sort out locale-dependent behaviour of strtod() - it's harmless unless
- * SWIG ever sets the locale and DOH/base.c calls atof, so we're probably
- * OK currently at least.
- */
-
-/*
- * TODO: Replace remaining stderr messages with Swig_error or Swig_warning
- * (may need to add more WARN_PHP_xxx codes...)
*/
#include "swigmod.h"
@@ -1255,8 +1244,6 @@ public:
arg_names = (String **) malloc(max_num_of_arguments * sizeof(String *));
if (!arg_names) {
- /* FIXME: How should this be handled? The rest of SWIG just seems
- * to not bother checking for malloc failing! */
fprintf(stderr, "Malloc failed!\n");
SWIG_exit(EXIT_FAILURE);
}
@@ -1267,8 +1254,6 @@ public:
arg_values = (String **) malloc(max_num_of_arguments * sizeof(String *));
byref = (unsigned char *) malloc(max_num_of_arguments);
if (!arg_values || !byref) {
- /* FIXME: How should this be handled? The rest of SWIG just seems
- * to not bother checking for malloc failing! */
fprintf(stderr, "Malloc failed!\n");
SWIG_exit(EXIT_FAILURE);
}
@@ -1386,7 +1371,6 @@ public:
case T_LONGDOUBLE: {
char *p;
errno = 0;
- /* FIXME: strtod is locale dependent... */
double val = strtod(Char(value), &p);
if (errno || *p) {
Clear(value);