summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* fixed issue redundantAssignmentfix/cppcheck_issuesypostolov2020-03-2620-99/+35
|
* fixed issue asctimeCalledypostolov2020-03-261-6/+12
|
* fixed issue unusedStructMemberypostolov2020-03-261-54/+0
|
* fixed issue invalidPrintfArgType_sintypostolov2020-03-263-14/+7
|
* fixed issue unreadVariableypostolov2020-03-263-13/+1
|
* fixed issue unusedFunctionypostolov2020-03-265-30/+0
|
* fixed issue noExplicitConstructorypostolov2020-03-2619-58/+40
|
* fixed issue variableScopeypostolov2020-03-263-10/+6
|
* fixed issue unreachableCodeypostolov2020-03-261-2/+1
|
* fix cppcheck issues in appMainypostolov2020-03-261-0/+1
|
* fix cppcheck issues in component media_managerypostolov2020-03-261-0/+1
|
* fix cppcheck issues in component resumptionypostolov2020-03-261-0/+1
|
* fix cppcheck issues in component protocolypostolov2020-03-262-0/+2
|
* fix cppcheck issues in component rpc_baseypostolov2020-03-263-0/+3
|
* fix cppcheck issues in component hmi_message_handlerypostolov2020-03-263-7/+9
|
* fix cppcheck issues in component config_profileypostolov2020-03-264-5/+9
|
* fix cppcheck issues in component connection_handlerypostolov2020-03-266-4/+8
|
* fix cppcheck issues in component formattersypostolov2020-03-2611-2/+12
|
* fix cppcheck issues in component security_managerypostolov2020-03-267-1/+10
|
* fix cppcheck issues in component protocol_handlerypostolov2020-03-2610-4/+12
|
* fix cppcheck issues in component telemetry_monitorypostolov2020-03-268-0/+8
|
* fix cppcheck issues in component policyypostolov2020-03-2627-11/+44
|
* fix cppcheck issues in component smart_objectsypostolov2020-03-2616-0/+16
|
* fix cppcheck issues in component utilsypostolov2020-03-2632-2/+35
|
* fix cppcheck issues in component transport_managerypostolov2020-03-2620-23/+61
|
* fix cppcheck issues in component application_managerypostolov2020-03-26227-39/+278
|
* move submodule to own orgcollin2020-03-241-1/+1
|\
| * Update .gitmodules (#3301)Collin2020-03-241-1/+1
| |
| * Fix OnSystemRequest(LOCK_SCREEN_ICON_URL) sending (#3271)Andrii Kalinich (GitHub)2020-03-1332-228/+127
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was noticed an issue that sometimes Policy Manager component is returning an empty url for lock screen icon. The root cause of that is the data races between thread which is sending OnSystemRequest notification and backupper thread which overwrites data in the database. As these two threads may have an intersection, there could be a possible situation that backuper thread erased data from `endpoints` table and another thread is using SQL query to select the data from the same table. As a result, second thread receives an empty result as the data was erased and the new one was not inserted yet by backupper thread. After that, SDL just does not send OnSystemRequest as the URL is empty. To fix that issue, policy component has been updated to use internal policy cache instead of direct access to policy database each time to get URL. This will guarantee that a sending thread will get an up-to-date infromation required for OnSystemRequest notification. Also, code cleanup has been done in order to remove all functions which become unused after this fix.
* | maintain signature for GetLockScreenIconUrl (#3303)Collin2020-03-232-2/+2
| |
* | Update start_external_proprietary.sh (#3299)Collin2020-03-231-3/+5
| | | | | | | | | | | | | | | | | | * Update start_external_proprietary.sh * Update src/appMain/start_external_proprietary.sh Co-Authored-By: Shobhit Adlakha <ShobhitAd@users.noreply.github.com> Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
* | Fix sdl crash when policies disabled (#3292)Yaroslav Mamykin (GitHub)2020-03-232-50/+267
| | | | | | | | | | | | | | * Fix usage non-valid policy_manager pointer in case of EnablePolicy=false * Add unit tests for modified methods Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
* | Fix/Checking PTU triggers when no apps are registered in regular policy mode ↵Shobhit Adlakha2020-03-191-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#3294) * Trigger PTExchange when Device consent is enabled * Move StartPTExchange call to BC.OnReady * StartPTExchange is a protected function. Add TriggerPTUIfNeeded to the policy_manager as well * Fixed GetPolicyHandler call in BC.OnReady * Add mock definitions * Fix failed ut * Handle PolicyUpdate error response * Add reset retry sequence * Revert "Move StartPTExchange call to BC.OnReady" This reverts commit 7c53978b2e7a42ed51cb856d054dce88e040e8ea. Co-authored-by: JackLivio <jack@livio.io>
* | Fix/consider timeouts during streaming switching (#3293)Serhii Niukalov (GitHub)2020-03-196-9/+79
| | | | | | | | | | * Consider video and audio status before send end of service Co-authored-by: sniukalov <sniukaov@luxoft.com>
* | Fix OnSystemRequest(LOCK_SCREEN_ICON_URL) sending (#3271) (#3289)Collin2020-03-1632-228/+127
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was noticed an issue that sometimes Policy Manager component is returning an empty url for lock screen icon. The root cause of that is the data races between thread which is sending OnSystemRequest notification and backupper thread which overwrites data in the database. As these two threads may have an intersection, there could be a possible situation that backuper thread erased data from `endpoints` table and another thread is using SQL query to select the data from the same table. As a result, second thread receives an empty result as the data was erased and the new one was not inserted yet by backupper thread. After that, SDL just does not send OnSystemRequest as the URL is empty. To fix that issue, policy component has been updated to use internal policy cache instead of direct access to policy database each time to get URL. This will guarantee that a sending thread will get an up-to-date infromation required for OnSystemRequest notification. Also, code cleanup has been done in order to remove all functions which become unused after this fix. Co-authored-by: Andrii Kalinich (GitHub) <AKalinich@luxoft.com>
* | fix/Move AppProperties struct to the Common interface (#3286)Shobhit Adlakha2020-03-121-61/+35
| | | | | | | | | | | | | | | | | | * Move AppProperties struct to the Common interface * Remove unnecessary response params from SetAppProperties and GetAppProperties response * Add missing description tag * Fix description tag in last commit
* | Fix/Perform hash check before copying over mobile api files (#3288)Shobhit Adlakha2020-03-121-2/+6
| | | | | | | | | | | | | | * Compare MOBILE_API files in the submodule directory against the ones in the interfaces directory before copying * Use cmake copy_if_different command instead of cmp * Remove trailing whitespace
* | Fix/SDL does not send BC.PolicyUpdate to HMI if no apps are registered (#3280)Shobhit Adlakha2020-03-117-2/+34
|/ | | | | | | | | * Temporary fix for allowing core to send the policyupdate rpc * Remove CanUpdate call in PolicyManagerImpl::StartPTExchange and restore CanUpdate behavior * Fix regular policy unit tests * Fix extern policy unit tests
* Use Mobile_API files from RPC Spec submodule (#3270)JackLivio2020-03-044-8628/+11
| | | | | | | | | | | | | | | | | | | | | | * Remove MOBILE_API xml and xsd Use the files pulled from the rpc spec submodule instead * Add interfaces/MOBILE_API to .gitignore * Remove extra line * Use mobile_api.xml from the rpc_spec directory * Revert "Use mobile_api.xml from the rpc_spec directory" This reverts commit a089e018e968cad2f83660a3a27833f93ad362cf. * Update src/components/interfaces/CMakeLists.txt Co-Authored-By: Shobhit Adlakha <ShobhitAd@users.noreply.github.com> Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
* Remove branches from submodules (#3272)JackLivio2020-03-032-2/+0
|
* Remove intendation for policy table snapshot (#3262)JackLivio2020-03-032-0/+2
|
* Add the missing attributes to the schema (#3266)Shobhit Adlakha2020-03-021-0/+6
|
* Add function UnwrapAppPolicies to CacheManager::Init() method (#3244)Yana Chernysheva (GitHub)2020-03-022-0/+9
| | | | | | | | | | | | | | | | | | * Add function UnwrapAppPolicies to CacheManager::Init() method * Add UnwrapAppPolicies to external flow * Delete return after unsuccessful unwrapping * Make result variable independent from result of execution UnwrapAppPolicies * Add update for external flow * Fix style * Add changes to external flow (remove dependency from result) * Add newline
* Start the new PTU after a failed retry sequence (#3208)Yevhenii Dementieiev (GitHub)2020-02-2820-33/+229
| | | | | | * Start the new PTU after a failed retry sequence in case some trigger occurs during the retry sequence Co-authored-by: Dmytro Boltovskyi (GitHub) <dboltovskyi@luxoft.com>
* Merge pull request #3261 from smartdevicelink/fix/readme_getting_started_linkJacob Keeler2020-02-281-1/+1
|\ | | | | Fix README link to Getting Started guide
| * Fix new README linkJacob Keeler2020-02-281-1/+1
|/
* Merge pull request #3120 from smartdevicelink/feature/readme_overhaulwebengineJacob Keeler2020-02-271-127/+22
|\ | | | | Update README to reference updated startup guides
| * Merge branch 'develop' into feature/readme_overhaulJacob Keeler2020-02-27548-21343/+13734
| |\ | |/ |/|
* | Feature/Web Engine support (#3221)Alexander Kutsan (GitHub)2020-02-270-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add ini file parameters for WebEngineSupport Issue : #3197 * Add Server WebSocket transport * Policy changes for Web Engine support Issue : #3197 * Changes in HMI_API for WebEngineSupport Issue : #3197 * Add application manager implementation for WebEngineSupport Add appropriate commands Make changes in application manager Issue : #3197 * Bug fix : Do not override message params if request setups it * Update SDD * fixup! Add application manager implementation for WebEngineSupport * fixup! Add Server WebSocket transport * Rename websocket dir to websocket_server * Rename WebSocketTransport adapter to WebSocketServerTransportAdapter * fixup! Update SDD * Fix/update app list after unregistration (#3252) * fixup! Rename WebSocketTransport adapter to WebSocketServerTransportAdapter * fixup! Rename websocket dir to websocket_server * Don't remove enabled WebEngine apps from pending apps * Rework WebEngine device ID generation * Fix build after back merge * Fix get app properties (#3258) Co-authored-by: Maksym Ked (GitHub) <41471947+mked-luxoft@users.noreply.github.com> * Remove unused vin_code variable Co-authored-by: Maksym Ked (GitHub) <41471947+mked-luxoft@users.noreply.github.com> Co-authored-by: Andriy Byzhynar (GitHub) <AByzhynar@luxoft.com> Co-authored-by: Ira Lytvynenko (GitHub) <ILytvynenko@luxoft.com> Co-authored-by: Andrii Kalinich (GitHub) <AKalinich@luxoft.com>
* | Feature/Web Engine support (#3221)Alexander Kutsan (GitHub)2020-02-270-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add ini file parameters for WebEngineSupport Issue : #3197 * Add Server WebSocket transport * Policy changes for Web Engine support Issue : #3197 * Changes in HMI_API for WebEngineSupport Issue : #3197 * Add application manager implementation for WebEngineSupport Add appropriate commands Make changes in application manager Issue : #3197 * Bug fix : Do not override message params if request setups it * Update SDD * fixup! Add application manager implementation for WebEngineSupport * fixup! Add Server WebSocket transport * Rename websocket dir to websocket_server * Rename WebSocketTransport adapter to WebSocketServerTransportAdapter * fixup! Update SDD * Fix/update app list after unregistration (#3252) * fixup! Rename WebSocketTransport adapter to WebSocketServerTransportAdapter * fixup! Rename websocket dir to websocket_server * Don't remove enabled WebEngine apps from pending apps * Rework WebEngine device ID generation * Fix build after back merge * Fix get app properties (#3258) Co-authored-by: Maksym Ked (GitHub) <41471947+mked-luxoft@users.noreply.github.com> * Remove unused vin_code variable Co-authored-by: Maksym Ked (GitHub) <41471947+mked-luxoft@users.noreply.github.com> Co-authored-by: Andriy Byzhynar (GitHub) <AByzhynar@luxoft.com> Co-authored-by: Ira Lytvynenko (GitHub) <ILytvynenko@luxoft.com> Co-authored-by: Andrii Kalinich (GitHub) <AKalinich@luxoft.com>