summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrii Kalinich (GitHub) <AKalinich@luxoft.com>2021-03-05 19:09:04 +0200
committerGitHub <noreply@github.com>2021-03-05 12:09:04 -0500
commitb573186f48ab77f754bff4f7040a069630c933a5 (patch)
tree11df9e7cadcff1c123b27e0662d30bc0a14a8021
parent1e26adcfdfd98ed3f034de45af092eb3d7427f5b (diff)
downloadsdl_core-b573186f48ab77f754bff4f7040a069630c933a5.tar.gz
Fix null moduleData in GetIVD response (#3565)
Removed msg_params section forwarding for case when response was not successful.
-rw-r--r--src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/mobile/get_interior_vehicle_data_request.cc6
-rw-r--r--src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/get_interior_vehicle_data_request_test.cc4
2 files changed, 6 insertions, 4 deletions
diff --git a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/mobile/get_interior_vehicle_data_request.cc b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/mobile/get_interior_vehicle_data_request.cc
index 8d3a3d796e..c3b0a7d4a5 100644
--- a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/mobile/get_interior_vehicle_data_request.cc
+++ b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/commands/mobile/get_interior_vehicle_data_request.cc
@@ -284,10 +284,8 @@ void GetInteriorVehicleDataRequest::on_event(
[message_params::kModuleData][data_mapping(module_type)];
interior_data_cache_.Add(module, module_data);
}
- } else {
- hmi_response[app_mngr::strings::msg_params].erase(
- message_params::kIsSubscribed);
}
+
std::string response_info;
GetInfo(hmi_response, response_info);
SetResourceState(ModuleType(), ResourceState::FREE);
@@ -295,7 +293,7 @@ void GetInteriorVehicleDataRequest::on_event(
SendResponse(result,
result_code,
response_info.c_str(),
- &hmi_response[app_mngr::strings::msg_params]);
+ result ? &hmi_response[app_mngr::strings::msg_params] : nullptr);
}
GetInteriorVehicleDataRequest::~GetInteriorVehicleDataRequest() {}
diff --git a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/get_interior_vehicle_data_request_test.cc b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/get_interior_vehicle_data_request_test.cc
index 20f9c27912..fdfa3ea03a 100644
--- a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/get_interior_vehicle_data_request_test.cc
+++ b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/test/commands/get_interior_vehicle_data_request_test.cc
@@ -734,6 +734,8 @@ TEST_F(GetInteriorVehicleDataRequestTest,
available_hd_chanels[1] = chanel2_index;
available_hd_chanels[2] = chanel3_index;
+ msg_params[message_params::kModuleData][message_params::kModuleId] =
+ kModuleId;
msg_params[message_params::kModuleData][message_params::kRadioControlData]
[message_params::kAvailableHdChannels] = available_hd_chanels;
@@ -792,6 +794,8 @@ TEST_F(GetInteriorVehicleDataRequestTest,
smart_objects::SmartObject(smart_objects::SmartType_Boolean);
climate_control_data = true;
+ msg_params[message_params::kModuleData][message_params::kModuleId] =
+ kModuleId;
msg_params[message_params::kModuleData][message_params::kClimateControlData]
[message_params::kClimateEnableAvailable] = climate_control_data;