diff options
author | ypostolov <ypostolov@luxoft.com> | 2020-01-09 19:57:17 +0200 |
---|---|---|
committer | yurii <ypostolov> | 2020-03-26 15:02:49 +0200 |
commit | 6c6219b2e6b2bb22df4a950d78bbde6d6dc3321c (patch) | |
tree | 58dbede43870045794ad4b0684a7bdb64a7aeae4 | |
parent | 995cf8265b9483d99fae5cf7d73ba70a2a310ceb (diff) | |
download | sdl_core-6c6219b2e6b2bb22df4a950d78bbde6d6dc3321c.tar.gz |
fix cppcheck issues in component security_manager
7 files changed, 10 insertions, 1 deletions
diff --git a/src/components/security_manager/src/crypto_manager_impl.cc b/src/components/security_manager/src/crypto_manager_impl.cc index 48b3119bec..fb9243d726 100644 --- a/src/components/security_manager/src/crypto_manager_impl.cc +++ b/src/components/security_manager/src/crypto_manager_impl.cc @@ -348,8 +348,11 @@ bool CryptoManagerImpl::IsCertificateUpdateRequired( const double seconds = difftime(certificates_time, system_time); LOG4CXX_DEBUG( - logger_, "Certificate UTC time: " << asctime(gmtime(&certificates_time))); + logger_, + // cppcheck-suppress asctimeCalled + "Certificate UTC time: " << asctime(gmtime(&certificates_time))); + // cppcheck-suppress asctimeCalled LOG4CXX_DEBUG(logger_, "Host UTC time: " << asctime(gmtime(&system_time))); LOG4CXX_DEBUG(logger_, "Seconds before expiration: " << seconds); if (seconds < 0) { diff --git a/src/components/security_manager/test/crypto_manager_impl_test.cc b/src/components/security_manager/test/crypto_manager_impl_test.cc index d30fa5ef23..1997d80038 100644 --- a/src/components/security_manager/test/crypto_manager_impl_test.cc +++ b/src/components/security_manager/test/crypto_manager_impl_test.cc @@ -137,6 +137,7 @@ class CryptoManagerTest : public testing::Test { std::string CryptoManagerTest::certificate_data_base64_; +// cppcheck-suppress syntaxError TEST_F(CryptoManagerTest, UsingBeforeInit) { EXPECT_TRUE(crypto_manager_->CreateSSLContext() == NULL); EXPECT_EQ(std::string("Initialization is not completed"), diff --git a/src/components/security_manager/test/security_manager_test.cc b/src/components/security_manager/test/security_manager_test.cc index 7906ae7006..d64c449642 100644 --- a/src/components/security_manager/test/security_manager_test.cc +++ b/src/components/security_manager/test/security_manager_test.cc @@ -183,6 +183,7 @@ class SecurityManagerTest : public ::testing::Test { * SecurityManager shall not set NULL interfaces * and shall not call any methodes */ +// cppcheck-suppress syntaxError TEST_F(SecurityManagerTest, SetNULL_Intefaces) { security_manager_->set_session_observer(NULL); security_manager_->set_protocol_handler(NULL); diff --git a/src/components/security_manager/test/security_query_matcher.cc b/src/components/security_manager/test/security_query_matcher.cc index 1bf22bf8cd..fb2ee4deb3 100644 --- a/src/components/security_manager/test/security_query_matcher.cc +++ b/src/components/security_manager/test/security_query_matcher.cc @@ -99,6 +99,7 @@ MATCHER_P(InternalErrorWithErrId, const ::security_manager::SecurityQuery::QueryHeader& q1, const ::security_manager::SecurityQuery::QueryHeader& q2); +// cppcheck-suppress unusedFunction ::testing::AssertionResult QueryHeader_EQ( const char* m_expr, const char* n_expr, diff --git a/src/components/security_manager/test/security_query_test.cc b/src/components/security_manager/test/security_query_test.cc index 6becddaaf9..7dbfcec9b5 100644 --- a/src/components/security_manager/test/security_query_test.cc +++ b/src/components/security_manager/test/security_query_test.cc @@ -91,6 +91,7 @@ class SecurityQueryTest : public ::testing::Test { * Security QueryHeader shall be the same size as RPC header * for correct working on Mobile side (3*8 byte) */ +// cppcheck-suppress syntaxError TEST_F(SecurityQueryTest, Equal_RPCHeader) { ASSERT_EQ(sizeof(SecurityQuery::QueryHeader) * 8, ::protocol_handler::ProtocolPayloadV2SizeBits()); diff --git a/src/components/security_manager/test/ssl_certificate_handshake_test.cc b/src/components/security_manager/test/ssl_certificate_handshake_test.cc index 1034bb3c83..453f6976c1 100644 --- a/src/components/security_manager/test/ssl_certificate_handshake_test.cc +++ b/src/components/security_manager/test/ssl_certificate_handshake_test.cc @@ -378,6 +378,7 @@ INSTANTIATE_TEST_CASE_P( Protocol(security_manager::TLSv1_2, security_manager::TLSv1_2), Protocol(security_manager::DTLSv1, security_manager::DTLSv1))); +// cppcheck-suppress syntaxError TEST_P(SSLHandshakeTest, NoVerification) { ASSERT_TRUE(InitServerManagers(GetParam().server_protocol, server_certificate, diff --git a/src/components/security_manager/test/ssl_context_test.cc b/src/components/security_manager/test/ssl_context_test.cc index e4d6c308bb..b568ec3a47 100644 --- a/src/components/security_manager/test/ssl_context_test.cc +++ b/src/components/security_manager/test/ssl_context_test.cc @@ -441,6 +441,7 @@ INSTANTIATE_TEST_CASE_P( #endif )); +// cppcheck-suppress syntaxError TEST_F(SSLTest, OnTSL2Protocol_BrokenHandshake) { ASSERT_EQ(security_manager::SSLContext::Handshake_Result_Success, client_ctx_->StartHandshake(&kClientBuf, &client_buf_len)); |