summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTuan Nguyen <tnguy238@ford.com>2018-01-30 13:08:32 -0800
committerTuan Nguyen <tnguy238@ford.com>2018-01-30 13:08:32 -0800
commitd4cdb2fcc3e007068a2f1ddf1b2a3e3de1cab41c (patch)
tree149388501c7b23578e25576d2a7dd1f42e0bbd27
parentdf92ac1c299e3189ac45df36b5b4ab23f79a4b50 (diff)
downloadsdl_android-bugfix/issue_671.tar.gz
#671 Fixed per code review recommendationbugfix/issue_671
- Use for loop instead of do/while loop
-rw-r--r--sdl_android/src/main/java/com/smartdevicelink/transport/SdlBroadcastReceiver.java7
1 files changed, 3 insertions, 4 deletions
diff --git a/sdl_android/src/main/java/com/smartdevicelink/transport/SdlBroadcastReceiver.java b/sdl_android/src/main/java/com/smartdevicelink/transport/SdlBroadcastReceiver.java
index 36f91becd..2176b2457 100644
--- a/sdl_android/src/main/java/com/smartdevicelink/transport/SdlBroadcastReceiver.java
+++ b/sdl_android/src/main/java/com/smartdevicelink/transport/SdlBroadcastReceiver.java
@@ -223,14 +223,13 @@ public abstract class SdlBroadcastReceiver extends BroadcastReceiver{
}
});
serviceIntent = new Intent();
- String pkgName;
- do {
- pkgName = apps.remove(0).activityInfo.packageName;
+ for (ResolveInfo app : apps) {
+ String pkgName = app.activityInfo.packageName;
serviceIntent.setComponent(new ComponentName(pkgName, pkgName + ".SdlRouterService"));
if (packageManager.resolveService(serviceIntent, PackageManager.MATCH_DEFAULT_ONLY) != null) {
break;
}
- } while (apps.size() > 1);
+ }
} else{
Log.d(TAG, "No router service running, starting ours");
//So let's start up our service since no copy is running